• R/O
  • HTTP
  • SSH
  • HTTPS

提交

標籤
無標籤

Frequently used words (click to add to your profile)

javac++androidlinuxc#windowsobjective-ccocoa誰得qtpythonphprubygameguibathyscaphec計画中(planning stage)翻訳omegatframeworktwitterdomtestvb.netdirectxゲームエンジンbtronarduinopreviewer

Commit MetaInfo

修訂378dfa482d6569b0034d21931570a4f31d940301 (tree)
時間2022-01-27 23:17:35
作者Vladimir Sementsov-Ogievskiy <vsementsov@virt...>
CommiterMarkus Armbruster

Log Message

meson: document why we don't generate trace events for tests/ and qga/

Making trace generation work for tests/ and qga/ would involve some
Meson hackery to ensure we generate the trace-events files before
trace-tool uses them. Since we don't actually support tracing there
anyway, we bypass that problem.

Let's add corresponding comments.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20220126161130.3240892-7-vsementsov@virtuozzo.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
[Pasto fixed, commit message punctuation tidied up]
Signed-off-by: Markus Armbruster <armbru@redhat.com>

Change Summary

差異

--- a/qga/meson.build
+++ b/qga/meson.build
@@ -15,6 +15,13 @@ qga_qapi_outputs = [
1515 'qga-qapi-visit.h',
1616 ]
1717
18+# Problem: to generate trace events, we'd have to add the .trace-events
19+# file to qapi_trace_events like we do in qapi/meson.build. Since
20+# qapi_trace_events is used by trace/meson.build, we'd have to move
21+# subdir('qga') above subdir('trace') in the top-level meson.build.
22+# Can't, because it would break the dependency of qga on qemuutil (which
23+# depends on trace_ss). Not worth solving now; simply suppress trace
24+# event generation instead.
1825 qga_qapi_files = custom_target('QGA QAPI files',
1926 output: qga_qapi_outputs,
2027 input: 'qapi-schema.json',
--- a/tests/meson.build
+++ b/tests/meson.build
@@ -31,6 +31,13 @@ test_qapi_outputs = [
3131 'test-qapi-visit.h',
3232 ]
3333
34+# Problem: to generate trace events, we'd have to add the .trace-events
35+# file to qapi_trace_events like we do in qapi/meson.build. Since
36+# qapi_trace_events is used by trace/meson.build, we'd have to move
37+# subdir('tests') above subdir('trace') in the top-level meson.build.
38+# Can't, because it would break the dependency of qga on qemuutil (which
39+# depends on trace_ss). Not worth solving now; simply suppress trace
40+# event generation instead.
3441 test_qapi_files = custom_target('Test QAPI files',
3542 output: test_qapi_outputs,
3643 input: files('qapi-schema/qapi-schema-test.json',