提交: 308f3a19d0af4a2444d7bbe35dc1a600bffbbaeb - BSInlinePreviewer (git)

BathyScapheで画像のインラインプレビューを可能にするプラグイン

Commit MetaInfo

• 修訂: 308f3a19d0af4a2444d7bbe35dc1a600bffbbaeb (tree)
• 時間: 2012-05-18 20:46:22
• 作者: masakih <masakih@user...>
• Commiter: masakih

Log Message

[Mod] サムネイルをキャッシュするように変更

Change Summary

• modified: BSInlinePreviewer.m

差異

--- a/BSInlinePreviewer.m
+++ b/BSInlinePreviewer.m
@@ -441,7 +441,7 @@ const NSUInteger alreadyPreviewed = NSNotFound - 1;
 - (NSImage *)downloadImageURL:(NSURL *)imageURL
 {
 	NSImage *cachedImage = [cache objectForKey:[self cacheKeyForURL:imageURL]];
-	if(cachedImage) return [self fitImage:cachedImage toSize:[self previewSize]];;
+	if(cachedImage) return cachedImage;
 	
 	NSURLRequest *req;
 	
@@ -457,24 +457,27 @@ const NSUInteger alreadyPreviewed = NSNotFound - 1;
 												  error:&err];
 	if(err) {
 		NSLog(@"Fail download. reason(%@)", [err localizedDescription]);
-		return [self notFoundImage];
+		goto notFound;
 	}
 	if(res) {
 		if(![[res MIMEType] hasPrefix:@"image/"]) {
 			NSLog(@"Fail download. reason(target type is %@)", [res MIMEType]);
-			return [self notFoundImage];
+			goto notFound;
 		}
 	}
 	
 	NSImage *image = [[[NSImage alloc] initWithData:imageData] autorelease];
 	if(!image) {
 		NSLog(@"Can not create image.");
-		return [self notFoundImage];
+		goto notFound;
 	}
 	
-	[cache setObject:image forKey:[self cacheKeyForURL:imageURL]];
-	
-	return [self fitImage:image toSize:[self previewSize]];
+	cachedImage = [self fitImage:image toSize:[self previewSize]];
+	[cache setObject:cachedImage forKey:[self cacheKeyForURL:imageURL]];
+	return cachedImage;
+notFound:
+	[cache setObject:[self notFoundImage] forKey:[self cacheKeyForURL:imageURL]];
+	return [self notFoundImage];
 }
 
 @end