提交: c64c982e729e4c4ff5c7d1878488ed216738d443 - system-coremmmm (git)

system/corennnnn

Commit MetaInfo

• 修訂: c64c982e729e4c4ff5c7d1878488ed216738d443 (tree)
• 時間: 2016-07-29 06:11:32
• 作者: Felipe Leme <felipeal@goog...>
• Commiter: Felipe Leme

Log Message

Improved keychord logging.

Often a bugreport is accidentally triggered by the combo keys, but there
is nothing in the bugreport to confirm that action because init's
klog level is KLOG_NOTICE_LEVEL.

This change change keychord's INFO messages to NOTICE, and also logs the
case where a service was not launched because ADB was disabled.

BUG: 30440213
BUG: 30345559

Change-Id: I6ccadef1621cb41dcd15e7c1660366f0e147dc7a

Change Summary

• modified: init/keychords.cpp

差異

--- a/init/keychords.cpp
+++ b/init/keychords.cpp
@@ -78,11 +78,13 @@ static void handle_keychord() {
     if (adb_enabled == "running") {
         Service* svc = ServiceManager::GetInstance().FindServiceByKeychord(id);
         if (svc) {
-            INFO("Starting service %s from keychord\n", svc->name().c_str());
+            NOTICE("Starting service '%s' from keychord %d\n", svc->name().c_str(), id);
             svc->Start();
         } else {
-            ERROR("service for keychord %d not found\n", id);
+            ERROR("Service for keychord %d not found\n", id);
         }
+    } else {
+        WARNING("Not starting service for keychord %d because ADB is disabled\n", id);
     }
 }