提交: 4e3fb8615639934fe2522c643c855ae1050c5e8e - system-coremmmm (git)

system/corennnnn

Commit MetaInfo

• 修訂: 4e3fb8615639934fe2522c643c855ae1050c5e8e (tree)
• 時間: 2009-08-08 08:41:47
• 作者: Android (Google) Code Review <android-gerrit@goog...>
• Commiter: Android (Google) Code Review

Log Message

Merge change 20502

* changes:

we actually have to saturate when doing premultilied blending with opengl

Change Summary

• modified: libpixelflinger/codeflinger/blending.cpp

差異

--- a/libpixelflinger/codeflinger/blending.cpp
+++ b/libpixelflinger/codeflinger/blending.cpp
@@ -221,17 +221,7 @@ void GGLAssembler::build_blending(
                 build_blend_factor(dst_factor, fd,
                         component, pixel, fragment, fb, scratches);
                 mul_factor_add(temp, fb, dst_factor, component_t(fragment));
-                if (fd==GGL_ONE_MINUS_SRC_ALPHA) {
-                    // XXX: in theory this is not correct, we should
-                    // saturate here. However, this mode is often
-                    // used for displaying alpha-premultiplied graphics,
-                    // in which case, saturation is not necessary.
-                    // unfortunatelly, we have no way to know.
-                    // This is a case, where we sacrifice correctness for
-                    // performance. we should probably have some heuristics.
-                } else {
-                    component_sat(temp);
-                }
+                component_sat(temp);
             }
         } else {
             // compute fs