提交: d0e8b2cc4a9c174b45871df552632f249227d818 - binutils_os216 (git)

GNU Binutils with patches for OS216

Commit MetaInfo

• 修訂: d0e8b2cc4a9c174b45871df552632f249227d818 (tree)
• 時間: 2019-06-05 07:22:42
• 作者: Pedro Alves <palves@redh...>
• Commiter: Pedro Alves

Log Message

Fix "set enum-command value junk"

With enum commands, we currently fail to notice junk after the value.

Currently:

(gdb) set print entry-values compact foo
(gdb) show print entry-values foo
Printing of function arguments at function entry is "compact".

After this fix:

(gdb) set print entry-values compact foo
Junk after item "compact": foo

gdb/ChangeLog:
yyyy-mm-dd Pedro Alves <[e-mail]>

* cli/cli-setshow.c (do_set_command) <var_enum>: Detect junk
after item.

Change Summary

• modified: gdb/cli/cli-setshow.c

差異

--- a/gdb/cli/cli-setshow.c
+++ b/gdb/cli/cli-setshow.c
@@ -413,6 +413,10 @@ do_set_command (const char *arg, int from_tty, struct cmd_list_element *c)
 	if (nmatches > 1)
 	  error (_("Ambiguous item \"%s\"."), arg);
 
+	const char *after = skip_spaces (arg + len);
+	if (*after != '\0')
+	  error (_("Junk after item \"%.*s\": %s"), len, arg, after);
+
 	if (*(const char **) c->var != match)
 	  {
 	    *(const char **) c->var = match;