提交: 941319d15194580a047484a53f232d374dc2d712 - binutils_os216 (git)

GNU Binutils with patches for OS216

Commit MetaInfo

• 修訂: 941319d15194580a047484a53f232d374dc2d712 (tree)
• 時間: 2016-03-18 23:39:09
• 作者: Yao Qi <yao.qi@lina...>
• Commiter: Yao Qi

Log Message

[spu] throw error when target_read_memory fails

I happen to see that 1 is returned in spu_software_single_step when
target_read_memory returns 1. It must be wrong. That patch changes
it to throwing an error. Note that I choose to throw error because I
find the code in the end of spu_software_single_step throws errors.

gdb:

2016-03-18 Yao Qi <[e-mail]>

* spu-tdep.c (spu_software_single_step): Throw error when
target_read_memory fails.

Change Summary

• modified: gdb/ChangeLog
• modified: gdb/spu-tdep.c

差異

--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
[phone]  Yao Qi  <[e-mail]>
+
+	* spu-tdep.c (spu_software_single_step): Throw error when
+	target_read_memory fails.
+
 2016-03-17  Jan Kratochvil  <[e-mail]>
 
 	* linux-thread-db.c (check_pid_namespace_match): Extend the message.

--- a/gdb/spu-tdep.c
+++ b/gdb/spu-tdep.c
@@ -1632,7 +1632,9 @@ spu_software_single_step (struct frame_info *frame)
   pc = get_frame_pc (frame);
 
   if (target_read_memory (pc, buf, 4))
-    return 1;
+    throw_error (MEMORY_ERROR, _("Could not read instruction at %s."),
+		 paddress (gdbarch, pc));
+
   insn = extract_unsigned_integer (buf, 4, byte_order);
 
   /* Get local store limit.  */