提交: 7550610057c51d47e3815ef93893d4f4faa7e03d - binutils_os216 (git)

GNU Binutils with patches for OS216

Commit MetaInfo

• 修訂: 7550610057c51d47e3815ef93893d4f4faa7e03d (tree)
• 時間: 2018-02-05 23:00:21
• 作者: Maciej W. Rozycki <macro@mips...>
• Commiter: Maciej W. Rozycki

Log Message

ELF/BFD: Propagate the return status from backend section processing

Fix the issue of any failure from ->elf_backend_section_processing'
not being propagated by _bfd_elf_write_object_contents'. The MIPS
_bfd_mips_elf_section_processing' handler can actually potentially
fail, however the caller currently ignores that.

bfd/
* elf.c (_bfd_elf_write_object_contents): Propagate a failure
status from ->elf_backend_section_processing'.

Change Summary

• modified: bfd/ChangeLog
• modified: bfd/elf.c

差異

--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,8 @@
[phone]  Maciej W. Rozycki  <[e-mail]>
+
+	* elf.c (_bfd_elf_write_object_contents): Propagate a failure
+	status from `->elf_backend_section_processing'.
+
 2018-02-02  Jim Wilson  <[e-mail]>
 
 	PR ld/22756

--- a/bfd/elf.c
+++ b/bfd/elf.c
@@ -6354,7 +6354,8 @@ _bfd_elf_write_object_contents (bfd *abfd)
 	= _bfd_elf_strtab_offset (elf_shstrtab (abfd),
 				  i_shdrp[count]->sh_name);
       if (bed->elf_backend_section_processing)
-	(*bed->elf_backend_section_processing) (abfd, i_shdrp[count]);
+	if (!(*bed->elf_backend_section_processing) (abfd, i_shdrp[count]))
+	  return FALSE;
       if (i_shdrp[count]->contents)
 	{
 	  bfd_size_type amt = i_shdrp[count]->sh_size;