Converting a unit reduces its veterancy
Patched. This ticked also serves as a base for #42666, taking unnecessary stuff out of transform_unit().
alienvalkyrie Patches look good. Could you export them with commit information (e.g. via git format-patch)? Then we can apply the patches so that the commit will be correctly attributed to you.
idk if backports to 2.6
Given that there probably won't be any more 2.6 releases, this is unlikely to become relevant either way.
I'm not sure whether this should be included in 3.0.0 (i.e. pushed in between the release candidate, which is currently in the works, and the release proper, in a week or so), rather than being pushed back to 3.0.1 – it's not exactly a critical fix, doubly so given that no supplied rulesets currently use unit conversion. On the other hand, for any ruleset authors using both unit conversion and autoupgrade veteran loss, having to wait until 3.0.1 wouldn't be great either.
Reply To alienvalkyrie
it's not exactly a critical fix, doubly so given that no supplied rulesets currently use unit conversion.
Not a regression since 2.6.
(But if we are forced to make RC2 for some other reason, I would consider getting this in to it)
Reply To alienvalkyrie
Patches look good. Could you export them with commit information (e.g. via git format-patch)? Then we can apply the patches so that the commit will be correctly attributed to you.
Ah yeah, have not comitted anything for so long that forgot how git works :)
alienvalkyrie Great – I'll merge these once the 3.0.0 release is done.
alienvalkyrie 
"Convert Unit" action reduces the unit's veterancy at @autoupgrade_veteran_loss@ levels. It is not documented, not logical and most probably is a bug.