When looking for #42906, I noticed that it seems like rally points are not freed when a city is destroyed, or freed any way. That's based only on reading the source, I've not yet reproduced the problem e.g. in a debugger. The only case where the rally points are freed is when city gets destroyed by building a settler. So far I've looked at the server code only, but I assume client to be affected too (as there's no free() functionality in common/)
When looking for #42906, I noticed that it seems like rally points are not freed when a city is destroyed, or freed any way. That's based only on reading the source, I've not yet reproduced the problem e.g. in a debugger. The only case where the rally points are freed is when city gets destroyed by building a settler. So far I've looked at the server code only, but I assume client to be affected too (as there's no free() functionality in common/)