Hi Kefeng, On Sat, May 29, 2021 at 12:47 PM Kefeng Wang <wangk****@huawe*****> wrote: > Use setup_initial_init_mm() helper to simplify code. > > Cc: Yoshinori Sato <ysato****@users*****> > Cc: uclin****@lists***** > Signed-off-by: Kefeng Wang <wangk****@huawe*****> Thanks for your patch! > --- a/arch/h8300/kernel/setup.c > +++ b/arch/h8300/kernel/setup.c > @@ -97,10 +97,7 @@ void __init setup_arch(char **cmdline_p) > { > unflatten_and_copy_device_tree(); > > - init_mm.start_code = (unsigned long) _stext; > - init_mm.end_code = (unsigned long) _etext; > - init_mm.end_data = (unsigned long) _edata; > - init_mm.brk = (unsigned long) 0; > + setup_initial_init_mm(_stext, _etext, _edata, (void *)0); Please use NULL instead of (void *)0. > > pr_notice("\r\n\nuClinux " CPU "\n"); > pr_notice("Flat model support (C) 1998,1999 Kenneth Albanowski, D. Jeff Dionne\n"); Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert****@linux***** In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds