Mike Rapoport <rppt****@kerne*****> writes: > On Thu, Jul 30, 2020 at 10:15:13PM +1000, Michael Ellerman wrote: >> Mike Rapoport <rppt****@kerne*****> writes: >> > From: Mike Rapoport <rppt****@linux*****> >> > >> > fadump_reserve_crash_area() reserves memory from a specified base address >> > till the end of the RAM. >> > >> > Replace iteration through the memblock.memory with a single call to >> > memblock_reserve() with appropriate that will take care of proper memory >> ^ >> parameters? >> > reservation. >> > >> > Signed-off-by: Mike Rapoport <rppt****@linux*****> >> > --- >> > arch/powerpc/kernel/fadump.c | 20 +------------------- >> > 1 file changed, 1 insertion(+), 19 deletions(-) >> >> I think this looks OK to me, but I don't have a setup to test it easily. >> I've added Hari to Cc who might be able to. >> >> But I'll give you an ack in the hope that it works :) > > Actually, I did some digging in the git log and the traversal was added > there on purpose by the commit b71a693d3db3 ("powerpc/fadump: exclude > memory holes while reserving memory in second kernel") > Presuming this is still reqruired I'm going to drop this patch and will > simply replace for_each_memblock() with for_each_mem_range() in v2. Thanks. cheers
Fork