Fujii Masao
masao****@gmail*****
2015年 8月 27日 (木) 01:44:57 JST
On Wed, Aug 26, 2015 at 11:48 PM, Masahiko Sawada <sawad****@gmail*****> wrote: > On Wed, Aug 26, 2015 at 11:06 AM, Fujii Masao <masao****@gmail*****> wrote: >> Hi, >> >> Attached patch implements the pg_gin_pending_cleanup function which cleans up >> the pending list of the specified GIN index by moving tuples in it to the main >> GIN data structure in bulk. Then this function returns the number of pages in >> the pending list cleaned up. I'd like to add this function into the master. >> >> Even without this function, we can clean up the pending list by using VACUUM. >> However, since VACUUM needs to do not only the pending list cleanup but also >> other various jobs, it usually takes a long time and its performance impact is >> likely to be big. So I think that pg_gin_pending_cleanup function is useful >> because we can clean up the list more quickly and avoid such big performance >> impact by using the function. > > +1. > It will be really useful function for maintenance GIN index. > I applied this patch to HEAD cleanly, and compiled without warning. > It looks good to me. Thanks for reviewing the patch! Applied the patch to the master. Regards, -- Fujii Masao
Fork