svnno****@sourc*****
svnno****@sourc*****
2008年 7月 9日 (水) 19:15:05 JST
Revision: 1021
http://svn.sourceforge.jp/cgi-bin/viewcvs.cgi?root=pal&view=rev&rev=1021
Author: sone
Date: 2008-07-09 19:15:05 +0900 (Wed, 09 Jul 2008)
Log Message:
-----------
Findbug 'TODO'
Modified Paths:
--------------
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/ant-tasks/src/java/org/apache/jetspeed/anttasks/ArchetypeDescriptor.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/app-servers/security/jboss/src/java/org/apache/jetspeed/appservers/security/jboss/JetspeedSecurityService.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/app-servers/security/jboss/src/java/org/apache/jetspeed/appservers/security/jboss/LoginModule.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/commons/src/java/jp/sf/pal/portal/logging/Log.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/commons/src/java/jp/sf/pal/portal/logging/LogFactory.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/commons/src/java/org/apache/jetspeed/container/JetspeedContainerServlet.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/commons/src/java/org/apache/jetspeed/dispatcher/JetspeedRequestDispatcher.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/commons/src/java/org/apache/jetspeed/portlets/layout/LayoutEvent.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/commons/src/java/org/apache/jetspeed/services/JetspeedPortletServices.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/commons/src/java/org/apache/jetspeed/util/DirectoryHelper.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/commons/src/java/org/apache/jetspeed/util/JarHelper.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/commons/src/java/org/apache/jetspeed/util/Path.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/capability/src/java/org/apache/jetspeed/capabilities/impl/ClientImpl.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/capability/src/java/org/apache/jetspeed/capabilities/impl/MediaTypeImpl.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/cm/src/java/org/apache/jetspeed/cache/impl/EhCacheDistributedImpl.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/cm/src/java/org/apache/jetspeed/cache/impl/EhCacheEventListener.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/cm/src/java/org/apache/jetspeed/cache/impl/EhCacheImpl.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/cm/src/test/org/apache/jetspeed/cache/TestContentCache.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/cm/src/test/org/apache/jetspeed/cache/TestDecorationContentCache.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/deploy-tool/src/java/org/apache/jetspeed/tools/deploy/JetspeedDeploy.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/file-cache/src/test/org/apache/jetspeed/cache/file/TestFileCache.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/jetspeed/src/java/org/apache/jetspeed/scheduler/JobEntry.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/jetspeed/src/java/org/apache/jetspeed/scheduler/MemoryBasedScheduler.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/locator/src/java/org/apache/jetspeed/locator/JetspeedLocatorDescriptor.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/locator/src/java/org/apache/jetspeed/locator/JetspeedTemplateDescriptor.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/page-manager/src/java/org/apache/jetspeed/om/folder/psml/FolderImpl.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/page-manager/src/java/org/apache/jetspeed/om/folder/psml/FolderMetaDataImpl.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/page-manager/src/java/org/apache/jetspeed/om/page/ContentFragmentImpl.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/page-manager/src/java/org/apache/jetspeed/om/page/impl/FragmentImpl.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/page-manager/src/java/org/apache/jetspeed/om/page/impl/PageImpl.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/page-manager/src/java/org/apache/jetspeed/om/page/psml/FragmentImpl.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/page-manager/src/java/org/apache/jetspeed/om/page/psml/PageImpl.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/page-manager/src/java/org/apache/jetspeed/page/AbstractPageManager.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/page-manager/src/java/org/apache/jetspeed/page/PageManagerUtils.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/page-manager/src/java/org/apache/jetspeed/page/document/psml/CastorFileSystemDocumentHandler.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/page-manager/src/java/org/apache/jetspeed/page/document/psml/FileSystemFolderHandler.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/page-manager/src/java/org/apache/jetspeed/page/impl/DatabasePageManager.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/page-manager/src/java/org/apache/jetspeed/page/impl/DatabasePageManagerCache.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/page-manager/src/java/org/apache/jetspeed/util/collections/RemovalAwareCollection.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/page-manager/src/java/org/apache/jetspeed/util/collections/RemovalAwareList.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/page-manager/src/test/org/apache/jetspeed/page/DirectoryXMLTransform.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/page-manager/src/test/org/apache/jetspeed/page/TestCastorXmlPageManager.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/page-manager/src/test/org/apache/jetspeed/page/TestDatabasePageManager.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/page-manager/src/test/org/apache/jetspeed/page/document/psml/TestCastorFileSystemDocumentHandler.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/jp/sf/pal/portal/redirect/impl/SSLRedirectValveImpl.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/jp/sf/pal/portal/servlet/UserManagerServlet.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/aggregator/impl/CommonjWorkerMonitorImpl.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/aggregator/impl/PortletAggregatorFragmentImpl.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/aggregator/impl/PortletRendererImpl.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/aggregator/impl/WorkerMonitorImpl.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/ajax/AJAXRequestImpl.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/cluster/NodeManagerImpl.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/container/DesktopPortletContainerImpl.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/container/PageHistoryValve.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/decoration/BaseDecoration.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/deployment/impl/DeployDecoratorEventListener.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/deployment/impl/DeployPortletAppEventListener.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/deployment/impl/JarExpander.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/deployment/impl/JettyDeployPortletAppEventListener.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/engine/JetspeedEngine.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/engine/JetspeedServlet.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/engine/servlet/HttpSessionWrapper.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/engine/servlet/ServletRequestImpl.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/healthcheck/validators/DatasourceAvailableHealthCheckValidator.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/healthcheck/validators/PortletApplicationAvailableHeathCheckValidator.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/layout/impl/ChangePortletAction.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/layout/impl/ExportJetspeedSchema.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/layout/impl/ExportObject.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/layout/impl/GetUserInformationAction.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/layout/impl/PortletActionSecurityConstraintsBehavior.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/layout/impl/PortletActionSecurityPathMergeBehavior.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/login/LogoutServlet.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/manager/ManagerServlet.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/pipeline/valve/HealthCheckValve.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/profiler/impl/ProfilerValveImpl.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/request/JetspeedRequestContext.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/security/impl/Jetspeed1CredentialPasswordEncoder.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/services/information/InformationProviderServiceImpl.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/services/title/DynamicTitleService.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/tools/pamanager/PortletApplicationManager.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/tools/pamanager/VersionedPortletApplicationManager.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/tools/pamanager/servletcontainer/TomcatManager.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/util/CloneUtil.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/util/MimeType.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/util/descriptor/PortletApplicationWar.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/velocity/JetspeedPowerToolFactory.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/velocity/JetspeedVelocityViewServlet.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/test/org/apache/jetspeed/aggregator/TestAggregator.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/test/org/apache/jetspeed/deployment/TestSimpleDeployment.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/test/org/apache/jetspeed/window/TestWindows.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal-site/src/java/org/apache/jetspeed/portalsite/impl/MenuImpl.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal-site/src/java/org/apache/jetspeed/portalsite/impl/MenuOptionImpl.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal-site/src/java/org/apache/jetspeed/portalsite/impl/MenuSeparatorImpl.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal-site/src/java/org/apache/jetspeed/portalsite/impl/PortalSiteSessionContextImpl.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/prefs/src/java/org/apache/jetspeed/prefs/impl/PreferencesFactoryImpl.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/prefs/src/java/org/apache/jetspeed/prefs/om/impl/NodeImpl.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/prefs/src/test/org/apache/jetspeed/prefs/TestPreferences.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/profiler/src/java/org/apache/jetspeed/profiler/rules/impl/DomainCriterionResolver.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/profiler/src/java/org/apache/jetspeed/profiler/rules/impl/RuleCriterionImpl.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/rdbms/src/java/org/apache/jetspeed/components/rdbms/ojb/ConnectionRepositoryEntry.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/registry/src/java/org/apache/jetspeed/components/portletregistry/PersistenceBrokerPortletRegistry.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/registry/src/java/org/apache/jetspeed/om/impl/GenericMetadataImpl.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/registry/src/java/org/apache/jetspeed/om/impl/LanguageSetImpl.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/registry/src/java/org/apache/jetspeed/om/impl/ParameterImpl.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/registry/src/java/org/apache/jetspeed/om/portlet/impl/PortletDefinitionImpl.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/registry/src/java/org/apache/jetspeed/om/preference/impl/PrefsPreference.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/registry/src/test/org/apache/jetspeed/components/portletentity/TestPortletEntityDAO.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/registry/src/test/org/apache/jetspeed/components/portletregistry/AbstractRegistryTest.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/registry/src/test/org/apache/jetspeed/components/portletregistry/TestPortletRegistryDAO.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/registry/src/test/org/apache/jetspeed/components/portletregistry/TestRegistryCache.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/registry/src/test/org/apache/jetspeed/components/portletregistry/direct/TestRegistryDirectAll.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/registry/src/test/org/apache/jetspeed/components/portletregistry/direct/TestRegistryDirectPart1a.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/registry/src/test/org/apache/jetspeed/components/portletregistry/direct/TestRegistryDirectPart1b.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/rewriter/src/java/org/apache/jetspeed/rewriter/html/neko/URLRewriterFilter.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/rewriter/src/test/org/apache/jetspeed/rewriter/TestNekoRewriter.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/rewriter/src/test/org/apache/jetspeed/rewriter/TestRewriterController.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/search/src/test/org/apache/jetspeed/search/TestSearch.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/security/src/java/org/apache/jetspeed/security/impl/LoginModuleProxyImpl.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/security/src/java/org/apache/jetspeed/security/impl/UserPrincipalImpl.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/security/src/java/org/apache/jetspeed/security/om/impl/InternalCredentialImpl.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/security/src/java/org/apache/jetspeed/security/om/impl/InternalGroupPrincipalImpl.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/security/src/java/org/apache/jetspeed/security/om/impl/InternalPermissionImpl.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/security/src/java/org/apache/jetspeed/security/om/impl/InternalRolePrincipalImpl.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/security/src/java/org/apache/jetspeed/security/om/impl/InternalUserPrincipalImpl.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/security/src/java/org/apache/jetspeed/security/spi/impl/ldap/LdapContextProxy.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/security/src/java/org/apache/jetspeed/security/util/GullibleSSLSocketFactory.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/serializer/src/java/org/apache/jetspeed/serializer/JetspeedDDLApplication.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/sso/src/test/org/apache/jetspeed/sso/TestSSOComponent.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/statistics/src/java/org/apache/jetspeed/statistics/impl/UserStatsImpl.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/statistics/src/test/org/apache/jetspeed/audit/TestAuditActivity.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/statistics/src/test/org/apache/jetspeed/statistics/TestStatistics.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/web-content/src/java/org/apache/jetspeed/portlet/WebContentPortlet.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/web-content/src/java/org/apache/jetspeed/portlet/webcontent/WebContentHistoryPage.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/web-content/src/java/org/apache/jetspeed/portlet/webcontent/WebContentResource.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/webapp-logging/src/java/org/apache/jetspeed/webapp/logging/IsolatedLog4JLogger.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/webapp-logging/src/java/org/apache/jetspeed/webapp/logging/Log4JConfigurator.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/jetspeed-api/src/java/org/apache/jetspeed/PortalContext.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/jetspeed-api/src/java/org/apache/jetspeed/i18n/KeyedMessage.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/jetspeed-api/src/java/org/apache/jetspeed/om/BaseSecurityReference.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/layout-portlets/src/java/org/apache/jetspeed/portlets/layout/LayoutPortlet.java
pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/taglibs/treecontrol/src/java/org/apache/webapp/admin/TreeControl.java
-------------- next part --------------
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/ant-tasks/src/java/org/apache/jetspeed/anttasks/ArchetypeDescriptor.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/ant-tasks/src/java/org/apache/jetspeed/anttasks/ArchetypeDescriptor.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/ant-tasks/src/java/org/apache/jetspeed/anttasks/ArchetypeDescriptor.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -201,6 +201,7 @@
File destDir = destFile.getParentFile();
if (!destDir.exists())
{
+ // TODO Findbugs
destDir.mkdirs();
}
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/app-servers/security/jboss/src/java/org/apache/jetspeed/appservers/security/jboss/JetspeedSecurityService.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/app-servers/security/jboss/src/java/org/apache/jetspeed/appservers/security/jboss/JetspeedSecurityService.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/app-servers/security/jboss/src/java/org/apache/jetspeed/appservers/security/jboss/JetspeedSecurityService.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -36,6 +36,7 @@
public class JetspeedSecurityService implements JetspeedSecurityServiceMBean
{
+ // TODO Findbugs
private final String JCD_ALIAS = "JetspeedSecurityServiceDS";
private GenericApplicationContext ctx;
@@ -79,8 +80,8 @@
}
/**
- * Set the JNDI name of the <code>DataSource</code> to be used to access
- * the database.
+ * Set the JNDI name of the <code>DataSource</code> to be used to access the
+ * database.
*
* @param jndiName
*/
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/app-servers/security/jboss/src/java/org/apache/jetspeed/appservers/security/jboss/LoginModule.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/app-servers/security/jboss/src/java/org/apache/jetspeed/appservers/security/jboss/LoginModule.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/app-servers/security/jboss/src/java/org/apache/jetspeed/appservers/security/jboss/LoginModule.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -36,6 +36,7 @@
* A login module that uses the JetspeedSecurityService MBean for authentication
* and role assignment.
*/
+// TODO Findbugs
public class LoginModule implements javax.security.auth.spi.LoginModule
{
@@ -45,16 +46,17 @@
/**
* Helper for delaying the creation of the JBossLoginModule. We cannot
- * access the security service MBean before <code>initialize</code> has
- * been called, but need the user manager in the constructor of
- * JBossLoginModule. The constructor that takes the user manager as argument
- * is protected (and right so), so we need this helper.
+ * access the security service MBean before <code>initialize</code> has been
+ * called, but need the user manager in the constructor of JBossLoginModule.
+ * The constructor that takes the user manager as argument is protected (and
+ * right so), so we need this helper.
*/
private class LoginModuleDelegee extends JBossLoginModule
{
public LoginModuleDelegee(UserManager userManager)
{
+ // TODO Findbugs
super(userManager);
}
}
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/commons/src/java/jp/sf/pal/portal/logging/Log.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/commons/src/java/jp/sf/pal/portal/logging/Log.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/commons/src/java/jp/sf/pal/portal/logging/Log.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -13,6 +13,7 @@
private ResourceBundle resourceBundle;
+ // TODO Findbugs
public Log(org.apache.commons.logging.Log log, ResourceBundle resourceBundle)
{
this.log = log;
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/commons/src/java/jp/sf/pal/portal/logging/LogFactory.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/commons/src/java/jp/sf/pal/portal/logging/LogFactory.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/commons/src/java/jp/sf/pal/portal/logging/LogFactory.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -7,6 +7,7 @@
public class LogFactory
{
+ // TODO Findbugs
protected static ResourceBundle resourceBundle = ResourceBundle
.getBundle("jp.sf.pal.portal.logging.resources.Messages");
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/commons/src/java/org/apache/jetspeed/container/JetspeedContainerServlet.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/commons/src/java/org/apache/jetspeed/container/JetspeedContainerServlet.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/commons/src/java/org/apache/jetspeed/container/JetspeedContainerServlet.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -61,6 +61,7 @@
private boolean started = false;
+ // TODO Findbugs
private Timer startTimer = null;
private PortalSessionsManager psm;
@@ -172,6 +173,7 @@
+ ". Starting back ground thread to start when the portal comes online.";
context.log(START_DELAYED_MSG);
startTimer = new Timer(true);
+ // TODO Findbugs
startTimer.schedule(new TimerTask()
{
@@ -479,6 +481,7 @@
startTimer.cancel();
startTimer = null;
}
+ // TODO Findbugs
else if (started)
{
started = false;
@@ -504,6 +507,7 @@
}
}
contextName = null;
+ // TODO Findbugs
psm = null;
}
}
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/commons/src/java/org/apache/jetspeed/dispatcher/JetspeedRequestDispatcher.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/commons/src/java/org/apache/jetspeed/dispatcher/JetspeedRequestDispatcher.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/commons/src/java/org/apache/jetspeed/dispatcher/JetspeedRequestDispatcher.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -35,7 +35,8 @@
* Implements the Portlet API Request Dispatcher to dispatch to portlets
*
* @author <a href="mailto:david****@blues*****">David Sean Taylor</a>
- * @version $Id: JetspeedRequestDispatcher.java 516448 2007-03-09 16:25:47Z ate $
+ * @version $Id: JetspeedRequestDispatcher.java 516448 2007-03-09 16:25:47Z ate
+ * $
*/
public class JetspeedRequestDispatcher implements PortletRequestDispatcher
{
@@ -98,6 +99,7 @@
// propagated back
Throwable rootCause = null;
+ // TODO Findbugs
if (e instanceof ServletException)
{
rootCause = ((ServletException) e).getRootCause();
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/commons/src/java/org/apache/jetspeed/portlets/layout/LayoutEvent.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/commons/src/java/org/apache/jetspeed/portlets/layout/LayoutEvent.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/commons/src/java/org/apache/jetspeed/portlets/layout/LayoutEvent.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -21,8 +21,7 @@
/**
* A LayoutEvent is used by ColumnLayout to notify its LayoutAeventListeners
* that there have been a change in the position of a fragment within the
- * layout.
- * <h3>Constant Values</h3>
+ * layout. <h3>Constant Values</h3>
* <ul>
* <li>ADDED == 0</li>
* <li>MOVED_UP == 1</li>
@@ -136,6 +135,7 @@
public boolean equals(Object obj)
{
+ // TODO Findbugs
if (obj instanceof LayoutEvent)
{
LayoutEvent event = (LayoutEvent) obj;
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/commons/src/java/org/apache/jetspeed/services/JetspeedPortletServices.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/commons/src/java/org/apache/jetspeed/services/JetspeedPortletServices.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/commons/src/java/org/apache/jetspeed/services/JetspeedPortletServices.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -49,6 +49,7 @@
public JetspeedPortletServices(Map services)
{
+ // TODO Findbugs
singleton = this;
this.services = services;
}
@@ -56,8 +57,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.components.PortletServices#addPortletService(java.lang.String,
- * java.lang.Object)
+ * @see
+ * org.apache.jetspeed.components.PortletServices#addPortletService(java
+ * .lang.String, java.lang.Object)
*/
public void addPortletService(String serviceName, Object service)
{
@@ -67,7 +69,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.components.PortletServices#getService(java.lang.String)
+ * @see
+ * org.apache.jetspeed.components.PortletServices#getService(java.lang.String
+ * )
*/
public Object getService(String serviceName)
{
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/commons/src/java/org/apache/jetspeed/util/DirectoryHelper.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/commons/src/java/org/apache/jetspeed/util/DirectoryHelper.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/commons/src/java/org/apache/jetspeed/util/DirectoryHelper.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -42,6 +42,7 @@
super();
if (!directory.exists())
{
+ // TODO Findbugs
directory.mkdirs();
}
@@ -121,6 +122,7 @@
if (child.isFile())
{
File toFile = new File(dstDir, child.getName());
+ // TODO Findbugs
toFile.createNewFile();
srcChannel = new FileInputStream(child).getChannel();
dstChannel = new FileOutputStream(toFile).getChannel();
@@ -131,6 +133,7 @@
else
{
File newSubDir = new File(dstDir, child.getName());
+ // TODO Findbugs
newSubDir.mkdir();
copyFiles(child, newSubDir, fileFilter);
}
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/commons/src/java/org/apache/jetspeed/util/JarHelper.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/commons/src/java/org/apache/jetspeed/util/JarHelper.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/commons/src/java/org/apache/jetspeed/util/JarHelper.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -30,9 +30,9 @@
/**
* @author <a href="mailto:weave****@apach*****">Scott T. Weaver </a>
*
- * Creates a a temp directory to which a JarFile is expanded and can be
- * manipulated. All operations are performed by an internal instance of
- * {@link DirectoryHelper}.
+ * Creates a a temp directory to which a JarFile is expanded and can be
+ * manipulated. All operations are performed by an internal instance of
+ * {@link DirectoryHelper}.
*
*/
public class JarHelper extends AbstractFileSystemHelper implements
@@ -67,6 +67,7 @@
if (!jarRoot.exists())
{
+ // TODO Findbugs
jarRoot.mkdirs();
}
jarRoot.deleteOnExit();
@@ -79,6 +80,7 @@
if (jarEntry.isDirectory())
{
File newDir = new File(jarRoot, name);
+ // TODO Findbugs
newDir.mkdir();
newDir.deleteOnExit();
}
@@ -109,9 +111,11 @@
File file = new File(jarRoot, name);
if (!file.getParentFile().exists())
{
+ // TODO Findbugs
file.getParentFile().mkdirs();
file.getParentFile().deleteOnExit();
}
+ // TODO Findbugs
file.createNewFile();
file.deleteOnExit();
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/commons/src/java/org/apache/jetspeed/util/Path.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/commons/src/java/org/apache/jetspeed/util/Path.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/commons/src/java/org/apache/jetspeed/util/Path.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -29,28 +29,28 @@
* <h2>Rules for Interperting Pathes</h2>
* <p>
* Below are the rules for how the constructor interprets literal paths.
- * <strong>NOTE</strong> the {@link addSegment(String)} interprets string
- * pathes in a somewhat different manner. <table>
+ * <strong>NOTE</strong> the {@link addSegment(String)} interprets string pathes
+ * in a somewhat different manner.
+ * <table>
* <tr>
* <th>Literal Path</th>
* <th>Interpretation</th>
* </tr>
- * <td> <i>/foo/bar/index.html</i> </td>
+ * <td><i>/foo/bar/index.html</i></td>
* <td> <code>foo</code> and <code>bar</code> will be considered directory
* segments while <code>index.html</code> will be considered a file segment.
- * This means that the <code>baseName</code> will be set to <i>index</i> and
- * the <code>fileExtension</code> will be set to <i>.html</i> </td>
+ * This means that the <code>baseName</code> will be set to <i>index</i> and the
+ * <code>fileExtension</code> will be set to <i>.html</i></td>
* <tr>
- * <td> <i>/foo/bar/</i>, <i>/foo/bar</i>, <i>foo/bar/</i> <i>foo/bar</i>
- * </td>
+ * <td><i>/foo/bar/</i>, <i>/foo/bar</i>, <i>foo/bar/</i> <i>foo/bar</i></td>
* <td>
* <p>
- * <code>foo</code> and <code>bar</code> will be considered directory
- * segments. <code>baseName</code> and <code>fileExtension</code> will be
- * left as <code>null</code>.
+ * <code>foo</code> and <code>bar</code> will be considered directory segments.
+ * <code>baseName</code> and <code>fileExtension</code> will be left as
+ * <code>null</code>.
* <p>
- * I cases where a file has no extension you must use the
- * {@link setFileSegment(String))} to manually set the file. This causes the
+ * I cases where a file has no extension you must use the {@link
+ * setFileSegment(String))} to manually set the file. This causes the
* <code>baseName</code> to be set to the file name specified and the
* <code>fileExtension</code> will be set to the empty string ("").
* </p>
@@ -60,6 +60,7 @@
*
* @author <href a="mailto:weave****@apach*****">Scott T. Weaver</a>
*/
+// TODO Findbugs
public class Path implements Serializable, Cloneable
{
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/capability/src/java/org/apache/jetspeed/capabilities/impl/ClientImpl.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/capability/src/java/org/apache/jetspeed/capabilities/impl/ClientImpl.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/capability/src/java/org/apache/jetspeed/capabilities/impl/ClientImpl.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -64,10 +64,12 @@
*/
public boolean equals(Object object)
{
+ // TODO Findbugs
if (object == this) return true;
if (object == null) { return false; }
+ // TODO Findbugs
ClientImpl obj = (ClientImpl) object;
if (name != null)
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/capability/src/java/org/apache/jetspeed/capabilities/impl/MediaTypeImpl.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/capability/src/java/org/apache/jetspeed/capabilities/impl/MediaTypeImpl.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/capability/src/java/org/apache/jetspeed/capabilities/impl/MediaTypeImpl.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -55,6 +55,7 @@
public MediaTypeImpl(long id, String name, int _hidden, String mimeType,
String title, String description, String image, String role)
{
+ // TODO Findbugs
this.mimetypes.add(mimeType);
}
@@ -64,9 +65,11 @@
*/
public boolean equals(Object object)
{
+ // TODO Findbugs
if (this == object) return true;
if (object == null) return false;
+ // TODO Findbugs
MediaTypeImpl obj = (MediaTypeImpl) object;
if (this.name != null)
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/cm/src/java/org/apache/jetspeed/cache/impl/EhCacheDistributedImpl.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/cm/src/java/org/apache/jetspeed/cache/impl/EhCacheDistributedImpl.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/cm/src/java/org/apache/jetspeed/cache/impl/EhCacheDistributedImpl.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -129,6 +129,7 @@
public Object clone() throws CloneNotSupportedException
{
+ // TODO Findbugs
return null;
}
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/cm/src/java/org/apache/jetspeed/cache/impl/EhCacheEventListener.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/cm/src/java/org/apache/jetspeed/cache/impl/EhCacheEventListener.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/cm/src/java/org/apache/jetspeed/cache/impl/EhCacheEventListener.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -26,6 +26,7 @@
public Object clone() throws CloneNotSupportedException
{
+ // TODO Findbugs
return null;
}
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/cm/src/java/org/apache/jetspeed/cache/impl/EhCacheImpl.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/cm/src/java/org/apache/jetspeed/cache/impl/EhCacheImpl.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/cm/src/java/org/apache/jetspeed/cache/impl/EhCacheImpl.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -140,6 +140,7 @@
public Object clone() throws CloneNotSupportedException
{
+ // TODO Findbugs
return super.clone();
}
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/cm/src/test/org/apache/jetspeed/cache/TestContentCache.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/cm/src/test/org/apache/jetspeed/cache/TestContentCache.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/cm/src/test/org/apache/jetspeed/cache/TestContentCache.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -259,6 +259,7 @@
private String name;
+ // TODO Findbugs
public MockPrincipal(String name)
{
this.name = name;
@@ -273,6 +274,7 @@
class MockPortletContent implements PortletContent
{
+ // TODO Findbugs
private boolean complete = false;
private ContentCacheKey cacheKey;
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/cm/src/test/org/apache/jetspeed/cache/TestDecorationContentCache.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/cm/src/test/org/apache/jetspeed/cache/TestDecorationContentCache.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/cm/src/test/org/apache/jetspeed/cache/TestDecorationContentCache.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -250,6 +250,7 @@
private String name;
+ // TODO Findbugs
public MockPrincipal(String name)
{
this.name = name;
@@ -266,6 +267,7 @@
private String pageId;
+ // TODO Findbugs
public MockTheme(String pageId)
{
this.pageId = pageId;
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/deploy-tool/src/java/org/apache/jetspeed/tools/deploy/JetspeedDeploy.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/deploy-tool/src/java/org/apache/jetspeed/tools/deploy/JetspeedDeploy.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/deploy-tool/src/java/org/apache/jetspeed/tools/deploy/JetspeedDeploy.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -240,6 +240,7 @@
srcChannel = null;
dstChannel.close();
dstChannel = null;
+ // TODO Findbugs
tempFile.delete();
tempFile = null;
System.out.println("War " + outputName + " created");
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/file-cache/src/test/org/apache/jetspeed/cache/file/TestFileCache.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/file-cache/src/test/org/apache/jetspeed/cache/file/TestFileCache.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/file-cache/src/test/org/apache/jetspeed/cache/file/TestFileCache.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -51,8 +51,8 @@
/**
* Creates the test suite.
*
- * @return a test suite (<code>TestSuite</code>) that includes all
- * methods starting with "test"
+ * @return a test suite (<code>TestSuite</code>) that includes all methods
+ * starting with "test"
*/
public static Test suite()
{
@@ -146,6 +146,7 @@
.getCanonicalPath());
assertNotNull(stuff);
+ // TODO Findbugs
files[18].setLastModified(new Date().getTime());
Thread.sleep(9000);
@@ -161,6 +162,7 @@
removeTestFiles();
}
+ // TODO Findbugs
catch (Exception e)
{
fail(ExceptionUtils.getStackTrace(e));
@@ -186,6 +188,7 @@
{
String testFile = TEST_DIRECTORY + "/testFile-" + ix + ".psml";
File file = new File(testFile);
+ // TODO Findbugs
if (file.exists()) file.delete();
}
}
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/jetspeed/src/java/org/apache/jetspeed/scheduler/JobEntry.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/jetspeed/src/java/org/apache/jetspeed/scheduler/JobEntry.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/jetspeed/src/java/org/apache/jetspeed/scheduler/JobEntry.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -58,8 +58,8 @@
*
* Schedule a job to run on a certain point of time.<br>
*
- * Example 1: Run the DefaultScheduledJob at 8:00am every 15th of the month -
- * <br>
+ * Example 1: Run the DefaultScheduledJob at 8:00am every 15th of the month
+ * - <br>
*
* JobEntry je = new JobEntry(0,0,8,15,"DefaultScheduledJob");<br>
*
@@ -87,8 +87,8 @@
* Value for entry "month days".
* @param task
* Task to execute.
- * @exception Exception,
- * a generic exception.
+ * @exception Exception
+ * , a generic exception.
*/
public JobEntry(int sec, int min, int hour, int wd, int day_mo, String task)
throws Exception
@@ -111,6 +111,7 @@
*/
public int compareTo(Object je)
{
+ // TODO Findbugs
int result = -1;
if (je instanceof JobEntry)
{
@@ -182,8 +183,8 @@
* 3. Calculate the diff in time between the current time and the next run
* time.<br>
*
- * @exception Exception,
- * a generic exception.
+ * @exception Exception
+ * , a generic exception.
*/
public void calcRunTime() throws Exception
{
@@ -276,8 +277,8 @@
* please jump in!
*
* @return A number specifying the type of schedule. See calcRunTime().
- * @exception Exception,
- * a generic exception.
+ * @exception Exception
+ * , a generic exception.
*/
private int evaluateJobType() throws Exception
{
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/jetspeed/src/java/org/apache/jetspeed/scheduler/MemoryBasedScheduler.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/jetspeed/src/java/org/apache/jetspeed/scheduler/MemoryBasedScheduler.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/jetspeed/src/java/org/apache/jetspeed/scheduler/MemoryBasedScheduler.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -65,8 +65,8 @@
/**
* Constructor.
*
- * @exception Exception,
- * a generic exception.
+ * @exception Exception
+ * , a generic exception.
*/
public MemoryBasedScheduler(Configuration config) throws Exception
{
@@ -85,6 +85,7 @@
{
super.start();
scheduleQueue = new JobQueue();
+ // TODO Findbugs
mainLoop = new MainLoop();
List jobProps = getConfiguration().getList("jobs");
@@ -147,8 +148,8 @@
* @param oid
* The int id for the job.
* @return A JobEntry.
- * @exception Exception,
- * a generic exception.
+ * @exception Exception
+ * , a generic exception.
*/
public JobEntry getJob(int oid) throws Exception
{
@@ -161,8 +162,8 @@
*
* @param je
* A JobEntry with the job to add.
- * @exception Exception,
- * a generic exception.
+ * @exception Exception
+ * , a generic exception.
*/
public void addJob(JobEntry je) throws Exception
{
@@ -176,8 +177,8 @@
*
* @param je
* A JobEntry with the job to remove.
- * @exception Exception,
- * a generic exception.
+ * @exception Exception
+ * , a generic exception.
*/
public void removeJob(JobEntry je) throws Exception
{
@@ -191,8 +192,8 @@
*
* @param je
* A JobEntry with the job to modify
- * @exception Exception,
- * a generic exception.
+ * @exception Exception
+ * , a generic exception.
*/
public void updateJob(JobEntry je) throws Exception
{
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/locator/src/java/org/apache/jetspeed/locator/JetspeedLocatorDescriptor.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/locator/src/java/org/apache/jetspeed/locator/JetspeedLocatorDescriptor.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/locator/src/java/org/apache/jetspeed/locator/JetspeedLocatorDescriptor.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -20,7 +20,8 @@
* Jetspeed default Locator Descriptor implementation
*
* @author <a href="mailto:taylo****@apach*****">David Sean Taylor</a>
- * @version $Id: JetspeedLocatorDescriptor.java 516448 2007-03-09 16:25:47Z ate $
+ * @version $Id: JetspeedLocatorDescriptor.java 516448 2007-03-09 16:25:47Z ate
+ * $
*/
public class JetspeedLocatorDescriptor implements LocatorDescriptor
{
@@ -147,7 +148,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.cps.template.TemplateLocator#setType(java.lang.String)
+ * @see
+ * org.apache.jetspeed.cps.template.TemplateLocator#setType(java.lang.String
+ * )
*/
public void setType(String type)
{
@@ -167,7 +170,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.cps.template.TemplateLocator#setName(java.lang.String)
+ * @see
+ * org.apache.jetspeed.cps.template.TemplateLocator#setName(java.lang.String
+ * )
*/
public void setName(String name)
{
@@ -187,7 +192,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.cps.template.TemplateLocator#setMediaType(java.lang.String)
+ * @see
+ * org.apache.jetspeed.cps.template.TemplateLocator#setMediaType(java.lang
+ * .String)
*/
public void setMediaType(String mediaType)
{
@@ -207,7 +214,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.cps.template.TemplateLocator#setLanguage(java.lang.String)
+ * @see
+ * org.apache.jetspeed.cps.template.TemplateLocator#setLanguage(java.lang
+ * .String)
*/
public void setLanguage(String language)
{
@@ -227,7 +236,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.cps.template.TemplateLocator#setCountry(java.lang.String)
+ * @see
+ * org.apache.jetspeed.cps.template.TemplateLocator#setCountry(java.lang
+ * .String)
*/
public void setCountry(String country)
{
@@ -240,6 +251,7 @@
*/
public Object clone() throws java.lang.CloneNotSupportedException
{
+ // TODO Findbugs
return super.clone();
}
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/locator/src/java/org/apache/jetspeed/locator/JetspeedTemplateDescriptor.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/locator/src/java/org/apache/jetspeed/locator/JetspeedTemplateDescriptor.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/locator/src/java/org/apache/jetspeed/locator/JetspeedTemplateDescriptor.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -22,7 +22,8 @@
* Jetspeed default Template Descriptor implementation
*
* @author <a href="mailto:taylo****@apach*****">David Sean Taylor</a>
- * @version $Id: JetspeedTemplateDescriptor.java 516448 2007-03-09 16:25:47Z ate $
+ * @version $Id: JetspeedTemplateDescriptor.java 516448 2007-03-09 16:25:47Z ate
+ * $
*/
public class JetspeedTemplateDescriptor extends JetspeedLocatorDescriptor
implements TemplateDescriptor
@@ -59,7 +60,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.cps.template.Template#setAbsolutePath(java.lang.String)
+ * @see
+ * org.apache.jetspeed.cps.template.Template#setAbsolutePath(java.lang.String
+ * )
*/
public void setAbsolutePath(String path)
{
@@ -72,6 +75,7 @@
*/
public Object clone() throws java.lang.CloneNotSupportedException
{
+ // TODO Findbugs
return super.clone();
}
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/page-manager/src/java/org/apache/jetspeed/om/folder/psml/FolderImpl.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/page-manager/src/java/org/apache/jetspeed/om/folder/psml/FolderImpl.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/page-manager/src/java/org/apache/jetspeed/om/folder/psml/FolderImpl.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -130,7 +130,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.om.folder.Folder#getEffectiveDefaultDecorator(java.lang.String)
+ * @see
+ * org.apache.jetspeed.om.folder.Folder#getEffectiveDefaultDecorator(java
+ * .lang.String)
*/
public String getEffectiveDefaultDecorator(String fragmentType)
{
@@ -149,7 +151,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.om.folder.Folder#getDefaultDecorator(java.lang.String)
+ * @see
+ * org.apache.jetspeed.om.folder.Folder#getDefaultDecorator(java.lang.String
+ * )
*/
public String getDefaultDecorator(String fragmentType)
{
@@ -159,8 +163,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.om.folder.Folder#setDefaultDecorator(java.lang.String,
- * java.lang.String)
+ * @see
+ * org.apache.jetspeed.om.folder.Folder#setDefaultDecorator(java.lang.String
+ * , java.lang.String)
*/
public void setDefaultDecorator(String decoratorName, String fragmentType)
{
@@ -180,7 +185,8 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.om.folder.Folder#setDocumentOrder(java.util.List)
+ * @see
+ * org.apache.jetspeed.om.folder.Folder#setDocumentOrder(java.util.List)
*/
public void setDocumentOrder(List docIndexes)
{
@@ -660,6 +666,7 @@
*/
public void setFolderHandler(FolderHandler handler)
{
+ // TODO Findbugs
this.folderHandler = handler;
}
@@ -886,6 +893,7 @@
*/
public void reset()
{
+ // TODO Findbugs
allNodes = null;
}
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/page-manager/src/java/org/apache/jetspeed/om/folder/psml/FolderMetaDataImpl.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/page-manager/src/java/org/apache/jetspeed/om/folder/psml/FolderMetaDataImpl.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/page-manager/src/java/org/apache/jetspeed/om/folder/psml/FolderMetaDataImpl.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -41,6 +41,7 @@
public static final String DOCUMENT_TYPE = "folder.metadata";
+ // TODO Findbugs
private DefaultsImpl defaults = new DefaultsImpl();
private List docOrder;
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/page-manager/src/java/org/apache/jetspeed/om/page/ContentFragmentImpl.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/page-manager/src/java/org/apache/jetspeed/om/page/ContentFragmentImpl.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/page-manager/src/java/org/apache/jetspeed/om/page/ContentFragmentImpl.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -122,6 +122,7 @@
try
{
log.debug("Waiting on content for Fragment " + getId());
+ // TODO Findbugs
portletContent.wait();
return portletContent.getContent();
}
@@ -147,7 +148,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.om.page.ContentFragment#overrideRenderedContent(java.lang.String)
+ * @see
+ * org.apache.jetspeed.om.page.ContentFragment#overrideRenderedContent(java
+ * .lang.String)
*/
public void overrideRenderedContent(String contnent)
{
@@ -169,7 +172,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.om.page.ContentFragment#setPortletContent(org.apache.jetspeed.aggregator.PortletContent)
+ * @see
+ * org.apache.jetspeed.om.page.ContentFragment#setPortletContent(org.apache
+ * .jetspeed.aggregator.PortletContent)
*/
public void setPortletContent(PortletContent portletContent)
{
@@ -223,7 +228,8 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.om.page.Fragment#getIntProperty(java.lang.String)
+ * @see
+ * org.apache.jetspeed.om.page.Fragment#getIntProperty(java.lang.String)
*/
public int getIntProperty(String propName)
{
@@ -234,7 +240,8 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.om.page.Fragment#getFloatProperty(java.lang.String)
+ * @see
+ * org.apache.jetspeed.om.page.Fragment#getFloatProperty(java.lang.String)
*/
public float getFloatProperty(String propName)
{
@@ -422,7 +429,8 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.om.page.Fragment#setLayoutSizes(java.lang.String)
+ * @see
+ * org.apache.jetspeed.om.page.Fragment#setLayoutSizes(java.lang.String)
*/
public void setLayoutSizes(String sizes)
{
@@ -559,7 +567,8 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.om.page.BaseElement#setShortTitle(java.lang.String)
+ * @see
+ * org.apache.jetspeed.om.page.BaseElement#setShortTitle(java.lang.String)
*/
public void setShortTitle(String title)
{
@@ -581,7 +590,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.om.common.SecuredResource#checkAccess(java.lang.String)
+ * @see
+ * org.apache.jetspeed.om.common.SecuredResource#checkAccess(java.lang.String
+ * )
*/
public void checkAccess(String actions) throws SecurityException
{
@@ -592,7 +603,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.om.common.SecuredResource#checkConstraints(java.lang.String)
+ * @see
+ * org.apache.jetspeed.om.common.SecuredResource#checkConstraints(java.lang
+ * .String)
*/
public void checkConstraints(String actions) throws SecurityException
{
@@ -614,7 +627,8 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.om.common.SecuredResource#getConstraintsEnabled()
+ * @see
+ * org.apache.jetspeed.om.common.SecuredResource#getConstraintsEnabled()
*/
public boolean getConstraintsEnabled()
{
@@ -625,7 +639,8 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.om.common.SecuredResource#getPermissionsEnabled()
+ * @see
+ * org.apache.jetspeed.om.common.SecuredResource#getPermissionsEnabled()
*/
public boolean getPermissionsEnabled()
{
@@ -636,7 +651,8 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.om.common.SecuredResource#getSecurityConstraints()
+ * @see
+ * org.apache.jetspeed.om.common.SecuredResource#getSecurityConstraints()
*/
public SecurityConstraints getSecurityConstraints()
{
@@ -647,7 +663,8 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.om.common.SecuredResource#newSecurityConstraints()
+ * @see
+ * org.apache.jetspeed.om.common.SecuredResource#newSecurityConstraints()
*/
public SecurityConstraints newSecurityConstraints()
{
@@ -658,7 +675,8 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.om.common.SecuredResource#newSecurityConstraint()
+ * @see
+ * org.apache.jetspeed.om.common.SecuredResource#newSecurityConstraint()
*/
public SecurityConstraint newSecurityConstraint()
{
@@ -669,7 +687,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.om.common.SecuredResource#setSecurityConstraints(org.apache.jetspeed.om.common.SecurityConstraints)
+ * @see
+ * org.apache.jetspeed.om.common.SecuredResource#setSecurityConstraints(
+ * org.apache.jetspeed.om.common.SecurityConstraints)
*/
public void setSecurityConstraints(SecurityConstraints constraints)
{
@@ -701,6 +721,7 @@
return cf;
}
+ // TODO Findbugs
protected final class ContentFragmentList implements List, Serializable
{
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/page-manager/src/java/org/apache/jetspeed/om/page/impl/FragmentImpl.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/page-manager/src/java/org/apache/jetspeed/om/page/impl/FragmentImpl.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/page-manager/src/java/org/apache/jetspeed/om/page/impl/FragmentImpl.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -75,10 +75,13 @@
private List preferences;
+ // TODO Findbugs
private FragmentList fragmentsList;
+ // TODO Findbugs
private FragmentPropertyMap propertiesMap;
+ // TODO Findbugs
private FragmentPreferenceList fragmentPreferences;
private PageImpl page;
@@ -502,7 +505,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.om.page.impl.BaseElementImpl#getEffectivePageSecurity()
+ * @see
+ * org.apache.jetspeed.om.page.impl.BaseElementImpl#getEffectivePageSecurity
+ * ()
*/
public PageSecurity getEffectivePageSecurity()
{
@@ -514,7 +519,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.om.page.impl.BaseElementImpl#getLogicalPermissionPath()
+ * @see
+ * org.apache.jetspeed.om.page.impl.BaseElementImpl#getLogicalPermissionPath
+ * ()
*/
public String getLogicalPermissionPath()
{
@@ -528,7 +535,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.om.page.impl.BaseElementImpl#getPhysicalPermissionPath()
+ * @see
+ * org.apache.jetspeed.om.page.impl.BaseElementImpl#getPhysicalPermissionPath
+ * ()
*/
public String getPhysicalPermissionPath()
{
@@ -542,7 +551,8 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.om.page.impl.BaseElementImpl#resetCachedSecurityConstraints()
+ * @seeorg.apache.jetspeed.om.page.impl.BaseElementImpl#
+ * resetCachedSecurityConstraints()
*/
public void resetCachedSecurityConstraints()
{
@@ -562,8 +572,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.om.page.impl.BaseElementImpl#checkPermissions(java.lang.String,
- * int, boolean, boolean)
+ * @see
+ * org.apache.jetspeed.om.page.impl.BaseElementImpl#checkPermissions(java
+ * .lang.String, int, boolean, boolean)
*/
public void checkPermissions(String path, int mask, boolean checkNodeOnly,
boolean checkParentsOnly) throws SecurityException
@@ -576,7 +587,8 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.om.common.SecuredResource#getConstraintsEnabled()
+ * @see
+ * org.apache.jetspeed.om.common.SecuredResource#getConstraintsEnabled()
*/
public boolean getConstraintsEnabled()
{
@@ -587,7 +599,8 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.om.common.SecuredResource#getPermissionsEnabled()
+ * @see
+ * org.apache.jetspeed.om.common.SecuredResource#getPermissionsEnabled()
*/
public boolean getPermissionsEnabled()
{
@@ -724,7 +737,8 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.om.page.Fragment#getIntProperty(java.lang.String)
+ * @see
+ * org.apache.jetspeed.om.page.Fragment#getIntProperty(java.lang.String)
*/
public int getIntProperty(String propName)
{
@@ -736,7 +750,8 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.om.page.Fragment#getFloatProperty(java.lang.String)
+ * @see
+ * org.apache.jetspeed.om.page.Fragment#getFloatProperty(java.lang.String)
*/
public float getFloatProperty(String propName)
{
@@ -832,7 +847,8 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.om.page.Fragment#setLayoutSizes(java.lang.String)
+ * @see
+ * org.apache.jetspeed.om.page.Fragment#setLayoutSizes(java.lang.String)
*/
public void setLayoutSizes(String sizes)
{
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/page-manager/src/java/org/apache/jetspeed/om/page/impl/PageImpl.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/page-manager/src/java/org/apache/jetspeed/om/page/impl/PageImpl.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/page-manager/src/java/org/apache/jetspeed/om/page/impl/PageImpl.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -52,6 +52,7 @@
private List menus;
+ // TODO Findbugs
private PageMenuDefinitionList menuDefinitions;
private FragmentImpl removedFragment;
@@ -82,7 +83,8 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.om.page.impl.BaseElementImpl#resetCachedSecurityConstraints()
+ * @seeorg.apache.jetspeed.om.page.impl.BaseElementImpl#
+ * resetCachedSecurityConstraints()
*/
public void resetCachedSecurityConstraints()
{
@@ -98,7 +100,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.page.document.impl.NodeImpl#newPageMetadata(java.util.Collection)
+ * @see
+ * org.apache.jetspeed.page.document.impl.NodeImpl#newPageMetadata(java.
+ * util.Collection)
*/
public PageMetadataImpl newPageMetadata(Collection fields)
{
@@ -131,7 +135,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.om.page.Page#getEffectiveDefaultDecorator(java.lang.String)
+ * @see
+ * org.apache.jetspeed.om.page.Page#getEffectiveDefaultDecorator(java.lang
+ * .String)
*/
public String getEffectiveDefaultDecorator(String fragmentType)
{
@@ -151,7 +157,8 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.om.page.Page#getDefaultDecorator(java.lang.String)
+ * @see
+ * org.apache.jetspeed.om.page.Page#getDefaultDecorator(java.lang.String)
*/
public String getDefaultDecorator(String fragmentType)
{
@@ -167,7 +174,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.om.page.Page#getDefaultDecorator(java.lang.String,java.lang.String)
+ * @see
+ * org.apache.jetspeed.om.page.Page#getDefaultDecorator(java.lang.String
+ * ,java.lang.String)
*/
public void setDefaultDecorator(String decoratorName, String fragmentType)
{
@@ -211,7 +220,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.om.page.Page#setRootFragment(org.apache.jetspeed.om.page.Fragment)
+ * @see
+ * org.apache.jetspeed.om.page.Page#setRootFragment(org.apache.jetspeed.
+ * om.page.Fragment)
*/
public void setRootFragment(Fragment fragment)
{
@@ -304,7 +315,8 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.om.page.Page#removeFragmentById(java.lang.String)
+ * @see
+ * org.apache.jetspeed.om.page.Page#removeFragmentById(java.lang.String)
*/
public Fragment removeFragmentById(String id)
{
@@ -328,7 +340,8 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.om.page.Page#getFragmentsByName(java.lang.String)
+ * @see
+ * org.apache.jetspeed.om.page.Page#getFragmentsByName(java.lang.String)
*/
public List getFragmentsByName(String name)
{
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/page-manager/src/java/org/apache/jetspeed/om/page/psml/FragmentImpl.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/page-manager/src/java/org/apache/jetspeed/om/page/psml/FragmentImpl.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/page-manager/src/java/org/apache/jetspeed/om/page/psml/FragmentImpl.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -59,6 +59,7 @@
private String name;
+ // TODO Findbugs
private FragmentList fragmentsList;
private PageImpl page;
@@ -394,6 +395,7 @@
*/
public boolean equals(Object obj)
{
+ // TODO Findbugs
boolean isEqual = false;
if (obj != null && obj instanceof Fragment)
{
@@ -499,7 +501,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.om.page.psml.AbstractElementImpl#getEffectivePageSecurity()
+ * @see
+ * org.apache.jetspeed.om.page.psml.AbstractElementImpl#getEffectivePageSecurity
+ * ()
*/
public PageSecurity getEffectivePageSecurity()
{
@@ -511,7 +515,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.om.page.psml.AbstractElementImpl#getLogicalPermissionPath()
+ * @see
+ * org.apache.jetspeed.om.page.psml.AbstractElementImpl#getLogicalPermissionPath
+ * ()
*/
public String getLogicalPermissionPath()
{
@@ -525,7 +531,8 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.om.page.psml.AbstractBaseElementImpl#getPhysicalPermissionPath()
+ * @seeorg.apache.jetspeed.om.page.psml.AbstractBaseElementImpl#
+ * getPhysicalPermissionPath()
*/
public String getPhysicalPermissionPath()
{
@@ -539,8 +546,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.om.page.psml.AbstractElementImpl#checkPermissions(java.lang.String,
- * int, boolean, boolean)
+ * @see
+ * org.apache.jetspeed.om.page.psml.AbstractElementImpl#checkPermissions
+ * (java.lang.String, int, boolean, boolean)
*/
public void checkPermissions(String path, int mask, boolean checkNodeOnly,
boolean checkParentsOnly) throws SecurityException
@@ -553,7 +561,8 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.om.common.SecuredResource#getConstraintsEnabled()
+ * @see
+ * org.apache.jetspeed.om.common.SecuredResource#getConstraintsEnabled()
*/
public boolean getConstraintsEnabled()
{
@@ -564,7 +573,8 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.om.common.SecuredResource#getPermissionsEnabled()
+ * @see
+ * org.apache.jetspeed.om.common.SecuredResource#getPermissionsEnabled()
*/
public boolean getPermissionsEnabled()
{
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/page-manager/src/java/org/apache/jetspeed/om/page/psml/PageImpl.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/page-manager/src/java/org/apache/jetspeed/om/page/psml/PageImpl.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/page-manager/src/java/org/apache/jetspeed/om/page/psml/PageImpl.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -44,6 +44,7 @@
public class PageImpl extends DocumentImpl implements Page
{
+ // TODO Findbugs
private DefaultsImpl defaults = new DefaultsImpl();
private Fragment root = null;
@@ -126,7 +127,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.om.page.Page#getEffectiveDefaultDecorator(java.lang.String)
+ * @see
+ * org.apache.jetspeed.om.page.Page#getEffectiveDefaultDecorator(java.lang
+ * .String)
*/
public String getEffectiveDefaultDecorator(String fragmentType)
{
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/page-manager/src/java/org/apache/jetspeed/page/AbstractPageManager.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/page-manager/src/java/org/apache/jetspeed/page/AbstractPageManager.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/page-manager/src/java/org/apache/jetspeed/page/AbstractPageManager.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -1142,6 +1142,7 @@
{
menu = newFolderMenuDefinition();
}
+ // TODO Findbugs
menu.setDepth(source.getDepth());
menu.setName(source.getName());
menu.setOptions(source.getOptions());
@@ -1189,6 +1190,7 @@
{
menuExclude = newFolderMenuExcludeDefinition();
}
+ // TODO Findbugs
menuExclude.setName(source.getName());
return menuExclude;
}
@@ -1205,6 +1207,7 @@
{
menuInclude = newFolderMenuIncludeDefinition();
}
+ // TODO Findbugs
menuInclude.setName(source.getName());
menuInclude.setNest(source.isNest());
return menuInclude;
@@ -1222,6 +1225,7 @@
{
menuOptions = newFolderMenuOptionsDefinition();
}
+ // TODO Findbugs
menuOptions.setDepth(source.getDepth());
menuOptions.setOptions(source.getOptions());
menuOptions.setOrder(source.getOrder());
@@ -1244,6 +1248,7 @@
{
menuSeparator = newFolderMenuSeparatorDefinition();
}
+ // TODO Findbugs
menuSeparator.setSkin(source.getSkin());
menuSeparator.setTitle(source.getTitle());
menuSeparator.setText(source.getText());
@@ -1299,6 +1304,7 @@
{
dstConstraint = newFragmentSecurityConstraint();
}
+ // TODO Findbugs
copyConstraint(srcConstraint, dstConstraint);
copiedConstraints.add(dstConstraint);
}
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/page-manager/src/java/org/apache/jetspeed/page/PageManagerUtils.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/page-manager/src/java/org/apache/jetspeed/page/PageManagerUtils.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/page-manager/src/java/org/apache/jetspeed/page/PageManagerUtils.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -43,6 +43,7 @@
public class PageManagerUtils
{
+ // TODO Findbugs
protected static Log log = LogFactory.getLog(PageManagerUtils.class);
/**
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/page-manager/src/java/org/apache/jetspeed/page/document/psml/CastorFileSystemDocumentHandler.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/page-manager/src/java/org/apache/jetspeed/page/document/psml/CastorFileSystemDocumentHandler.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/page-manager/src/java/org/apache/jetspeed/page/document/psml/CastorFileSystemDocumentHandler.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -169,8 +169,8 @@
* @param name
* @return
* @throws DocumentNotFoundException
- * @throws DocumentException,
- * DocumentNotFoundException
+ * @throws DocumentException
+ * , DocumentNotFoundException
*/
public Document getDocument(String name) throws NodeException,
DocumentNotFoundException
@@ -388,6 +388,7 @@
Mapping mapping = null;
try
{
+ // TODO Findbugs
InputStream stream = getClass().getResourceAsStream(mappingFile);
if (log.isDebugEnabled())
@@ -626,7 +627,7 @@
}
});
}
-
+ // TODO Findbugs
document.setPath(path);
AbstractBaseElement documentImpl = (AbstractBaseElement) document;
documentImpl.setHandlerFactory(handlerFactory);
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/page-manager/src/java/org/apache/jetspeed/page/document/psml/FileSystemFolderHandler.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/page-manager/src/java/org/apache/jetspeed/page/document/psml/FileSystemFolderHandler.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/page-manager/src/java/org/apache/jetspeed/page/document/psml/FileSystemFolderHandler.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -57,7 +57,8 @@
* </p>
*
* @author <a href="mailto:weave****@apach*****">Scott T. Weaver </a>
- * @version $Id: FileSystemFolderHandler.java 553584 2007-07-05 18:09:45Z taylor $
+ * @version $Id: FileSystemFolderHandler.java 553584 2007-07-05 18:09:45Z taylor
+ * $
*
*/
public class FileSystemFolderHandler implements FolderHandler,
@@ -155,8 +156,8 @@
* @param path
* @param fromCache
* @return
- * @throws DocumentException,
- * FolderNotFoundException
+ * @throws DocumentException
+ * , FolderNotFoundException
* @throws InvalidFolderException
* @throws DocumentNotFoundException
*/
@@ -492,6 +493,7 @@
private String documentType;
+ // TODO Findbugs
public DocumentTypeFilter(String documentType)
{
this.documentType = documentType;
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/page-manager/src/java/org/apache/jetspeed/page/impl/DatabasePageManager.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/page-manager/src/java/org/apache/jetspeed/page/impl/DatabasePageManager.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/page-manager/src/java/org/apache/jetspeed/page/impl/DatabasePageManager.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -327,7 +327,8 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.page.PageManager#newFolderMenuExcludeDefinition()
+ * @see
+ * org.apache.jetspeed.page.PageManager#newFolderMenuExcludeDefinition()
*/
public MenuExcludeDefinition newFolderMenuExcludeDefinition()
{
@@ -337,7 +338,8 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.page.PageManager#newFolderMenuIncludeDefinition()
+ * @see
+ * org.apache.jetspeed.page.PageManager#newFolderMenuIncludeDefinition()
*/
public MenuIncludeDefinition newFolderMenuIncludeDefinition()
{
@@ -347,7 +349,8 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.page.PageManager#newFolderMenuOptionsDefinition()
+ * @see
+ * org.apache.jetspeed.page.PageManager#newFolderMenuOptionsDefinition()
*/
public MenuOptionsDefinition newFolderMenuOptionsDefinition()
{
@@ -357,7 +360,8 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.page.PageManager#newFolderMenuSeparatorDefinition()
+ * @see
+ * org.apache.jetspeed.page.PageManager#newFolderMenuSeparatorDefinition()
*/
public MenuSeparatorDefinition newFolderMenuSeparatorDefinition()
{
@@ -407,7 +411,8 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.page.PageManager#newPageMenuSeparatorDefinition()
+ * @see
+ * org.apache.jetspeed.page.PageManager#newPageMenuSeparatorDefinition()
*/
public MenuSeparatorDefinition newPageMenuSeparatorDefinition()
{
@@ -467,7 +472,8 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.page.PageManager#newPageSecuritySecurityConstraint()
+ * @see
+ * org.apache.jetspeed.page.PageManager#newPageSecuritySecurityConstraint()
*/
public SecurityConstraint newPageSecuritySecurityConstraint()
{
@@ -497,7 +503,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.page.PageManager#addListener(org.apache.jetspeed.page.PageManagerEventListener)
+ * @see
+ * org.apache.jetspeed.page.PageManager#addListener(org.apache.jetspeed.
+ * page.PageManagerEventListener)
*/
public void addListener(PageManagerEventListener listener)
{
@@ -507,7 +515,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.page.PageManager#removeListener(org.apache.jetspeed.page.PageManagerEventListener)
+ * @see
+ * org.apache.jetspeed.page.PageManager#removeListener(org.apache.jetspeed
+ * .page.PageManagerEventListener)
*/
public void removeListener(PageManagerEventListener listener)
{
@@ -585,7 +595,8 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.page.PageManager#getContentPage(java.lang.String)
+ * @see
+ * org.apache.jetspeed.page.PageManager#getContentPage(java.lang.String)
*/
public ContentPage getContentPage(String path)
throws PageNotFoundException, NodeException
@@ -783,7 +794,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.page.PageManager#getFolders(org.apache.jetspeed.om.folder.Folder)
+ * @see
+ * org.apache.jetspeed.page.PageManager#getFolders(org.apache.jetspeed.om
+ * .folder.Folder)
*/
public NodeSet getFolders(Folder folder) throws DocumentException
{
@@ -808,6 +821,7 @@
}
folderImpl.resetFolders(true);
}
+ // TODO Findbugs
catch (Exception e)
{
// reset cache in folder
@@ -824,7 +838,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.page.PageManager#getFolder(org.apache.jetspeed.om.folder.Folder,java.lang.String)
+ * @see
+ * org.apache.jetspeed.page.PageManager#getFolder(org.apache.jetspeed.om
+ * .folder.Folder,java.lang.String)
*/
public Folder getFolder(Folder folder, String name)
throws FolderNotFoundException, DocumentException
@@ -849,7 +865,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.page.PageManager#getPages(org.apache.jetspeed.om.folder.Folder)
+ * @see
+ * org.apache.jetspeed.page.PageManager#getPages(org.apache.jetspeed.om.
+ * folder.Folder)
*/
public NodeSet getPages(Folder folder) throws NodeException
{
@@ -874,6 +892,7 @@
}
folderImpl.resetPages(true);
}
+ // TODO Findbugs
catch (Exception e)
{
// reset cache in folder
@@ -890,7 +909,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.page.PageManager#getPage(org.apache.jetspeed.om.folder.Folder,java.lang.String)
+ * @see
+ * org.apache.jetspeed.page.PageManager#getPage(org.apache.jetspeed.om.folder
+ * .Folder,java.lang.String)
*/
public Page getPage(Folder folder, String name)
throws PageNotFoundException, NodeException
@@ -915,7 +936,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.page.PageManager#getLinks(org.apache.jetspeed.om.folder.Folder)
+ * @see
+ * org.apache.jetspeed.page.PageManager#getLinks(org.apache.jetspeed.om.
+ * folder.Folder)
*/
public NodeSet getLinks(Folder folder) throws NodeException
{
@@ -940,6 +963,7 @@
}
folderImpl.resetLinks(true);
}
+ // TODO Findbugs
catch (Exception e)
{
// reset cache in folder
@@ -956,7 +980,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.page.PageManager#getLink(org.apache.jetspeed.om.folder.Folder,java.lang.String)
+ * @see
+ * org.apache.jetspeed.page.PageManager#getLink(org.apache.jetspeed.om.folder
+ * .Folder,java.lang.String)
*/
public Link getLink(Folder folder, String name)
throws DocumentNotFoundException, NodeException
@@ -981,7 +1007,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.page.PageManager#getPageSecurity(org.apache.jetspeed.om.folder.Folder)
+ * @see
+ * org.apache.jetspeed.page.PageManager#getPageSecurity(org.apache.jetspeed
+ * .om.folder.Folder)
*/
public PageSecurity getPageSecurity(Folder folder)
throws DocumentNotFoundException, NodeException
@@ -1009,6 +1037,7 @@
// cache page security in folder
folderImpl.resetPageSecurity((PageSecurityImpl) document, true);
}
+ // TODO Findbugs
catch (Exception e)
{
// reset page security in folder
@@ -1032,7 +1061,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.page.PageManager#getAll(org.apache.jetspeed.om.folder.Folder)
+ * @see
+ * org.apache.jetspeed.page.PageManager#getAll(org.apache.jetspeed.om.folder
+ * .Folder)
*/
public NodeSet getAll(Folder folder) throws DocumentException
{
@@ -1080,6 +1111,7 @@
folderImpl.accessAll().addAll(all);
folderImpl.resetAll(true);
}
+ // TODO Findbugs
catch (Exception e)
{
// reset cache in folder
@@ -1097,7 +1129,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.page.PageManager#updatePage(org.apache.jetspeed.om.page.Page)
+ * @see
+ * org.apache.jetspeed.page.PageManager#updatePage(org.apache.jetspeed.om
+ * .page.Page)
*/
public void updatePage(Page page) throws NodeException,
PageNotUpdatedException
@@ -1197,7 +1231,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.page.PageManager#removePage(org.apache.jetspeed.om.page.Page)
+ * @see
+ * org.apache.jetspeed.page.PageManager#removePage(org.apache.jetspeed.om
+ * .page.Page)
*/
public void removePage(Page page) throws NodeException,
PageNotRemovedException
@@ -1252,7 +1288,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.page.PageManager#updateFolder(org.apache.jetspeed.om.folder.Folder)
+ * @see
+ * org.apache.jetspeed.page.PageManager#updateFolder(org.apache.jetspeed
+ * .om.folder.Folder)
*/
public void updateFolder(Folder folder) throws NodeException,
FolderNotUpdatedException
@@ -1264,7 +1302,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.page.PageManager#updateFolder(org.apache.jetspeed.om.folder.Folder,boolean)
+ * @see
+ * org.apache.jetspeed.page.PageManager#updateFolder(org.apache.jetspeed
+ * .om.folder.Folder,boolean)
*/
public void updateFolder(Folder folder, boolean deep) throws NodeException,
FolderNotUpdatedException
@@ -1397,8 +1437,7 @@
*
* @param folderImpl
* folder whose nodes are to be updated
- * @param throws
- * FolderNotUpdatedException
+ * @param throws FolderNotUpdatedException
*/
private void updateFolderNodes(FolderImpl folderImpl)
throws FolderNotUpdatedException
@@ -1476,7 +1515,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.page.PageManager#removeFolder(org.apache.jetspeed.om.folder.Folder)
+ * @see
+ * org.apache.jetspeed.page.PageManager#removeFolder(org.apache.jetspeed
+ * .om.folder.Folder)
*/
public void removeFolder(Folder folder) throws NodeException,
FolderNotRemovedException
@@ -1535,8 +1576,7 @@
*
* @param folderImpl
* folder whose nodes are to be removed
- * @param throws
- * FolderNotRemovedException
+ * @param throws FolderNotRemovedException
*/
private void removeFolderNodes(FolderImpl folderImpl)
throws FolderNotRemovedException
@@ -1614,7 +1654,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.page.PageManager#updateLink(org.apache.jetspeed.om.page.Link)
+ * @see
+ * org.apache.jetspeed.page.PageManager#updateLink(org.apache.jetspeed.om
+ * .page.Link)
*/
public void updateLink(Link link) throws NodeException,
LinkNotUpdatedException
@@ -1710,7 +1752,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.page.PageManager#removeLink(org.apache.jetspeed.om.page.Link)
+ * @see
+ * org.apache.jetspeed.page.PageManager#removeLink(org.apache.jetspeed.om
+ * .page.Link)
*/
public void removeLink(Link link) throws NodeException,
LinkNotRemovedException
@@ -1761,7 +1805,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.page.PageManager#updatePageSecurity(org.apache.jetspeed.om.page.PageSecurity)
+ * @see
+ * org.apache.jetspeed.page.PageManager#updatePageSecurity(org.apache.jetspeed
+ * .om.page.PageSecurity)
*/
public void updatePageSecurity(PageSecurity pageSecurity)
throws NodeException, FailedToUpdateDocumentException
@@ -1878,7 +1924,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.page.PageManager#removePageSecurity(org.apache.jetspeed.om.page.PageSecurity)
+ * @see
+ * org.apache.jetspeed.page.PageManager#removePageSecurity(org.apache.jetspeed
+ * .om.page.PageSecurity)
*/
public void removePageSecurity(PageSecurity pageSecurity)
throws NodeException, FailedToDeleteDocumentException
@@ -1933,7 +1981,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.page.PageManager#copyPage(org.apache.jetspeed.om.page.Page,java.lang.String)
+ * @see
+ * org.apache.jetspeed.page.PageManager#copyPage(org.apache.jetspeed.om.
+ * page.Page,java.lang.String)
*/
public Page copyPage(Page source, String path) throws NodeException,
PageNotUpdatedException
@@ -1944,7 +1994,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.page.PageManager#copyLink(org.apache.jetspeed.om.page.Link,java.lang.String)
+ * @see
+ * org.apache.jetspeed.page.PageManager#copyLink(org.apache.jetspeed.om.
+ * page.Link,java.lang.String)
*/
public Link copyLink(Link source, String path) throws NodeException,
LinkNotUpdatedException
@@ -1955,7 +2007,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.page.PageManager#copyFolder(org.apache.jetspeed.om.folder.Folder,java.lang.String)
+ * @see
+ * org.apache.jetspeed.page.PageManager#copyFolder(org.apache.jetspeed.om
+ * .folder.Folder,java.lang.String)
*/
public Folder copyFolder(Folder source, String path) throws NodeException,
PageNotUpdatedException
@@ -1966,7 +2020,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.page.PageManager#copyFragment(org.apache.jetspeed.om.page.Fragment,java.lang.String)
+ * @see
+ * org.apache.jetspeed.page.PageManager#copyFragment(org.apache.jetspeed
+ * .om.page.Fragment,java.lang.String)
*/
public Fragment copyFragment(Fragment source, String name)
throws NodeException, PageNotUpdatedException
@@ -1977,7 +2033,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.page.PageManager#copyPageSecurity(org.apache.jetspeed.om.page.PageSecurity)
+ * @see
+ * org.apache.jetspeed.page.PageManager#copyPageSecurity(org.apache.jetspeed
+ * .om.page.PageSecurity)
*/
public PageSecurity copyPageSecurity(PageSecurity source)
throws NodeException
@@ -1988,7 +2046,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.page.PageManager#getUserPage(java.lang.String,java.lang.String)
+ * @see
+ * org.apache.jetspeed.page.PageManager#getUserPage(java.lang.String,java
+ * .lang.String)
*/
public Page getUserPage(String userName, String pageName)
throws PageNotFoundException, NodeException
@@ -2066,7 +2126,8 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.page.PageManager#userFolderExists(java.lang.String)
+ * @see
+ * org.apache.jetspeed.page.PageManager#userFolderExists(java.lang.String)
*/
public boolean userFolderExists(String userName)
{
@@ -2084,7 +2145,8 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.page.PageManager#userPageExists(java.lang.String)
+ * @see
+ * org.apache.jetspeed.page.PageManager#userPageExists(java.lang.String)
*/
public boolean userPageExists(String userName, String pageName)
{
@@ -2093,6 +2155,7 @@
getPage(Folder.USER_FOLDER + userName + Folder.PATH_SEPARATOR
+ pageName);
}
+ // TODO Findbugs
catch (Exception e)
{
return false;
@@ -2103,7 +2166,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.page.PageManager#createUserHomePagesFromRoles(java.security.auth.Subject)
+ * @see
+ * org.apache.jetspeed.page.PageManager#createUserHomePagesFromRoles(java
+ * .security.auth.Subject)
*/
public void createUserHomePagesFromRoles(Subject subject)
throws NodeException
@@ -2114,7 +2179,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.page.PageManager#deepCopyFolder(org.apache.jetspeed.om.folder.Folder,java.lang.String,java.lang.String)
+ * @see
+ * org.apache.jetspeed.page.PageManager#deepCopyFolder(org.apache.jetspeed
+ * .om.folder.Folder,java.lang.String,java.lang.String)
*/
public void deepCopyFolder(Folder srcFolder, String destinationPath,
String owner) throws NodeException, PageNotUpdatedException
@@ -2126,7 +2193,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.page.PageManager#addPages(org.apache.jetspeed.om.page.Page[])
+ * @see
+ * org.apache.jetspeed.page.PageManager#addPages(org.apache.jetspeed.om.
+ * page.Page[])
*/
public int addPages(Page[] pages) throws NodeException
{
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/page-manager/src/java/org/apache/jetspeed/page/impl/DatabasePageManagerCache.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/page-manager/src/java/org/apache/jetspeed/page/impl/DatabasePageManagerCache.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/page-manager/src/java/org/apache/jetspeed/page/impl/DatabasePageManagerCache.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -400,8 +400,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.ojb.broker.cache.ObjectCache#cache(org.apache.ojb.broker.Identity,
- * java.lang.Object)
+ * @see
+ * org.apache.ojb.broker.cache.ObjectCache#cache(org.apache.ojb.broker.Identity
+ * , java.lang.Object)
*/
public void cache(Identity oid, Object obj)
{
@@ -421,7 +422,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.ojb.broker.cache.ObjectCache#lookup(org.apache.ojb.broker.Identity)
+ * @see
+ * org.apache.ojb.broker.cache.ObjectCache#lookup(org.apache.ojb.broker.
+ * Identity)
*/
public Object lookup(Identity oid)
{
@@ -431,7 +434,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.ojb.broker.cache.ObjectCache#remove(org.apache.ojb.broker.Identity)
+ * @see
+ * org.apache.ojb.broker.cache.ObjectCache#remove(org.apache.ojb.broker.
+ * Identity)
*/
public void remove(Identity oid)
{
@@ -460,6 +465,7 @@
System.out.println("--------------------------2");
}
+ // TODO Findbugs
protected static ThreadLocal transactionedOperations = new ThreadLocal();
public static List getTransactions()
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/page-manager/src/java/org/apache/jetspeed/util/collections/RemovalAwareCollection.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/page-manager/src/java/org/apache/jetspeed/util/collections/RemovalAwareCollection.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/page-manager/src/java/org/apache/jetspeed/util/collections/RemovalAwareCollection.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -1,5 +1,6 @@
package org.apache.jetspeed.util.collections;
+//TODO Findbugs
public class RemovalAwareCollection extends
org.apache.ojb.broker.util.collections.RemovalAwareCollection
{
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/page-manager/src/java/org/apache/jetspeed/util/collections/RemovalAwareList.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/page-manager/src/java/org/apache/jetspeed/util/collections/RemovalAwareList.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/page-manager/src/java/org/apache/jetspeed/util/collections/RemovalAwareList.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -1,5 +1,6 @@
package org.apache.jetspeed.util.collections;
+//TODO Findbugs
public class RemovalAwareList extends
org.apache.ojb.broker.util.collections.RemovalAwareList
{
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/page-manager/src/test/org/apache/jetspeed/page/DirectoryXMLTransform.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/page-manager/src/test/org/apache/jetspeed/page/DirectoryXMLTransform.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/page-manager/src/test/org/apache/jetspeed/page/DirectoryXMLTransform.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -73,6 +73,7 @@
{
if (!directory.exists())
{
+ // TODO Findbugs
directory.mkdirs();
}
@@ -162,7 +163,7 @@
if (child.isFile())
{
File toFile = new File(dstDir, child.getName());
-
+ // TODO Findbugs
toFile.createNewFile();
srcChannel = new FileInputStream(child).getChannel();
@@ -198,6 +199,7 @@
else
{
File newSubDir = new File(dstDir, child.getName());
+ // TODO Findbugs
newSubDir.mkdir();
copyFilesAndTransform(child, newSubDir, fileFilter);
}
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/page-manager/src/test/org/apache/jetspeed/page/TestCastorXmlPageManager.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/page-manager/src/test/org/apache/jetspeed/page/TestCastorXmlPageManager.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/page-manager/src/test/org/apache/jetspeed/page/TestCastorXmlPageManager.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -126,8 +126,8 @@
/**
* Creates the test suite.
*
- * @return a test suite (<code>TestSuite</code>) that includes all
- * methods starting with "test"
+ * @return a test suite (<code>TestSuite</code>) that includes all methods
+ * starting with "test"
*/
public static Test suite()
{
@@ -904,6 +904,7 @@
boolean exceptionFound = false;
try
{
+ // TODO Findbugs
page = pageManager.getPage(this.testPage002);
}
catch (DocumentNotFoundException dnfe)
@@ -932,6 +933,7 @@
boolean exceptionFound = false;
try
{
+ // TODO Findbugs
folder = pageManager.getFolder(this.testFolder2);
}
catch (FolderNotFoundException fnfe)
@@ -960,6 +962,7 @@
boolean exceptionFound = false;
try
{
+ // TODO Findbugs
link = pageManager.getLink(this.testLink002);
}
catch (DocumentNotFoundException dnfe)
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/page-manager/src/test/org/apache/jetspeed/page/TestDatabasePageManager.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/page-manager/src/test/org/apache/jetspeed/page/TestDatabasePageManager.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/page-manager/src/test/org/apache/jetspeed/page/TestDatabasePageManager.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -139,7 +139,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.page.PageManagerEventListener#newNode(org.apache.jetspeed.page.document.Node)
+ * @see
+ * org.apache.jetspeed.page.PageManagerEventListener#newNode(org.apache.
+ * jetspeed.page.document.Node)
*/
public void newNode(Node node)
{
@@ -149,7 +151,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.page.PageManagerEventListener#newNode(org.apache.jetspeed.page.document.Node)
+ * @see
+ * org.apache.jetspeed.page.PageManagerEventListener#newNode(org.apache.
+ * jetspeed.page.document.Node)
*/
public void updatedNode(Node node)
{
@@ -159,7 +163,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.page.PageManagerEventListener#newNode(org.apache.jetspeed.page.document.Node)
+ * @see
+ * org.apache.jetspeed.page.PageManagerEventListener#newNode(org.apache.
+ * jetspeed.page.document.Node)
*/
public void removedNode(Node node)
{
@@ -1163,6 +1169,7 @@
assertEquals(22, removedNodeCount);
// last test has been run
+ // TODO Findbugs
lastTestRun = true;
}
}
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/page-manager/src/test/org/apache/jetspeed/page/document/psml/TestCastorFileSystemDocumentHandler.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/page-manager/src/test/org/apache/jetspeed/page/document/psml/TestCastorFileSystemDocumentHandler.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/page-manager/src/test/org/apache/jetspeed/page/document/psml/TestCastorFileSystemDocumentHandler.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -106,8 +106,8 @@
/**
* Creates the test suite.
*
- * @return a test suite (<code>TestSuite</code>) that includes all
- * methods starting with "test"
+ * @return a test suite (<code>TestSuite</code>) that includes all methods
+ * starting with "test"
*/
public static Test suite()
{
@@ -139,6 +139,7 @@
{
try
{
+ // TODO Findbugs
Document doc = folderMetaDataDocumentHandler
.getDocument("/folder1/folder.metadata", false);
}
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/jp/sf/pal/portal/redirect/impl/SSLRedirectValveImpl.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/jp/sf/pal/portal/redirect/impl/SSLRedirectValveImpl.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/jp/sf/pal/portal/redirect/impl/SSLRedirectValveImpl.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -151,6 +151,7 @@
PrintWriter out = request.getResponse().getWriter();
out.print(REDIRECT_CONTENT_PREFIX);
+ // TODO Findbugs
out.print(url.toString());
out.print(REDIRECT_CONTENT_SUFFIX);
}
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/jp/sf/pal/portal/servlet/UserManagerServlet.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/jp/sf/pal/portal/servlet/UserManagerServlet.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/jp/sf/pal/portal/servlet/UserManagerServlet.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -65,12 +65,16 @@
public static final String EXCLUDED_USER_STATUS = "excluded-user";
+ // TODO Findbugs
private UserManager userManager;
+ // TODO Findbugs
private GroupManager groupManager;
+ // TODO Findbugs
private RoleManager roleManager;
+ // TODO Findbugs
private Profiler profiler;
private String[] excludedUsernames;
@@ -88,6 +92,7 @@
*/
public void destroy()
{
+ // TODO Findbugs
userManager = null;
}
@@ -442,6 +447,7 @@
if (username == null)
{
setResponseHeader(resp);
+ // TODO Findbugs
printResult(printWriter, INVALID_PARAMETER_STATUS,
"Invalid parameter(s): username=" + username, null);
return;
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/aggregator/impl/CommonjWorkerMonitorImpl.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/aggregator/impl/CommonjWorkerMonitorImpl.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/aggregator/impl/CommonjWorkerMonitorImpl.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -66,7 +66,9 @@
/** CommonJ Work Manamger provided by JavaEE container */
protected WorkManager workManager;
- /** If true, invoke interrupt() on the worker thread when the job is timeout. */
+ /**
+ * If true, invoke interrupt() on the worker thread when the job is timeout.
+ */
protected boolean interruptOnTimeout = true;
/** Enable rendering job works monitor thread for timeout checking */
@@ -211,6 +213,7 @@
{
WorkItem monitorWorkItem = this.workManager.schedule(
monitoringWork, this);
+ // TODO Findbugs
lock.wait();
}
}
@@ -570,6 +573,7 @@
if (!content.isComplete())
{
worker.interrupt();
+ // TODO Findbugs
content.wait();
}
}
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/aggregator/impl/PortletAggregatorFragmentImpl.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/aggregator/impl/PortletAggregatorFragmentImpl.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/aggregator/impl/PortletAggregatorFragmentImpl.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -54,7 +54,8 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.om.common.SecuredResource#getConstraintsEnabled()
+ * @see
+ * org.apache.jetspeed.om.common.SecuredResource#getConstraintsEnabled()
*/
public boolean getConstraintsEnabled()
{
@@ -64,7 +65,8 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.om.common.SecuredResource#getSecurityConstraints()
+ * @see
+ * org.apache.jetspeed.om.common.SecuredResource#getSecurityConstraints()
*/
public SecurityConstraints getSecurityConstraints()
{
@@ -74,7 +76,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.om.common.SecuredResource#setSecurityConstraints(org.apache.jetspeed.om.common.SecurityConstraints)
+ * @see
+ * org.apache.jetspeed.om.common.SecuredResource#setSecurityConstraints(
+ * org.apache.jetspeed.om.common.SecurityConstraints)
*/
public void setSecurityConstraints(SecurityConstraints constraints)
{
@@ -83,7 +87,8 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.om.common.SecuredResource#newSecurityConstraints()
+ * @see
+ * org.apache.jetspeed.om.common.SecuredResource#newSecurityConstraints()
*/
public SecurityConstraints newSecurityConstraints()
{
@@ -93,7 +98,8 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.om.common.SecuredResource#newSecurityConstraint()
+ * @see
+ * org.apache.jetspeed.om.common.SecuredResource#newSecurityConstraint()
*/
public SecurityConstraint newSecurityConstraint()
{
@@ -103,7 +109,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.om.common.SecuredResource#checkConstraints(java.lang.String)
+ * @see
+ * org.apache.jetspeed.om.common.SecuredResource#checkConstraints(java.lang
+ * .String)
*/
public void checkConstraints(String actions) throws SecurityException
{
@@ -112,7 +120,8 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.om.common.SecuredResource#getPermissionsEnabled()
+ * @see
+ * org.apache.jetspeed.om.common.SecuredResource#getPermissionsEnabled()
*/
public boolean getPermissionsEnabled()
{
@@ -131,7 +140,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.om.common.SecuredResource#checkAccess(java.lang.String)
+ * @see
+ * org.apache.jetspeed.om.common.SecuredResource#checkAccess(java.lang.String
+ * )
*/
public void checkAccess(String actions) throws SecurityException
{
@@ -179,7 +190,8 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.om.page.BaseElement#setShortTitle(java.lang.String)
+ * @see
+ * org.apache.jetspeed.om.page.BaseElement#setShortTitle(java.lang.String)
*/
public void setShortTitle(String title)
{
@@ -337,7 +349,8 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.om.page.Fragment#getIntProperty(java.lang.String)
+ * @see
+ * org.apache.jetspeed.om.page.Fragment#getIntProperty(java.lang.String)
*/
public int getIntProperty(String propName)
{
@@ -347,7 +360,8 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.om.page.Fragment#getFloatProperty(java.lang.String)
+ * @see
+ * org.apache.jetspeed.om.page.Fragment#getFloatProperty(java.lang.String)
*/
public float getFloatProperty(String propName)
{
@@ -455,7 +469,8 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.om.page.Fragment#setLayoutSizes(java.lang.String)
+ * @see
+ * org.apache.jetspeed.om.page.Fragment#setLayoutSizes(java.lang.String)
*/
public void setLayoutSizes(String sizes)
{
@@ -523,6 +538,7 @@
*/
public Object clone() throws CloneNotSupportedException
{
+ // TODO Findbugs
return null;
}
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/aggregator/impl/PortletRendererImpl.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/aggregator/impl/PortletRendererImpl.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/aggregator/impl/PortletRendererImpl.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -60,8 +60,7 @@
import org.apache.pluto.om.window.PortletWindow;
/**
- * <h4>PortletRendererService <br />
- * Jetspeed-2 Rendering service.</h4>
+ * <h4>PortletRendererService <br /> Jetspeed-2 Rendering service.</h4>
* <p>
* This service process all portlet rendering requests and interfaces with the
* portlet container to generate the resulting markup
@@ -390,6 +389,7 @@
catch (Exception e1)
{
log.error("render() failed: " + e1.toString(), e1);
+ // TODO Findbugs
fragment.overrideRenderedContent(e1.getLocalizedMessage());
}
}
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/aggregator/impl/WorkerMonitorImpl.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/aggregator/impl/WorkerMonitorImpl.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/aggregator/impl/WorkerMonitorImpl.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -427,6 +427,7 @@
if (!content.isComplete())
{
worker.interrupt();
+ // TODO Findbugs
content.wait();
}
}
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/ajax/AJAXRequestImpl.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/ajax/AJAXRequestImpl.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/ajax/AJAXRequestImpl.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -122,6 +122,7 @@
}
}
+ // TODO Findbugs
public class AJAXParameter
{
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/cluster/NodeManagerImpl.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/cluster/NodeManagerImpl.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/cluster/NodeManagerImpl.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -60,6 +60,7 @@
rootIndexDir = new File(indexRoot);
this.nodeInformationBean = nodeInformationBean;
+ // TODO Findbugs
if (!(rootIndexDir.exists())) rootIndexDir.mkdirs();
load();
}
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/container/DesktopPortletContainerImpl.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/container/DesktopPortletContainerImpl.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/container/DesktopPortletContainerImpl.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -191,6 +191,7 @@
}
else
{ // do real redirect
+ // TODO Findbugs
location = location.replaceAll(this.desktopActionPipelinePath,
this.desktopPipelinePath);
location = location.replaceAll(this.desktopRenderPipelinePath,
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/container/PageHistoryValve.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/container/PageHistoryValve.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/container/PageHistoryValve.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -41,6 +41,7 @@
// SessionFullExtendedNavigationalState object needs this.
public static final String REQUEST_CLEAR_PORTLETS_MODE_AND_WINDOWSTATE_KEY = "clearPortletsModeAndWindowState";
+ // TODO Findbugs
private final String SESSION_PREVIOUS_PAGEID_KEY = "PreviousPageId";
private boolean valveDisabled = false;
@@ -48,8 +49,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.pipeline.valve.AbstractValve#invoke(org.apache.jetspeed.request.RequestContext,
- * org.apache.jetspeed.pipeline.valve.ValveContext)
+ * @see
+ * org.apache.jetspeed.pipeline.valve.AbstractValve#invoke(org.apache.jetspeed
+ * .request.RequestContext, org.apache.jetspeed.pipeline.valve.ValveContext)
*/
public void invoke(RequestContext request, ValveContext context)
throws PipelineException
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/decoration/BaseDecoration.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/decoration/BaseDecoration.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/decoration/BaseDecoration.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -303,6 +303,7 @@
"The resource directory cannot be parsed as a URL: "
+ resourceDirName, resourceName + "_" + locale, "");
}
+ // TODO Findbugs
return ResourceBundle.getBundle(resourceName, locale,
new URLClassLoader(urls));
}
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/deployment/impl/DeployDecoratorEventListener.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/deployment/impl/DeployDecoratorEventListener.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/deployment/impl/DeployDecoratorEventListener.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -144,6 +144,7 @@
deployPath.length()) + File.separator + id);
log.info("Deploying locale specific decorator component to "
+ deployToPathFile.getPath());
+ // TODO Findbugs
deployToPathFile.mkdirs();
// deploy decorator components by moving from deployed decorator
@@ -159,6 +160,7 @@
});
for (int i = 0; (i < filesToDeploy.length); i++)
{
+ // TODO Findbugs
filesToDeploy[i].renameTo(new File(deployToPathFile,
filesToDeploy[i].getName()));
}
@@ -239,6 +241,7 @@
localeDeployPathFile);
cleanup.remove();
cleanup.close();
+ // TODO Findbugs
localeDeployPathFile.getParentFile().delete();
}
}
@@ -262,7 +265,8 @@
* getDecorationConfiguration
* </p>
*
- * @param event @
+ * @param event
+ * @
* @return configuration
* @throws DeploymentException
*/
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/deployment/impl/DeployPortletAppEventListener.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/deployment/impl/DeployPortletAppEventListener.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/deployment/impl/DeployPortletAppEventListener.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -120,6 +120,7 @@
if (!localAppDirFile.exists())
{
+ // TODO Findbugs
localAppDirFile.mkdirs();
}
else if (!localAppDirFile.isDirectory()) { throw new FileNotFoundException(
@@ -308,6 +309,7 @@
urls.add(jar.toURL());
}
}
+ // TODO Findbugs
return new URLClassLoader((URL[]) urls.toArray(new URL[urls.size()]),
getClass().getClassLoader());
}
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/deployment/impl/JarExpander.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/deployment/impl/JarExpander.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/deployment/impl/JarExpander.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -44,7 +44,7 @@
cleanup.remove();
cleanup.close();
}
-
+ // TODO Findbugs
targetDir.mkdirs();
JarFile jarFile = new JarFile(srcFile);
@@ -66,6 +66,7 @@
if (jarEntry.isDirectory())
{
+ // TODO Findbugs
entryFile.mkdir();
}
else
@@ -75,6 +76,7 @@
entryFile.getParentFile().mkdirs();
}
+ // TODO Findbugs
entryFile.createNewFile();
try
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/deployment/impl/JettyDeployPortletAppEventListener.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/deployment/impl/JettyDeployPortletAppEventListener.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/deployment/impl/JettyDeployPortletAppEventListener.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -111,6 +111,7 @@
{
context = getCurrentJettyContext(contextFile);
}
+ // TODO Findbugs
contextFile.delete();
}
if (context == null)
@@ -134,6 +135,7 @@
File warFile = new File(getWebAppDir(), contextName + ".war");
if (warFile.exists())
{
+ // TODO Findbugs
warFile.delete();
}
File warDir = new File(getWebAppDir(), contextName);
@@ -204,6 +206,7 @@
InputStream source = null;
try
{
+ // TODO Findbugs
source = getClass().getResourceAsStream(
"jetty/context-template.xml");
return parseJettyContext(source);
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/engine/JetspeedEngine.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/engine/JetspeedEngine.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/engine/JetspeedEngine.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -158,7 +158,8 @@
// registry
// but not when dispatching, still trying to figure that out
// PortletApplicationManagement pam =
- // (PortletApplicationManagement)componentManager.getComponent("PAM");
+ //(PortletApplicationManagement)componentManager.getComponent("PAM")
+ // ;
// pam.startInternalApplication(config.getServletName());
}
@@ -218,6 +219,7 @@
{
throw new JetspeedException(e);
}
+ // TODO Findbugs
System.gc();
}
@@ -261,6 +263,7 @@
pipeline = getPipeline();
context.setPipeline(pipeline);
+ // TODO Findbugs
pipeline.invoke(context);
long end = System.currentTimeMillis();
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/engine/JetspeedServlet.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/engine/JetspeedServlet.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/engine/JetspeedServlet.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -106,11 +106,13 @@
*/
public final void init(ServletConfig config) throws ServletException
{
+ // TODO Findbugs
synchronized (this.getClass())
{
if (log == null)
{
log = LogFactory.getLog(JetspeedServlet.class);
+ // TODO Findbugs
console = LogFactory.getLog(CONSOLE_LOGGER);
}
@@ -159,6 +161,7 @@
{
console.log("0900013");
}
+ // TODO Findbugs
webappRoot = config.getServletContext().getRealPath("/");
// console
// .info("JetspeedServlet identifed web application root as "
@@ -188,6 +191,7 @@
{
console.log("0900015"); // REPLACED
}
+ // TODO Findbugs
engine = new JetspeedEngine(properties, applicationRoot,
config, initializeComponentManager(config,
applicationRoot, properties));
@@ -208,6 +212,7 @@
{
console.log("0900017"); // REPLACED
}
+ // TODO Findbugs
contextComponent = (RequestContextComponent) Jetspeed
.getComponentManager().getComponent(
RequestContextComponent.class);
@@ -216,6 +221,7 @@
{
// save the exception to complain loudly later :-)
final String msg = "Jetspeed: init() failed: ";
+ // TODO Findbugs
initFailure = e;
// log.fatal(msg, e);
log.log("0900006", e); // REPLACED
@@ -298,7 +304,9 @@
{
// ensure that no proxy or brower caching is performed
// on dynamic responses resulting from pipeline execution
- res.setHeader("Cache-Control", "no-cache,no-store,private"); // HTTP/1.1
+ res.setHeader("Cache-Control", "no-cache,no-store,private"); // HTTP
+ // /
+ // 1.1
// modern
// browser/proxy
res.setHeader("Pragma", "no-cache"); // HTTP/1.0 non-standard
@@ -366,6 +374,7 @@
}
// Allow turbine to be started back up again.
+ // TODO Findbugs
firstInit = true;
// log.info("Done shutting down!");
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/engine/servlet/HttpSessionWrapper.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/engine/servlet/HttpSessionWrapper.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/engine/servlet/HttpSessionWrapper.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -42,6 +42,7 @@
*/
public boolean equals(Object obj)
{
+ // TODO Findbugs
return session.equals(obj);
}
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/engine/servlet/ServletRequestImpl.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/engine/servlet/ServletRequestImpl.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/engine/servlet/ServletRequestImpl.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -555,6 +555,7 @@
{
entityID = entity.getId().toString();
}
+ // TODO Findbugs
PortletApplicationDefinition portletAppDef = entity
.getPortletDefinition()
.getPortletApplicationDefinition();
@@ -595,7 +596,7 @@
public Locale getLocale()
{
// Locale preferedLocale = (Locale)
- // getSession().getAttribute(RequestContext.PREFERED_LOCALE_SESSION_KEY);
+ //getSession().getAttribute(RequestContext.PREFERED_LOCALE_SESSION_KEY);
RequestContext requestContext = (RequestContext) _getHttpServletRequest()
.getAttribute(
PortalReservedParameters.REQUEST_CONTEXT_ATTRIBUTE);
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/healthcheck/validators/DatasourceAvailableHealthCheckValidator.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/healthcheck/validators/DatasourceAvailableHealthCheckValidator.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/healthcheck/validators/DatasourceAvailableHealthCheckValidator.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -35,34 +35,47 @@
* @author <a href="mailto:ruben****@fmr*****">Ruben Carvalho</a>
* @version $Id$
*/
-public class DatasourceAvailableHealthCheckValidator implements HealthCheckValidator
+public class DatasourceAvailableHealthCheckValidator implements
+ HealthCheckValidator
{
- private static final Log log = LogFactory.getLog(DatasourceAvailableHealthCheckValidator.class);
+
+ private static final Log log = LogFactory
+ .getLog(DatasourceAvailableHealthCheckValidator.class);
+
public static boolean isInfoEnabled = log.isInfoEnabled();
+
+ // TODO Findbugs
public static boolean isDebugEnabled = log.isDebugEnabled();
+
/**
- * Spring property resources. Maps the database name to a list of datasources.
+ * Spring property resources. Maps the database name to a list of
+ * datasources.
*/
private Map resources;
+
/**
* Spring property numberOfRetries.
*/
private int numberOfRetries;
+
/**
* Spring property retryDelay.
*/
private long retryDelay;
+
/**
* Spring property stopValidationOnError.
*/
private boolean stopValidationOnError;
+
/**
* Spring property requireAllValid.
*/
private boolean requireAllValid;
- public DatasourceAvailableHealthCheckValidator(Map resources, int numberOfRetries, long retryDelay,
- boolean stopValidationOnError, boolean requireAllValid)
+ public DatasourceAvailableHealthCheckValidator(Map resources,
+ int numberOfRetries, long retryDelay,
+ boolean stopValidationOnError, boolean requireAllValid)
{
this.resources = resources;
this.numberOfRetries = numberOfRetries;
@@ -75,7 +88,8 @@
{
if (isDebugEnabled)
{
- log.debug("Starting method: DatasourceAvailableHealthCheckValidator.validate()");
+ log
+ .debug("Starting method: DatasourceAvailableHealthCheckValidator.validate()");
}
HealthCheckValidatorResult result = new HealthCheckValidatorResult();
boolean allDataSourcesStatus = true;
@@ -86,7 +100,7 @@
for (Iterator it = dbNames.iterator(); it.hasNext();)
{
String dbName = (String) it.next();
- if (messages.length()>0)
+ if (messages.length() > 0)
{
messages.append(LINE_SEPARATOR);
}
@@ -95,10 +109,12 @@
{
log.debug("Database: " + dbName);
}
- DataSourcesValidationBean dsBean = (DataSourcesValidationBean) resources.get(dbName);
+ DataSourcesValidationBean dsBean = (DataSourcesValidationBean) resources
+ .get(dbName);
String validationQuery = dsBean.getValidationQuery();
boolean dbStatus = true;
- for (Iterator it2 = dsBean.getDatasources().iterator(); it2.hasNext();)
+ for (Iterator it2 = dsBean.getDatasources().iterator(); it2
+ .hasNext();)
{
DataSource ds = (DataSource) it2.next();
dbStatus = isDatasourceValid(validationQuery, ds);
@@ -117,9 +133,9 @@
// the ds is not available
if (requireAllValid)
{
- // all datasource(s) need to be available so
- // we can interrupt this loop
- break;
+ // all datasource(s) need to be available so
+ // we can interrupt this loop
+ break;
}
}
}
@@ -143,7 +159,8 @@
}
if (!allDataSourcesStatus)
{
- result.setHealthCheckResult(HealthCheckValidatorResult.VALIDATOR_FAILED);
+ result
+ .setHealthCheckResult(HealthCheckValidatorResult.VALIDATOR_FAILED);
}
}
catch (Exception e)
@@ -151,8 +168,11 @@
// if any exceptions occur, even runtime exceptions, return a failed
// result
log.error("Exception while running the datasource validator", e);
- result.setHealthCheckResult(HealthCheckValidatorResult.VALIDATOR_FAILED);
- messages.append("Exception while running the datasource validator: " + e.getMessage());
+ result
+ .setHealthCheckResult(HealthCheckValidatorResult.VALIDATOR_FAILED);
+ messages
+ .append("Exception while running the datasource validator: "
+ + e.getMessage());
}
if (isDebugEnabled)
{
@@ -163,7 +183,8 @@
}
/**
- * Checks is a datasource is valid or not by executing a <code>validationQuery</code>
+ * Checks is a datasource is valid or not by executing a
+ * <code>validationQuery</code>
*
* @param validationQuery
* The query to be executed
@@ -171,7 +192,8 @@
* The datasource to be checked
* @return Whether the datasource is available or not
*/
- private boolean isDatasourceValid(String validationQuery, DataSource dataSource)
+ private boolean isDatasourceValid(String validationQuery,
+ DataSource dataSource)
{
boolean dsStatus = true;
Connection con = null;
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/healthcheck/validators/PortletApplicationAvailableHeathCheckValidator.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/healthcheck/validators/PortletApplicationAvailableHeathCheckValidator.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/healthcheck/validators/PortletApplicationAvailableHeathCheckValidator.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -26,44 +26,58 @@
import org.apache.jetspeed.om.common.portlet.PortletApplication;
/**
- * Validator to check if the defined required applications have been initialised in the Jetspeed engine
+ * Validator to check if the defined required applications have been initialised
+ * in the Jetspeed engine
*
* @author <a href="mailto:ruben****@fmr*****">Ruben Carvalho</a>
* @version $Id$
*/
-public class PortletApplicationAvailableHeathCheckValidator implements HealthCheckValidator
+public class PortletApplicationAvailableHeathCheckValidator implements
+ HealthCheckValidator
{
- private static final Log log = LogFactory.getLog(PortletApplicationAvailableHeathCheckValidator.class);
+
+ private static final Log log = LogFactory
+ .getLog(PortletApplicationAvailableHeathCheckValidator.class);
+
public static boolean isInfoEnabled = log.isInfoEnabled();
+
+ // TODO Findbugs
public static boolean isDebugEnabled = log.isDebugEnabled();
+
/**
* Spring property numberOfRetries.
*/
private int numberOfRetries;
+
/**
* Spring property retryDelay.
*/
private long retryDelay;
+
/**
* Spring property retryDelay.
*/
private List requiredPortletApplications;
+
/**
* Spring property portletRegistry.
*/
private PortletRegistry portletRegistry;
+
/**
* Spring property portletFactory.
*/
private PortletFactory portletFactory;
+
/**
* Spring property stopValidationOnError.
*/
private boolean stopValidationOnError;
- public PortletApplicationAvailableHeathCheckValidator(List requiredPortletApplications, int numberOfRetries,
- long retryDelay, PortletRegistry portletRegistry,
- PortletFactory portletFactory, boolean stopValidationOnError)
+ public PortletApplicationAvailableHeathCheckValidator(
+ List requiredPortletApplications, int numberOfRetries,
+ long retryDelay, PortletRegistry portletRegistry,
+ PortletFactory portletFactory, boolean stopValidationOnError)
{
this.requiredPortletApplications = requiredPortletApplications;
this.numberOfRetries = numberOfRetries;
@@ -82,7 +96,8 @@
{
// check if all required apps have been registered and are
// available.
- for (Iterator it = requiredPortletApplications.iterator(); it.hasNext();)
+ for (Iterator it = requiredPortletApplications.iterator(); it
+ .hasNext();)
{
// the portlet application name
String paName = (String) it.next();
@@ -90,13 +105,15 @@
{
log.debug("Checking portlet application: " + paName);
}
- if (messages.length()>0)
+ if (messages.length() > 0)
{
messages.append(LINE_SEPARATOR);
}
messages.append(paName + ": ");
- PortletApplication pa = portletRegistry.getPortletApplication(paName);
- boolean thisPAStatus = portletFactory.isPortletApplicationRegistered(pa);
+ PortletApplication pa = portletRegistry
+ .getPortletApplication(paName);
+ boolean thisPAStatus = portletFactory
+ .isPortletApplicationRegistered(pa);
if (thisPAStatus)
{
messages.append("is up");
@@ -113,16 +130,23 @@
}
if (!allPAStatus)
{
- result.setHealthCheckResult(HealthCheckValidatorResult.VALIDATOR_FAILED);
+ result
+ .setHealthCheckResult(HealthCheckValidatorResult.VALIDATOR_FAILED);
}
}
catch (Exception e)
{
// if any exceptions occur, even runtime exceptions, return a failed
// result
- log.error("Exception while running the portlet application validator", e);
- result.setHealthCheckResult(HealthCheckValidatorResult.VALIDATOR_FAILED);
- messages.append("Exception while running the portlet application validator: " + e.getMessage());
+ log
+ .error(
+ "Exception while running the portlet application validator",
+ e);
+ result
+ .setHealthCheckResult(HealthCheckValidatorResult.VALIDATOR_FAILED);
+ messages
+ .append("Exception while running the portlet application validator: "
+ + e.getMessage());
}
if (isDebugEnabled)
{
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/layout/impl/ChangePortletAction.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/layout/impl/ChangePortletAction.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/layout/impl/ChangePortletAction.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -156,6 +156,7 @@
.getPortletWindow(fragment);
PortletMode currentMode = requestContext.getPortalURL()
.getNavigationalState().getMode(window);
+ // TODO Findbugs
WindowState currentState = requestContext.getPortalURL()
.getNavigationalState().getState(window);
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/layout/impl/ExportJetspeedSchema.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/layout/impl/ExportJetspeedSchema.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/layout/impl/ExportJetspeedSchema.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -177,6 +177,7 @@
{
String folder = getUserFolder(userName, false);
File dir = new File(pageRoot + pathSeprator + userName + ".zip");
+ // TODO Findbugs
if (dir.exists()) dir.delete();
dir = new File(folder);
@@ -202,6 +203,7 @@
}
else
{
+ // TODO Findbugs
files[i].delete();
}
}
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/layout/impl/ExportObject.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/layout/impl/ExportObject.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/layout/impl/ExportObject.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -187,6 +187,7 @@
{
String folder = getUserFolder(userName, false);
File dir = new File(pageRoot + pathSeprator + userName + ".zip");
+ // TODO Findbugs
if (dir.exists()) dir.delete();
dir = new File(folder);
@@ -212,6 +213,7 @@
}
else
{
+ // TODO Findbugs
files[i].delete();
}
}
@@ -293,6 +295,7 @@
.length() + 1, strAbsPath.length());
byte[] b = new byte[(int) (cpFile.length())];
FileInputStream cpFileInputStream = new FileInputStream(cpFile);
+ // TODO Findbugs
int i = cpFileInputStream.read(b, 0, (int) cpFile.length());
ZipEntry cpZipEntry = new ZipEntry(strZipEntryName);
cpZipOutputStream.putNextEntry(cpZipEntry);
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/layout/impl/GetUserInformationAction.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/layout/impl/GetUserInformationAction.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/layout/impl/GetUserInformationAction.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -51,6 +51,7 @@
AjaxAction, AjaxBuilder, Constants
{
+ // TODO Findbugs
protected Log log = LogFactory.getLog(GetUserInformationAction.class);
public GetUserInformationAction(String template, String errorTemplate,
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/layout/impl/PortletActionSecurityConstraintsBehavior.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/layout/impl/PortletActionSecurityConstraintsBehavior.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/layout/impl/PortletActionSecurityConstraintsBehavior.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -38,6 +38,7 @@
PortletActionSecurityBehavior
{
+ // TODO Findbugs
protected Log log = LogFactory
.getLog(PortletActionSecurityConstraintsBehavior.class);
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/layout/impl/PortletActionSecurityPathMergeBehavior.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/layout/impl/PortletActionSecurityPathMergeBehavior.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/layout/impl/PortletActionSecurityPathMergeBehavior.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -44,6 +44,7 @@
PortletActionSecurityBehavior
{
+ // TODO Findbugs
protected Log log = LogFactory
.getLog(PortletActionSecurityPathMergeBehavior.class);
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/login/LogoutServlet.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/login/LogoutServlet.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/login/LogoutServlet.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -41,6 +41,7 @@
{
destination = request.getContextPath() + "/";
}
+ // TODO Findbugs
response.sendRedirect(response.encodeURL(destination));
}
}
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/manager/ManagerServlet.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/manager/ManagerServlet.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/manager/ManagerServlet.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -402,7 +402,9 @@
DiskFileUpload upload = new DiskFileUpload();
tempDir = File.createTempFile("upload", null);
tempDir.deleteOnExit();
+ // TODO Findbugs
tempDir.delete();
+ // TODO Findbugs
tempDir.mkdirs();
tempDir.deleteOnExit();
List items = upload.parseRequest(request, 0, -1L, tempDir
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/pipeline/valve/HealthCheckValve.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/pipeline/valve/HealthCheckValve.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/pipeline/valve/HealthCheckValve.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -28,46 +28,61 @@
import org.apache.jetspeed.healthcheck.validators.HealthCheckValidator;
import org.apache.jetspeed.healthcheck.validators.HealthCheckValidatorResult;
import org.apache.jetspeed.pipeline.PipelineException;
-import org.apache.jetspeed.pipeline.valve.AbstractValve;
-import org.apache.jetspeed.pipeline.valve.ValveContext;
import org.apache.jetspeed.request.RequestContext;
/**
- * Valve that performs a health check based on the validators injected from a Spring configutation file.
+ * Valve that performs a health check based on the validators injected from a
+ * Spring configutation file.
*
* @author <a href="mailto:ruben****@fmr*****">Ruben Carvalho</a>
* @version $Id$
*/
public class HealthCheckValve extends AbstractValve
{
+
static final String LINE_SEPARATOR = System.getProperty("line.separator");
+
private static final Log log = LogFactory.getLog(HealthCheckValve.class);
+
public static boolean isInfoEnabled = log.isInfoEnabled();
+
+ // TODO Findbugs
public static boolean isDebugEnabled = log.isDebugEnabled();
+
/**
- * Spring property validators. List of validators to be executed by this Valve
+ * Spring property validators. List of validators to be executed by this
+ * Valve
*/
private List validators;
+
/**
- * Spring property successMessage. This String is added to the response if all validators succeed
+ * Spring property successMessage. This String is added to the response if
+ * all validators succeed
*/
private String successMessage;
+
/**
- * Spring property failMessage. The string to be added to the response if one of the validators fails
+ * Spring property failMessage. The string to be added to the response if
+ * one of the validators fails
*/
private String failMessage;
+
/**
- * Spring property addValidationMessagesToResponse. Whether messages returned in the validator result should be
- * appended to the http response or not
+ * Spring property addValidationMessagesToResponse. Whether messages
+ * returned in the validator result should be appended to the http response
+ * or not
*/
private boolean addValidationMessagesToResponse;
+
/**
- * Spring property stopValidationOnError. Whether the valve execution should continue or stop if one validator fails
+ * Spring property stopValidationOnError. Whether the valve execution should
+ * continue or stop if one validator fails
*/
private boolean stopValidationOnError;
- public HealthCheckValve(List validators, String successMessage, String failMessage,
- boolean addValidationMessagesToResponse, boolean stopValidationOnError)
+ public HealthCheckValve(List validators, String successMessage,
+ String failMessage, boolean addValidationMessagesToResponse,
+ boolean stopValidationOnError)
{
this.validators = validators;
this.successMessage = successMessage;
@@ -76,7 +91,8 @@
this.stopValidationOnError = stopValidationOnError;
}
- public void invoke(RequestContext request, ValveContext context) throws PipelineException
+ public void invoke(RequestContext request, ValveContext context)
+ throws PipelineException
{
if (isDebugEnabled)
{
@@ -93,7 +109,8 @@
HealthCheckValidator hcv = (HealthCheckValidator) it.next();
if (isDebugEnabled)
{
- log.debug("Starting validator execution: " + hcv.getClass().getName());
+ log.debug("Starting validator execution: "
+ + hcv.getClass().getName());
}
HealthCheckValidatorResult result = null;
// execute the validator until it succeeds or until the
@@ -103,8 +120,9 @@
result = hcv.validate();
if (isDebugEnabled)
{
- log.debug("Validator execution: " +
- (result.getHealthCheckResult() == HealthCheckValidatorResult.VALIDATOR_SUCCEEDED));
+ log
+ .debug("Validator execution: "
+ + (result.getHealthCheckResult() == HealthCheckValidatorResult.VALIDATOR_SUCCEEDED));
}
if (result.getHealthCheckResult() == HealthCheckValidatorResult.VALIDATOR_SUCCEEDED)
{
@@ -164,7 +182,7 @@
{
for (Iterator it = messages.iterator(); it.hasNext();)
{
- pw.write(LINE_SEPARATOR + (String)it.next());
+ pw.write(LINE_SEPARATOR + (String) it.next());
}
}
}
@@ -185,7 +203,7 @@
{
for (Iterator it = messages.iterator(); it.hasNext();)
{
- pw.write(LINE_SEPARATOR + (String)it.next());
+ pw.write(LINE_SEPARATOR + (String) it.next());
}
}
}
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/profiler/impl/ProfilerValveImpl.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/profiler/impl/ProfilerValveImpl.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/profiler/impl/ProfilerValveImpl.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -155,8 +155,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.pipeline.valve.Valve#invoke(org.apache.jetspeed.request.RequestContext,
- * org.apache.jetspeed.pipeline.valve.ValveContext)
+ * @see
+ * org.apache.jetspeed.pipeline.valve.Valve#invoke(org.apache.jetspeed.request
+ * .RequestContext, org.apache.jetspeed.pipeline.valve.ValveContext)
*/
public void invoke(RequestContext request, ValveContext context)
throws PipelineException
@@ -199,6 +200,7 @@
{
locators = profiler.getDefaultProfileLocators(request);
}
+ // TODO Findbugs
if (locators.size() == 0)
{
locators.put(ProfileLocator.PAGE_LOCATOR, profiler.getProfile(
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/request/JetspeedRequestContext.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/request/JetspeedRequestContext.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/request/JetspeedRequestContext.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -138,6 +138,7 @@
this.request = request;
this.response = response;
this.config = config;
+ // TODO Findbugs
this.session = request.getSession();
this.userInfoMgr = userInfoMgr;
this.requestsForWindows = new HashMap();
@@ -448,7 +449,8 @@
// anymore, and as a WeakHashMap isn't
// Serializable, "fixing" that problem (JS2-174) by simply not
// putting it in the session anymore
- // request.getSession().setAttribute(PortalReservedParameters.PREFERED_LANGUAGE_ATTRIBUTE,
+ // request.getSession().setAttribute(PortalReservedParameters.
+ // PREFERED_LANGUAGE_ATTRIBUTE,
// new WeakHashMap());
session.setAttribute(
PortalReservedParameters.PREFERED_LOCALE_ATTRIBUTE, locale);
@@ -643,7 +645,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.request.RequestContext#setActionFailed(java.lang.Throwable)
+ * @see
+ * org.apache.jetspeed.request.RequestContext#setActionFailed(java.lang.
+ * Throwable)
*/
public void setActionFailure(PortletWindow window, Throwable actionFailure)
{
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/security/impl/Jetspeed1CredentialPasswordEncoder.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/security/impl/Jetspeed1CredentialPasswordEncoder.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/security/impl/Jetspeed1CredentialPasswordEncoder.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -41,7 +41,8 @@
* Jetspeed1CredentialPasswordEncoder(String algorithm) {
* this.passwordsAlgorithm = algorithm; }
*
- * public Jetspeed1CredentialPasswordEncoder(boolean dummy1, String dummy2) {}
+ * public Jetspeed1CredentialPasswordEncoder(boolean dummy1, String dummy2)
+ * {}
*/
public Jetspeed1CredentialPasswordEncoder()
@@ -77,6 +78,7 @@
encodedStream.close();
return bas.toString();
}
+ // TODO Findbugs
catch (Exception e)
{
// logger.error("Unable to encrypt password."+e.getMessage(), e);
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/services/information/InformationProviderServiceImpl.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/services/information/InformationProviderServiceImpl.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/services/information/InformationProviderServiceImpl.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -100,6 +100,7 @@
if (provider == null)
{
+ // TODO Findbugs
provider = new DynamicInformationProviderImpl(request,
servletConfig);
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/services/title/DynamicTitleService.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/services/title/DynamicTitleService.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/services/title/DynamicTitleService.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -20,6 +20,7 @@
import org.apache.pluto.om.window.PortletWindow;
+// TODO Findbugs
public interface DynamicTitleService extends
org.apache.pluto.services.title.DynamicTitleService
{
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/tools/pamanager/PortletApplicationManager.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/tools/pamanager/PortletApplicationManager.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/tools/pamanager/PortletApplicationManager.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -581,6 +581,7 @@
log.debug("Register new portlet application "
+ contextName + ".");
}
+ // TODO Findbugs
pa = registerPortletApplication(paWar, pa, paType,
paClassLoader);
}
@@ -755,6 +756,7 @@
paType, warStruct.getRootDirectory(), checksum);
}
}
+ // TODO Findbugs
catch (Exception e)
{
String msg = "Error starting portlet application " + contextName;
@@ -1152,6 +1154,7 @@
catch (InterruptedException e)
{
}
+ // TODO Findbugs
while (started)
{
checkDescriptorChanges();
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/tools/pamanager/VersionedPortletApplicationManager.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/tools/pamanager/VersionedPortletApplicationManager.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/tools/pamanager/VersionedPortletApplicationManager.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -157,6 +157,7 @@
}
portletFactory.registerPortletApplication(regPA, paClassLoader);
}
+ // TODO Findbugs
catch (Exception e)
{
String msg = "Error starting portlet application " + contextName;
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/tools/pamanager/servletcontainer/TomcatManager.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/tools/pamanager/servletcontainer/TomcatManager.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/tools/pamanager/servletcontainer/TomcatManager.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -83,6 +83,7 @@
{
super();
+ // TODO Findbugs
if (!catalinaBase.endsWith("/"))
{
}
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/util/CloneUtil.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/util/CloneUtil.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/util/CloneUtil.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -55,6 +55,7 @@
objectinputstream.close();
return clone;
}
+ // TODO Findbugs
catch (Exception exception)
{
// nothing
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/util/MimeType.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/util/MimeType.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/util/MimeType.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -33,7 +33,8 @@
public class MimeType
{
- public static final MimeType HTML = new MimeType("text/html", "UTF-8"); // FIXME:
+ public static final MimeType HTML = new MimeType("text/html", "UTF-8"); // FIXME
+ // :
// test
@@ -128,6 +129,7 @@
*/
public boolean equals(Object obj)
{
+ // TODO Findbugs
if (this == obj) { return true; }
if (obj instanceof MimeType)
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/util/descriptor/PortletApplicationWar.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/util/descriptor/PortletApplicationWar.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/util/descriptor/PortletApplicationWar.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -70,8 +70,8 @@
* <p>
* This class is utility class used mainly implementors of
* {@link org.apache.jetspeed.pamanager.Deployment}and
- * {@link org.apache.jetspeed.pamanager.Registration}to assist in deployment
- * and undeployment of portlet applications.
+ * {@link org.apache.jetspeed.pamanager.Registration}to assist in deployment and
+ * undeployment of portlet applications.
*
* @author <a href="mailto:sweav****@einno*****">Scott T. Weaver </a>
* @author <a href="mailto:maver****@einno*****">Matt Avery </a>
@@ -430,8 +430,8 @@
*
* @param targetAppRoot
* target to copy this WAR's content to. If the path ends in
- * <code>.war</code> or <code>.jar</code>. The war will be
- * copied into that file in jar format.
+ * <code>.war</code> or <code>.jar</code>. The war will be copied
+ * into that file in jar format.
* @return PortletApplicationWar representing the newly created WAR.
* @throws IOException
*/
@@ -539,9 +539,9 @@
* </p>
*
* Infuses this PortletApplicationWar's web.xml file with
- * <code>servlet</code> and a <code>servlet-mapping</code> element for
- * the JetspeedContainer servlet. This is only done if the descriptor does
- * not already contain these items.
+ * <code>servlet</code> and a <code>servlet-mapping</code> element for the
+ * JetspeedContainer servlet. This is only done if the descriptor does not
+ * already contain these items.
*
* @throws MetaDataException
* if there is a problem infusing
@@ -590,6 +590,7 @@
writer.write(WEB_XML_STRING);
writer.close();
doc = builder.build(file);
+ // TODO Findbugs
file.delete();
}
@@ -749,7 +750,7 @@
urls.add(jar.toURL());
}
}
-
+ // TODO Findbugs
return new URLClassLoader((URL[]) urls.toArray(new URL[urls.size()]),
parent);
}
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/velocity/JetspeedPowerToolFactory.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/velocity/JetspeedPowerToolFactory.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/velocity/JetspeedPowerToolFactory.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -27,6 +27,7 @@
import org.apache.jetspeed.request.RequestContext;
import org.apache.jetspeed.services.title.DynamicTitleService;
+// TODO Findbugs
public class JetspeedPowerToolFactory implements
org.apache.jetspeed.layout.JetspeedPowerToolFactory
{
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/velocity/JetspeedVelocityViewServlet.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/velocity/JetspeedVelocityViewServlet.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/java/org/apache/jetspeed/velocity/JetspeedVelocityViewServlet.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -112,6 +112,7 @@
public long lastValidated;
+ // TODO Findbugs
public VelocityEngineConfig(String decoration, String type,
String mediaType, String language, String country)
{
@@ -136,9 +137,11 @@
private long cacheValidationInterval;
/** default velocity engine */
+ // TODO Findbugs
private VelocityEngine defaultVelocityEngine;
/** Velocity EventCartridge for handling event */
+ // TODO Findbugs
EventCartridge eventCartridge;
/**
@@ -267,7 +270,8 @@
/**
* Handle the template processing request.
*
- * @see org.apache.velocity.tools.view.servlet.VelocityViewServlet.handleRequest()
+ * @see org.apache.velocity.tools.view.servlet.VelocityViewServlet.handleRequest
+ * ()
*
* @param request
* client request
@@ -315,6 +319,7 @@
renderRequest.setAttribute(VELOCITY_CONTEXT_ATTR, ctx);
}
+ // TODO Findbugs
JetspeedVelocityPowerTool jpt = (JetspeedVelocityPowerTool) renderRequest
.getAttribute(PortalReservedParameters.JETSPEED_POWER_TOOL_REQ_ATTRIBUTE);
if (jpt == null) { throw new IllegalStateException(
@@ -354,7 +359,8 @@
/**
* Retrieves the requested template.
*
- * @see org.apache.velocity.tools.view.servlet.VelocityViewServlet.getTemplate()
+ * @see org.apache.velocity.tools.view.servlet.VelocityViewServlet.getTemplate
+ * ()
*
* @param name
* The file name of the template to retrieve relative to the
@@ -390,7 +396,8 @@
/**
* Retrieves the requested template with the specified character encoding.
*
- * @see org.apache.velocity.tools.view.servlet.VelocityViewServlet.getTemplate()
+ * @see org.apache.velocity.tools.view.servlet.VelocityViewServlet.getTemplate
+ * ()
*
* @param name
* The file name of the template to retrieve relative to the
@@ -436,11 +443,13 @@
{
RequestContext requestContext = (RequestContext) ctx
.get("JS2RequestContext");
+ // TODO Findbugs
JetspeedDesktopContext desktopContext = (JetspeedDesktopContext) requestContext
.getRequest().getAttribute(
JetspeedDesktopContext.DESKTOP_CONTEXT_ATTRIBUTE);
if (desktopContext != null)
{
+ // TODO Findbugs
if (defaultVelocityEngine == null)
{
defaultVelocityEngine = initVelocity((TemplateDescriptor) null);
@@ -468,7 +477,8 @@
if (layoutDecoration == null)
{
// Page page = (Page)
- // renderRequest.getAttribute(PortalReservedParameters.PAGE_ATTRIBUTE_KEY);
+ // renderRequest.getAttribute(PortalReservedParameters.
+ // PAGE_ATTRIBUTE_KEY);
Page page = requestContext.getPage();
layoutDecoration = page
.getEffectiveDefaultDecorator(layoutType);
@@ -537,6 +547,7 @@
log.error("getVelocityEngine(): unable create base descriptor",
tle);
}
+ // TODO Findbugs
descriptor.setMediaType(layoutMediaType);
descriptor.setCountry(layoutCountry);
descriptor.setLanguage(layoutLanguage);
@@ -721,7 +732,8 @@
/**
* Initialize new velocity instance using specified macros template.
*
- * @see org.apache.velocity.tools.view.servlet.VelocityViewServlet.initVelocity()
+ * @see org.apache.velocity.tools.view.servlet.VelocityViewServlet.initVelocity
+ * ()
*
* @param macros
* template descriptor.
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/test/org/apache/jetspeed/aggregator/TestAggregator.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/test/org/apache/jetspeed/aggregator/TestAggregator.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/test/org/apache/jetspeed/aggregator/TestAggregator.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -166,10 +166,12 @@
// does not effect..
// userManager = (UserManager)
// engine.getComponentManager().getComponent(UserManager.class);
- // paContext.setAttribute(CommonPortletServices.CPS_USER_MANAGER_COMPONENT,
+ //paContext.setAttribute(CommonPortletServices.CPS_USER_MANAGER_COMPONENT
+ // ,
// userManager);
// assertEquals(userManager,
- // paContext.getAttribute(CommonPortletServices.CPS_USER_MANAGER_COMPONENT));
+ //paContext.getAttribute(CommonPortletServices.CPS_USER_MANAGER_COMPONENT
+ // ));
}
public static Test suite()
@@ -340,7 +342,7 @@
urls.add(jar.toURL());
}
}
-
+ // TODO Findbugs
localPAClassLoader = new URLClassLoader((URL[]) urls
.toArray(new URL[urls.size()]), getClass().getClassLoader());
}
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/test/org/apache/jetspeed/deployment/TestSimpleDeployment.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/test/org/apache/jetspeed/deployment/TestSimpleDeployment.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/test/org/apache/jetspeed/deployment/TestSimpleDeployment.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -86,8 +86,8 @@
/**
* Creates the test suite.
*
- * @return a test suite (<code>TestSuite</code>) that includes all
- * methods starting with "test"
+ * @return a test suite (<code>TestSuite</code>) that includes all methods
+ * starting with "test"
*/
public static Test suite()
{
@@ -142,7 +142,8 @@
* new ArrayList(2); eventListeners.add(ddel); eventListeners.add(dpal); //
* Use a -1 delay to disable auto scan StandardDeploymentManager
* autoDeployment = new
- * StandardDeploymentManager(deploySrc.getAbsolutePath(), -1, eventListeners );
+ * StandardDeploymentManager(deploySrc.getAbsolutePath(), -1, eventListeners
+ * );
*
* autoDeployment.start(); autoDeployment.fireDeploymentEvent();
*
@@ -221,8 +222,8 @@
*
* eventListeners.add(dpal); // Use a -1 delay to disable auto scan
* StandardDeploymentManager autoDeployment = new
- * StandardDeploymentManager(deploySrc.getAbsolutePath(), -1, eventListeners );
- * autoDeployment.start();
+ * StandardDeploymentManager(deploySrc.getAbsolutePath(), -1, eventListeners
+ * ); autoDeployment.start();
*
* buildEntityTestData(autoDeployment);
*
@@ -327,11 +328,12 @@
*
* @param demoApp
*
- * private void verifyDemoAppDeleted( String appName, File appFile ) {
- * assertNull(appName + " was not removed from the registry.",
- * portletRegistry
- * .getPortletApplicationByIdentifier(TEST_PORTLET_APP_NAME));
- * assertFalse(appName+" directory was not deleted.", appFile.exists()); }
+ * private void verifyDemoAppDeleted( String appName, File
+ * appFile ) { assertNull(appName +
+ * " was not removed from the registry.", portletRegistry
+ * .getPortletApplicationByIdentifier(TEST_PORTLET_APP_NAME));
+ * assertFalse(appName+" directory was not deleted.",
+ * appFile.exists()); }
*/
/**
@@ -345,6 +347,7 @@
super.setUp();
copyFrom = new File("./test/deployment/deploy");
deploySrc = new File("./target/deployment/deploy");
+ // TODO Findbugs
deploySrc.mkdirs();
deployRootFile = new File(
"./target/deployment/templates/decorators");
@@ -399,6 +402,7 @@
if (child.isFile())
{
File toFile = new File(dstDir, child.getName());
+ // TODO Findbugs
toFile.createNewFile();
FileChannel srcChannel = new FileInputStream(child)
.getChannel();
@@ -411,6 +415,7 @@
else
{
File newSubDir = new File(dstDir, child.getName());
+ // TODO Findbugs
newSubDir.mkdir();
copyFiles(child, newSubDir);
}
@@ -430,7 +435,8 @@
* try { DirectoryHelper dirHelper = new DirectoryHelper(new
* File(webAppsDir + "/" + TEST_PORTLET_APP_NAME)); paWar1 = new
* PortletApplicationWar(dirHelper, TEST_PORTLET_APP_NAME, "/" +
- * TEST_PORTLET_APP_NAME); pam.undeploy(paWar1); } catch (Exception e1) { }
+ * TEST_PORTLET_APP_NAME); pam.undeploy(paWar1); } catch (Exception e1)
+ * { }
*
* pam.unregister("jetspeed");
*
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/test/org/apache/jetspeed/window/TestWindows.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/test/org/apache/jetspeed/window/TestWindows.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal/src/test/org/apache/jetspeed/window/TestWindows.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -166,6 +166,7 @@
/**
* @param arg0
*/
+ // TODO Findbugs
public ListAppendStub(List list)
{
super("Appends object to a list");
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal-site/src/java/org/apache/jetspeed/portalsite/impl/MenuImpl.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal-site/src/java/org/apache/jetspeed/portalsite/impl/MenuImpl.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal-site/src/java/org/apache/jetspeed/portalsite/impl/MenuImpl.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -87,6 +87,7 @@
public MenuImpl(MenuImpl parent, MenuDefinition definition,
PortalSiteRequestContextImpl context, Set menus)
{
+ // TODO Findbugs
super(parent);
this.definition = definition;
@@ -1163,8 +1164,8 @@
* orderRegexpPattern - tests for and converts simple order wildcard and
* character class regular exressions to perl5/standard java pattern syntax
*
- * @param regexp -
- * candidate order regular expression
+ * @param regexp
+ * - candidate order regular expression
* @return - converted pattern
*/
private static String orderRegexpPattern(String regexp)
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal-site/src/java/org/apache/jetspeed/portalsite/impl/MenuOptionImpl.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal-site/src/java/org/apache/jetspeed/portalsite/impl/MenuOptionImpl.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal-site/src/java/org/apache/jetspeed/portalsite/impl/MenuOptionImpl.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -54,6 +54,7 @@
public MenuOptionImpl(MenuImpl parent, Node node,
MenuOptionsDefinition definition)
{
+ // TODO Findbugs
super(parent, node);
this.definition = definition;
}
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal-site/src/java/org/apache/jetspeed/portalsite/impl/MenuSeparatorImpl.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal-site/src/java/org/apache/jetspeed/portalsite/impl/MenuSeparatorImpl.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal-site/src/java/org/apache/jetspeed/portalsite/impl/MenuSeparatorImpl.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -48,6 +48,7 @@
*/
public MenuSeparatorImpl(MenuImpl parent, MenuSeparatorDefinition definition)
{
+ // TODO Findbugs
super(parent);
this.definition = definition;
}
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal-site/src/java/org/apache/jetspeed/portalsite/impl/PortalSiteSessionContextImpl.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal-site/src/java/org/apache/jetspeed/portalsite/impl/PortalSiteSessionContextImpl.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/portal-site/src/java/org/apache/jetspeed/portalsite/impl/PortalSiteSessionContextImpl.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -129,6 +129,7 @@
* store which pipeline we are serving
*
*/
+ // TODO Findbugs
private transient String pipeline = "";
/**
@@ -836,6 +837,7 @@
else if (locatorsUpdate)
{
debug.append("Updated locators");
+ // TODO Findbugs
if (stale)
{
debug.append("/stale");
@@ -1034,6 +1036,7 @@
*/
public Map getMenuDefinitionLocatorCache()
{
+ // TODO Findbugs
return menuDefinitionLocatorCache;
}
@@ -1123,9 +1126,9 @@
* request profile locator
* @return request path
*
- * private static String locatorRequestPath(ProfileLocator locator) { // use
- * request path in locator as default return locatorRequestPath(locator,
- * locator.getRequestPath()); }
+ * private static String locatorRequestPath(ProfileLocator locator)
+ * { // use request path in locator as default return
+ * locatorRequestPath(locator, locator.getRequestPath()); }
*/
/**
@@ -1137,35 +1140,41 @@
* request path
* @return request path
*
- * private static String locatorRequestPath(ProfileLocator locator, String
- * requestPath) { // search locator using the most specific, // (i.e.
- * first), locator properties array // returned by the locator iterator and
- * return // first valued property that is not a control // or navigation
- * type ProfileLocatorProperty [] properties = (ProfileLocatorProperty
- * [])locator.iterator().next(); for (int i = 0, limit = properties.length;
- * (i < limit); i++) { if (!properties[i].isControl() &&
- * !properties[i].isNavigation() && (properties[i].getValue() != null)) { //
- * use specified locator path String locatorPath = properties[i].getValue(); //
- * return specified locatorPath if absolute if
- * (locatorPath.startsWith(Folder.PATH_SEPARATOR)) { return locatorPath; } //
- * page names and relative paths are assumed relative to // request path and
- * that any locator paths with no url // separator should have the page
- * extension appended // get default page if page path null if
- * ((locatorPath.indexOf(Folder.PATH_SEPARATOR) == -1) &&
- * !locatorPath.endsWith(Page.DOCUMENT_TYPE)) { locatorPath +=
- * Page.DOCUMENT_TYPE; } // append locator path to request path, replacing //
- * requested pages and preserving requested folders boolean
- * rootFolderRequest = requestPath.equals(Folder.PATH_SEPARATOR); boolean
- * folderRequest = (!requestPath.endsWith(Page.DOCUMENT_TYPE)); int
- * lastSeparatorIndex = requestPath.lastIndexOf(Folder.PATH_SEPARATOR_CHAR);
- * if ((lastSeparatorIndex > 0) && (!folderRequest ||
- * requestPath.endsWith(Folder.PATH_SEPARATOR))) { // append locator to
- * request path base path return requestPath.substring(0,
- * lastSeparatorIndex) + Folder.PATH_SEPARATOR + locatorPath; } else if
- * (!rootFolderRequest && folderRequest) { // append locator to request path
- * root folder return requestPath + Folder.PATH_SEPARATOR + locatorPath; }
- * else { // use root folder locator return Folder.PATH_SEPARATOR +
- * locatorPath; } } } return requestPath; }
+ * private static String locatorRequestPath(ProfileLocator locator,
+ * String requestPath) { // search locator using the most specific,
+ * // (i.e. first), locator properties array // returned by the
+ * locator iterator and return // first valued property that is not
+ * a control // or navigation type ProfileLocatorProperty []
+ * properties = (ProfileLocatorProperty
+ * [])locator.iterator().next(); for (int i = 0, limit =
+ * properties.length; (i < limit); i++) { if
+ * (!properties[i].isControl() && !properties[i].isNavigation() &&
+ * (properties[i].getValue() != null)) { // use specified locator
+ * path String locatorPath = properties[i].getValue(); // return
+ * specified locatorPath if absolute if
+ * (locatorPath.startsWith(Folder.PATH_SEPARATOR)) { return
+ * locatorPath; } // page names and relative paths are assumed
+ * relative to // request path and that any locator paths with no
+ * url // separator should have the page extension appended // get
+ * default page if page path null if
+ * ((locatorPath.indexOf(Folder.PATH_SEPARATOR) == -1) &&
+ * !locatorPath.endsWith(Page.DOCUMENT_TYPE)) { locatorPath +=
+ * Page.DOCUMENT_TYPE; } // append locator path to request path,
+ * replacing // requested pages and preserving requested folders
+ * boolean rootFolderRequest =
+ * requestPath.equals(Folder.PATH_SEPARATOR); boolean folderRequest
+ * = (!requestPath.endsWith(Page.DOCUMENT_TYPE)); int
+ * lastSeparatorIndex =
+ * requestPath.lastIndexOf(Folder.PATH_SEPARATOR_CHAR); if
+ * ((lastSeparatorIndex > 0) && (!folderRequest ||
+ * requestPath.endsWith(Folder.PATH_SEPARATOR))) { // append locator
+ * to request path base path return requestPath.substring(0,
+ * lastSeparatorIndex) + Folder.PATH_SEPARATOR + locatorPath; } else
+ * if (!rootFolderRequest && folderRequest) { // append locator to
+ * request path root folder return requestPath +
+ * Folder.PATH_SEPARATOR + locatorPath; } else { // use root folder
+ * locator return Folder.PATH_SEPARATOR + locatorPath; } } } return
+ * requestPath; }
*/
/**
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/prefs/src/java/org/apache/jetspeed/prefs/impl/PreferencesFactoryImpl.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/prefs/src/java/org/apache/jetspeed/prefs/impl/PreferencesFactoryImpl.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/prefs/src/java/org/apache/jetspeed/prefs/impl/PreferencesFactoryImpl.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -33,6 +33,7 @@
public class PreferencesFactoryImpl implements PreferencesFactory
{
+ // TODO Findbugs
protected static PreferencesProvider prefsProvider;
public PreferencesFactoryImpl()
@@ -70,8 +71,10 @@
try
{
PreferencesImpl.setPreferencesProvider(prefsProvider);
+ // TODO Findbugs
PreferencesImpl.systemRoot = new PreferencesImpl(null, "",
PreferencesImpl.SYSTEM_NODE_TYPE);
+ // TODO Findbugs
PreferencesImpl.userRoot = new PreferencesImpl(null, "",
PreferencesImpl.USER_NODE_TYPE);
}
@@ -101,6 +104,7 @@
*/
public void setPrefsProvider(PreferencesProvider prefsProvider)
{
+ // TODO Findbugs
PreferencesFactoryImpl.prefsProvider = prefsProvider;
}
}
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/prefs/src/java/org/apache/jetspeed/prefs/om/impl/NodeImpl.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/prefs/src/java/org/apache/jetspeed/prefs/om/impl/NodeImpl.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/prefs/src/java/org/apache/jetspeed/prefs/om/impl/NodeImpl.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -246,6 +246,7 @@
public boolean equals(Object o)
{
+ // TODO Findbugs
return fullPath != null && o != null && o instanceof NodeImpl
&& ((NodeImpl) o).fullPath != null
&& fullPath.equals(((NodeImpl) o).fullPath);
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/prefs/src/test/org/apache/jetspeed/prefs/TestPreferences.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/prefs/src/test/org/apache/jetspeed/prefs/TestPreferences.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/prefs/src/test/org/apache/jetspeed/prefs/TestPreferences.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -79,6 +79,7 @@
}
else
{
+ // TODO Findbugs
assertTrue("expected user root == '/', " + prefs, false);
}
}
@@ -98,6 +99,7 @@
}
else
{
+ // TODO Findbugs
assertTrue("expected system root == '/', " + prefs, false);
}
}
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/profiler/src/java/org/apache/jetspeed/profiler/rules/impl/DomainCriterionResolver.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/profiler/src/java/org/apache/jetspeed/profiler/rules/impl/DomainCriterionResolver.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/profiler/src/java/org/apache/jetspeed/profiler/rules/impl/DomainCriterionResolver.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -33,7 +33,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.profiler.rules.impl.StandardResolver#isControl(org.apache.jetspeed.profiler.rules.RuleCriterion)
+ * @see
+ * org.apache.jetspeed.profiler.rules.impl.StandardResolver#isControl(org
+ * .apache.jetspeed.profiler.rules.RuleCriterion)
*/
public boolean isControl(RuleCriterion criterion)
{
@@ -43,7 +45,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.profiler.rules.impl.StandardResolver#isNavigation(org.apache.jetspeed.profiler.rules.RuleCriterion)
+ * @see
+ * org.apache.jetspeed.profiler.rules.impl.StandardResolver#isNavigation
+ * (org.apache.jetspeed.profiler.rules.RuleCriterion)
*/
public boolean isNavigation(RuleCriterion criterion)
{
@@ -78,6 +82,7 @@
// maybe there is no domain
// testing for IPv6 IP Address
idx = servername.indexOf(":");
+ // TODO Findbugs
if (idx != -1)
{
// TODO resolving IP Address?
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/profiler/src/java/org/apache/jetspeed/profiler/rules/impl/RuleCriterionImpl.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/profiler/src/java/org/apache/jetspeed/profiler/rules/impl/RuleCriterionImpl.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/profiler/src/java/org/apache/jetspeed/profiler/rules/impl/RuleCriterionImpl.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -62,6 +62,7 @@
*/
public boolean equals(Object o)
{
+ // TODO Findbugs
if (this == o) return true;
if ((o == null) || (!(o instanceof RuleCriterion))) return false;
RuleCriterion r = (RuleCriterion) o;
@@ -92,7 +93,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.profiler.rules.RuleCriterion#setType(java.lang.String)
+ * @see
+ * org.apache.jetspeed.profiler.rules.RuleCriterion#setType(java.lang.String
+ * )
*/
public void setType(String type)
{
@@ -112,7 +115,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.profiler.rules.RuleCriterion#setName(java.lang.String)
+ * @see
+ * org.apache.jetspeed.profiler.rules.RuleCriterion#setName(java.lang.String
+ * )
*/
public void setName(String name)
{
@@ -132,7 +137,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.profiler.rules.RuleCriterion#setRuleId(java.lang.String)
+ * @see
+ * org.apache.jetspeed.profiler.rules.RuleCriterion#setRuleId(java.lang.
+ * String)
*/
public void setRuleId(String ruleId)
{
@@ -162,7 +169,8 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.profiler.rules.RuleCriterion#setFallbackOrder(int)
+ * @see
+ * org.apache.jetspeed.profiler.rules.RuleCriterion#setFallbackOrder(int)
*/
public void setFallbackOrder(int i)
{
@@ -172,7 +180,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.profiler.rules.RuleCriterion#setValue(java.lang.String)
+ * @see
+ * org.apache.jetspeed.profiler.rules.RuleCriterion#setValue(java.lang.String
+ * )
*/
public void setValue(String value)
{
@@ -192,7 +202,8 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.profiler.rules.RuleCriterion#setFallbackType(int)
+ * @see
+ * org.apache.jetspeed.profiler.rules.RuleCriterion#setFallbackType(int)
*/
public void setFallbackType(int i)
{
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/rdbms/src/java/org/apache/jetspeed/components/rdbms/ojb/ConnectionRepositoryEntry.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/rdbms/src/java/org/apache/jetspeed/components/rdbms/ojb/ConnectionRepositoryEntry.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/rdbms/src/java/org/apache/jetspeed/components/rdbms/ojb/ConnectionRepositoryEntry.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -55,8 +55,8 @@
* If a JNDI name is set, the bean automatically configures a JDBC connection
* descriptor with a connection factory of type
* <code>ConnectionFactoryManagedImpl</code>, else it uses
- * <code>ConectionFactoryDBCPImpl</code>. This may be overridden my setting
- * the connection factory property explicitly.
+ * <code>ConectionFactoryDBCPImpl</code>. This may be overridden my setting the
+ * connection factory property explicitly.
* <P>
*
* Properties "driverClassName", "url", "username" and "password" are used only
@@ -65,8 +65,8 @@
* <P>
*
* The bean derives the RDBMS platform setting from the configured data source
- * or database driver using OJB's <code>JdbcMetadataUtils</code> class. At
- * least until OJB 1.0.3, however, this class does not properly distinguish the
+ * or database driver using OJB's <code>JdbcMetadataUtils</code> class. At least
+ * until OJB 1.0.3, however, this class does not properly distinguish the
* platforms "Oracle" and "Oracle9i"; it always assigns "Oracle". In case of
* "Oracle", this bean therefore opens a connection, obtains the version
* information from the database server and adjusts the platform accordingly.
@@ -266,10 +266,10 @@
}
/**
- * Sets the attribute "<code>org.apache.jetspeed.engineScoped</code>" of
- * the JDBC connection descriptor to "<code>true</code>" or "<code>false</code>".
- * If set, JNDI lookups of the connection will be done using the environment
- * naming context (ENC) of the Jetspeed engine.
+ * Sets the attribute "<code>org.apache.jetspeed.engineScoped</code>" of the
+ * JDBC connection descriptor to "<code>true</code>" or "<code>false</code>
+ * ". If set, JNDI lookups of the connection will be done using the
+ * environment naming context (ENC) of the Jetspeed engine.
*
* @param jetspeedEngineScoped
* whether to use Jetspeed engine's ENC.
@@ -457,6 +457,7 @@
* a minimal DataSource implementation that satisfies the requirements of
* JdbcMetadataUtil.
*/
+ // TODO Findbugs
private class MinimalDataSource implements DataSource
{
@@ -469,17 +470,19 @@
{
this.jcd = jcd;
}
+
public boolean isWrapperFor(Class<?> iface) throws SQLException
{
return false;
// #ifdef JDBC4 return getConnection().isWrapperFor(iface);
}
-
+
<T> T unwrap(Class<T> iface) throws SQLException
{
throw new SQLException("PoolingDataSource is not a wrapper.");
// #ifdef JDBC4 return getConnection().unwrap(iface);
}
+
/*
* (non-Javadoc)
*
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/registry/src/java/org/apache/jetspeed/components/portletregistry/PersistenceBrokerPortletRegistry.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/registry/src/java/org/apache/jetspeed/components/portletregistry/PersistenceBrokerPortletRegistry.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/registry/src/java/org/apache/jetspeed/components/portletregistry/PersistenceBrokerPortletRegistry.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -86,6 +86,7 @@
// for testing purposes only: no need for the portletFactory then
public PersistenceBrokerPortletRegistry(String repositoryPath)
{
+ // TODO Findbugs
this(repositoryPath, null, null, null, null, null);
}
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/registry/src/java/org/apache/jetspeed/om/impl/GenericMetadataImpl.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/registry/src/java/org/apache/jetspeed/om/impl/GenericMetadataImpl.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/registry/src/java/org/apache/jetspeed/om/impl/GenericMetadataImpl.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -42,6 +42,7 @@
private MultiValueMap getFieldMap(boolean create)
{
+ // TODO Findbugs
if (fieldMap == null && create)
{
synchronized (this)
@@ -58,8 +59,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.om.common.GenericMetadata#addField(java.util.Locale,
- * java.lang.String, java.lang.String)
+ * @see
+ * org.apache.jetspeed.om.common.GenericMetadata#addField(java.util.Locale,
+ * java.lang.String, java.lang.String)
*/
public void addField(Locale locale, String name, String value)
{
@@ -74,7 +76,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.om.common.GenericMetadata#addField(org.apache.jetspeed.om.common.LocalizedField)
+ * @see
+ * org.apache.jetspeed.om.common.GenericMetadata#addField(org.apache.jetspeed
+ * .om.common.LocalizedField)
*/
public void addField(LocalizedField field)
{
@@ -90,7 +94,8 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.om.common.GenericMetadata#getFields(java.lang.String)
+ * @see
+ * org.apache.jetspeed.om.common.GenericMetadata#getFields(java.lang.String)
*/
public Collection getFields(String name)
{
@@ -102,8 +107,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.om.common.GenericMetadata#setFields(java.lang.String,
- * java.util.Collection)
+ * @see
+ * org.apache.jetspeed.om.common.GenericMetadata#setFields(java.lang.String,
+ * java.util.Collection)
*/
public void setFields(String name, Collection values)
{
@@ -150,7 +156,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.om.common.GenericMetadata#setFields(java.util.Collection)
+ * @see
+ * org.apache.jetspeed.om.common.GenericMetadata#setFields(java.util.Collection
+ * )
*/
public void setFields(Collection fields)
{
@@ -180,7 +188,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.om.common.GenericMetadata#copyFields(java.util.Collection)
+ * @see
+ * org.apache.jetspeed.om.common.GenericMetadata#copyFields(java.util.Collection
+ * )
*/
public void copyFields(Collection fields)
{
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/registry/src/java/org/apache/jetspeed/om/impl/LanguageSetImpl.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/registry/src/java/org/apache/jetspeed/om/impl/LanguageSetImpl.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/registry/src/java/org/apache/jetspeed/om/impl/LanguageSetImpl.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -147,6 +147,7 @@
LanguageImpl language = new LanguageImpl();
language.setLocale(locale);
+ // TODO Findbugs
language.setTitle(fallback.getTitle());
language.setShortTitle(fallback.getShortTitle());
language.setKeywords(fallback.getKeywordStr());
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/registry/src/java/org/apache/jetspeed/om/impl/ParameterImpl.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/registry/src/java/org/apache/jetspeed/om/impl/ParameterImpl.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/registry/src/java/org/apache/jetspeed/om/impl/ParameterImpl.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -93,6 +93,7 @@
*/
public boolean equals(Object obj)
{
+ // TODO Findbugs
if (obj != null && obj.getClass().equals(getClass()))
{
ParameterImpl p = (ParameterImpl) obj;
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/registry/src/java/org/apache/jetspeed/om/portlet/impl/PortletDefinitionImpl.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/registry/src/java/org/apache/jetspeed/om/portlet/impl/PortletDefinitionImpl.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/registry/src/java/org/apache/jetspeed/om/portlet/impl/PortletDefinitionImpl.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -155,6 +155,7 @@
/** Metadata property */
private Collection metadataFields = null;
+ // TODO Findbugs
private PrefsPreferenceSetImpl preferenceSet;
private String jetspeedSecurityConstraint = null;
@@ -422,38 +423,33 @@
/*
* public void addUserAttribute(UserAttribute userAttribute) {
* this.userAttributeSet.add(userAttribute); }
- *
*//**
- * @see org.apache.jetspeed.om.common.portlet.PortletDefinitionComposite#setUserAttributeSet(java.util.Collection)
- */
+ * @see org.apache.jetspeed.om.common.portlet.PortletDefinitionComposite#setUserAttributeSet(java.util.Collection)
+ */
/*
* public void setUserAttributeSet(Collection userAttributeSet) {
* this.userAttributeSet = userAttributeSet; }
- *
*//**
- * @see org.apache.jetspeed.om.common.portlet.PortletDefinitionComposite#getUserAttributeSet()
- */
+ * @see org.apache.jetspeed.om.common.portlet.PortletDefinitionComposite#getUserAttributeSet()
+ */
/*
* public Collection getUserAttributeSet() { return this.userAttributeSet; }
- *
*//**
- * @see org.apache.jetspeed.om.common.portlet.PortletDefinitionComposite#addUserAttributeRef(org.apache.jetspeed.om.common.UserAttributeRef)
- */
+ * @see org.apache.jetspeed.om.common.portlet.PortletDefinitionComposite#addUserAttributeRef(org.apache.jetspeed.om.common.UserAttributeRef)
+ */
/*
* public void addUserAttributeRef(UserAttributeRef userAttributeRef) {
* System.out.println("_______IN addUserAttributeRef");
* this.userAttributeRefSet.add(userAttributeRef); }
- *
*//**
- * @see org.apache.jetspeed.om.common.portlet.PortletDefinitionComposite#setUserAttributeSet(java.util.Collection)
- */
+ * @see org.apache.jetspeed.om.common.portlet.PortletDefinitionComposite#setUserAttributeSet(java.util.Collection)
+ */
/*
* public void setUserAttributeRefSet(Collection userAttributeRefSet) {
* this.userAttributeRefSet = userAttributeRefSet; }
- *
*//**
- * @see org.apache.jetspeed.om.common.portlet.PortletDefinitionComposite#getUserAttributeRefSet()
- */
+ * @see org.apache.jetspeed.om.common.portlet.PortletDefinitionComposite#getUserAttributeRefSet()
+ */
/*
* public Collection getUserAttributeRefSet() { return
* this.userAttributeRefSet; }
@@ -654,8 +650,8 @@
*
* @param locale
* Locale to get the display name for
- * @return Localized text string of the display name or <code>null</code>
- * if no DisplayName exists for this locale
+ * @return Localized text string of the display name or <code>null</code> if
+ * no DisplayName exists for this locale
*/
public String getDisplayNameText(Locale locale)
{
@@ -669,8 +665,8 @@
*
* @param locale
* Locale to get the description for
- * @return Localized text string of the display name or <code>null</code>
- * if no Description exists for this locale
+ * @return Localized text string of the display name or <code>null</code> if
+ * no Description exists for this locale
*/
public String getDescriptionText(Locale locale)
{
@@ -982,7 +978,8 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.om.common.portlet.PortletDefinitionComposite#getJetspeedSecurityConstraint()
+ * @seeorg.apache.jetspeed.om.common.portlet.PortletDefinitionComposite#
+ * getJetspeedSecurityConstraint()
*/
public String getJetspeedSecurityConstraint()
{
@@ -992,7 +989,8 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.om.common.portlet.PortletDefinitionComposite#setJetspeedSecurityConstraint(java.lang.String)
+ * @seeorg.apache.jetspeed.om.common.portlet.PortletDefinitionComposite#
+ * setJetspeedSecurityConstraint(java.lang.String)
*/
public void setJetspeedSecurityConstraint(String constraint)
{
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/registry/src/java/org/apache/jetspeed/om/preference/impl/PrefsPreference.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/registry/src/java/org/apache/jetspeed/om/preference/impl/PrefsPreference.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/registry/src/java/org/apache/jetspeed/om/preference/impl/PrefsPreference.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -516,6 +516,7 @@
*/
public String toString()
{
+ // TODO Findbugs
return "Preference{" + name + "} values=" + getValueArray().toString();
}
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/registry/src/test/org/apache/jetspeed/components/portletentity/TestPortletEntityDAO.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/registry/src/test/org/apache/jetspeed/components/portletentity/TestPortletEntityDAO.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/registry/src/test/org/apache/jetspeed/components/portletentity/TestPortletEntityDAO.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -75,6 +75,7 @@
protected void tearDown() throws Exception
{
+ // TODO Findbugs
teardownTestData();
}
@@ -90,7 +91,13 @@
.getPortletApplication(TEST_APP);
assertNotNull("Portlet Application", pa);
System.out.println("pa = " + pa.getId());
- PortletDefinitionList portlets = pa.getPortletDefinitionList(); // .get(JetspeedObjectID.createFromString(TEST_PORTLET));
+ PortletDefinitionList portlets = pa.getPortletDefinitionList(); // .get(
+ // JetspeedObjectID
+ // .
+ // createFromString
+ // (
+ // TEST_PORTLET
+ // ));
Iterator pi = portlets.iterator();
PortletDefinitionComposite pd = null;
while (pi.hasNext())
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/registry/src/test/org/apache/jetspeed/components/portletregistry/AbstractRegistryTest.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/registry/src/test/org/apache/jetspeed/components/portletregistry/AbstractRegistryTest.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/registry/src/test/org/apache/jetspeed/components/portletregistry/AbstractRegistryTest.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -87,6 +87,7 @@
protected void tearDown() throws Exception
{
// super.tearDown();
+ // TODO Findbugs
}
protected void validateDublinCore(GenericMetadata metadata)
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/registry/src/test/org/apache/jetspeed/components/portletregistry/TestPortletRegistryDAO.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/registry/src/test/org/apache/jetspeed/components/portletregistry/TestPortletRegistryDAO.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/registry/src/test/org/apache/jetspeed/components/portletregistry/TestPortletRegistryDAO.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -96,6 +96,7 @@
*/
protected void tearDown() throws Exception
{
+ // TODO Findbugs
Iterator itr = portletRegistry.getPortletApplications().iterator();
while (itr.hasNext())
{
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/registry/src/test/org/apache/jetspeed/components/portletregistry/TestRegistryCache.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/registry/src/test/org/apache/jetspeed/components/portletregistry/TestRegistryCache.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/registry/src/test/org/apache/jetspeed/components/portletregistry/TestRegistryCache.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -48,7 +48,8 @@
* </p>
*
* @author <a href="mailto:weave****@apach*****">Scott T. Weaver</a>
- * @version $Id: TestPortletRegistryDAO.java 506825 2007-02-13 02:47:07Z taylor $
+ * @version $Id: TestPortletRegistryDAO.java 506825 2007-02-13 02:47:07Z taylor
+ * $
*/
public class TestRegistryCache extends DatasourceEnabledSpringTestCase
{
@@ -74,6 +75,7 @@
.getPortletApplication("PA-001");
MutablePortletApplication cached = MutablePortletApplicationProxy
.createProxy(app);
+ // TODO Findbugs
if (cached instanceof MutablePortletApplication)
System.out.println("ISA Mutable");
if (cached instanceof PortletApplicationProxy)
@@ -188,6 +190,7 @@
*/
protected void tearDown() throws Exception
{
+ // TODO Findbugs
Iterator itr = portletRegistry.getPortletApplications().iterator();
while (itr.hasNext())
{
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/registry/src/test/org/apache/jetspeed/components/portletregistry/direct/TestRegistryDirectAll.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/registry/src/test/org/apache/jetspeed/components/portletregistry/direct/TestRegistryDirectAll.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/registry/src/test/org/apache/jetspeed/components/portletregistry/direct/TestRegistryDirectAll.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -78,6 +78,7 @@
protected void tearDown() throws Exception
{
// super.tearDown();
+ // TODO Findbugs
}
/**
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/registry/src/test/org/apache/jetspeed/components/portletregistry/direct/TestRegistryDirectPart1a.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/registry/src/test/org/apache/jetspeed/components/portletregistry/direct/TestRegistryDirectPart1a.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/registry/src/test/org/apache/jetspeed/components/portletregistry/direct/TestRegistryDirectPart1a.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -75,6 +75,7 @@
protected void tearDown() throws Exception
{
// super.tearDown();
+ // TODO Findbugs
}
/**
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/registry/src/test/org/apache/jetspeed/components/portletregistry/direct/TestRegistryDirectPart1b.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/registry/src/test/org/apache/jetspeed/components/portletregistry/direct/TestRegistryDirectPart1b.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/registry/src/test/org/apache/jetspeed/components/portletregistry/direct/TestRegistryDirectPart1b.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -51,6 +51,7 @@
protected void tearDown() throws Exception
{
// super.tearDown();
+ // TODO Findbugs
}
public static Test suite()
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/rewriter/src/java/org/apache/jetspeed/rewriter/html/neko/URLRewriterFilter.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/rewriter/src/java/org/apache/jetspeed/rewriter/html/neko/URLRewriterFilter.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/rewriter/src/java/org/apache/jetspeed/rewriter/html/neko/URLRewriterFilter.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -104,6 +104,7 @@
protected void rewriteAttribute(String attrName, XMLAttributes attributes)
{
+ // TODO Findbugs
String uri = attributes.getValue(attrName);
if (uri != null)
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/rewriter/src/test/org/apache/jetspeed/rewriter/TestNekoRewriter.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/rewriter/src/test/org/apache/jetspeed/rewriter/TestNekoRewriter.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/rewriter/src/test/org/apache/jetspeed/rewriter/TestNekoRewriter.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -84,7 +84,8 @@
* target ) ;
*
* DOMParser parser = new DOMParser() ; parser.parse( target ) ;
- * System.out.println( "parse() result..." ) ; print( parser.getDocument(), "" ) ; }
+ * System.out.println( "parse() result..." ) ; print( parser.getDocument(),
+ * "" ) ; }
*
* void print( Node node, String indent ) {
* System.out.println(indent+node.getClass().getName()); Node child =
@@ -102,8 +103,9 @@
*
* SAXParser parser = new SAXParser() ; // create pipeline filters
* org.cyberneko.html.filters.Writer writer = new
- * org.cyberneko.html.filters.Writer(); Purifier purifier = new Purifier() ; //
- * setup filter chain XMLDocumentFilter[] filters = { purifier, writer, };
+ * org.cyberneko.html.filters.Writer(); Purifier purifier = new Purifier() ;
+ * // setup filter chain XMLDocumentFilter[] filters = { purifier, writer,
+ * };
*
* parser.setProperty("http://cyberneko.org/html/properties/filters",
* filters); // parse documents XMLInputSource source = new
@@ -169,6 +171,7 @@
*/
private FileWriter getTestWriter(String filename) throws IOException
{
+ // TODO Findbugs
new File("target/test/rewriter").mkdirs();
return new FileWriter("target/test/rewriter/" + filename);
}
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/rewriter/src/test/org/apache/jetspeed/rewriter/TestRewriterController.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/rewriter/src/test/org/apache/jetspeed/rewriter/TestRewriterController.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/rewriter/src/test/org/apache/jetspeed/rewriter/TestRewriterController.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -270,6 +270,7 @@
*/
private FileWriter getTestWriter(String filename) throws IOException
{
+ // TODO Findbugs
new File("target/test/rewriter").mkdirs();
return new FileWriter("target/test/rewriter/" + filename);
}
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/search/src/test/org/apache/jetspeed/search/TestSearch.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/search/src/test/org/apache/jetspeed/search/TestSearch.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/search/src/test/org/apache/jetspeed/search/TestSearch.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -75,8 +75,8 @@
/**
* Creates the test suite.
*
- * @return a test suite (<code>TestSuite</code>) that includes all
- * methods starting with "test"
+ * @return a test suite (<code>TestSuite</code>) that includes all methods
+ * starting with "test"
*/
public static Test suite()
{
@@ -105,6 +105,7 @@
for (int i = 0; i < indexFiles.length; i++)
{
File file = indexFiles[i];
+ // TODO Findbugs
file.delete();
}
}
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/security/src/java/org/apache/jetspeed/security/impl/LoginModuleProxyImpl.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/security/src/java/org/apache/jetspeed/security/impl/LoginModuleProxyImpl.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/security/src/java/org/apache/jetspeed/security/impl/LoginModuleProxyImpl.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -59,6 +59,7 @@
// Hack providing access to the UserManager in the LoginModule.
// TODO Can we fix this?
+ // TODO Findbugs
LoginModuleProxyImpl.loginModuleProxy = this;
}
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/security/src/java/org/apache/jetspeed/security/impl/UserPrincipalImpl.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/security/src/java/org/apache/jetspeed/security/impl/UserPrincipalImpl.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/security/src/java/org/apache/jetspeed/security/impl/UserPrincipalImpl.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -80,6 +80,7 @@
*/
public boolean equals(Object another)
{
+ // TODO Findbugs
if (!(another instanceof UserPrincipalImpl)) return false;
UserPrincipalImpl principal = (UserPrincipalImpl) another;
return this.getName().equals(principal.getName());
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/security/src/java/org/apache/jetspeed/security/om/impl/InternalCredentialImpl.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/security/src/java/org/apache/jetspeed/security/om/impl/InternalCredentialImpl.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/security/src/java/org/apache/jetspeed/security/om/impl/InternalCredentialImpl.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -165,7 +165,9 @@
}
/*
- * @see org.apache.jetspeed.security.om.InternalCredential#setUpdateRequired(boolean)
+ * @see
+ * org.apache.jetspeed.security.om.InternalCredential#setUpdateRequired(
+ * boolean)
*/
public void setUpdateRequired(boolean updateRequired)
{
@@ -380,6 +382,7 @@
*/
public boolean equals(Object object)
{
+ // TODO Findbugs
if (!(object instanceof InternalCredential)) return false;
InternalCredential c = (InternalCredential) object;
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/security/src/java/org/apache/jetspeed/security/om/impl/InternalGroupPrincipalImpl.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/security/src/java/org/apache/jetspeed/security/om/impl/InternalGroupPrincipalImpl.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/security/src/java/org/apache/jetspeed/security/om/impl/InternalGroupPrincipalImpl.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -111,6 +111,7 @@
*/
public boolean equals(Object object)
{
+ // TODO Findbugs
if (!(object instanceof InternalGroupPrincipal)) return false;
InternalGroupPrincipal r = (InternalGroupPrincipal) object;
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/security/src/java/org/apache/jetspeed/security/om/impl/InternalPermissionImpl.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/security/src/java/org/apache/jetspeed/security/om/impl/InternalPermissionImpl.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/security/src/java/org/apache/jetspeed/security/om/impl/InternalPermissionImpl.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -195,6 +195,7 @@
*/
public boolean equals(Object object)
{
+ // TODO Findbugs
if (!(object instanceof InternalPermission)) return false;
InternalPermission p = (InternalPermission) object;
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/security/src/java/org/apache/jetspeed/security/om/impl/InternalRolePrincipalImpl.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/security/src/java/org/apache/jetspeed/security/om/impl/InternalRolePrincipalImpl.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/security/src/java/org/apache/jetspeed/security/om/impl/InternalRolePrincipalImpl.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -109,6 +109,7 @@
*/
public boolean equals(Object object)
{
+ // TODO Findbugs
if (!(object instanceof InternalRolePrincipal)) return false;
InternalRolePrincipal r = (InternalRolePrincipal) object;
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/security/src/java/org/apache/jetspeed/security/om/impl/InternalUserPrincipalImpl.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/security/src/java/org/apache/jetspeed/security/om/impl/InternalUserPrincipalImpl.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/security/src/java/org/apache/jetspeed/security/om/impl/InternalUserPrincipalImpl.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -134,6 +134,7 @@
*/
public boolean equals(Object object)
{
+ // TODO Findbugs
if (!(object instanceof InternalUserPrincipal)) return false;
InternalUserPrincipal r = (InternalUserPrincipal) object;
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/security/src/java/org/apache/jetspeed/security/spi/impl/ldap/LdapContextProxy.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/security/src/java/org/apache/jetspeed/security/spi/impl/ldap/LdapContextProxy.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/security/src/java/org/apache/jetspeed/security/spi/impl/ldap/LdapContextProxy.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -113,7 +113,7 @@
* (non-Javadoc)
*
* @see java.lang.reflect.InvocationHandler#invoke(java.lang.Object,
- * java.lang.reflect.Method, java.lang.Object[])
+ * java.lang.reflect.Method, java.lang.Object[])
*/
public synchronized Object invoke(Object proxy, Method m, Object[] args)
throws Throwable
@@ -151,6 +151,7 @@
try
{
ctx = getCtx();
+ // TODO Findbugs
result = m.invoke(ctx, args);
}
catch (Throwable t2)
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/security/src/java/org/apache/jetspeed/security/util/GullibleSSLSocketFactory.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/security/src/java/org/apache/jetspeed/security/util/GullibleSSLSocketFactory.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/security/src/java/org/apache/jetspeed/security/util/GullibleSSLSocketFactory.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -44,6 +44,7 @@
public class GullibleSSLSocketFactory extends SSLSocketFactory
{
+ // TODO Findbugs
class GullibleTrustManager implements X509TrustManager
{
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/serializer/src/java/org/apache/jetspeed/serializer/JetspeedDDLApplication.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/serializer/src/java/org/apache/jetspeed/serializer/JetspeedDDLApplication.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/serializer/src/java/org/apache/jetspeed/serializer/JetspeedDDLApplication.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -427,6 +427,7 @@
{
System.err.println("Failed to initialize Utility!!!!!");
e.printStackTrace();
+ // TODO Findbugs
System.exit(-1);
}
try
@@ -810,6 +811,7 @@
return snap;
}
+ // TODO Findbugs
class LocalFilenameFilter implements FilenameFilter
{
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/sso/src/test/org/apache/jetspeed/sso/TestSSOComponent.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/sso/src/test/org/apache/jetspeed/sso/TestSSOComponent.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/sso/src/test/org/apache/jetspeed/sso/TestSSOComponent.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -74,6 +74,7 @@
try
{
+ // TODO Findbugs
ssoBroker = (SSOProvider) ctx.getBean("ssoProvider");
}
catch (Exception ex)
@@ -88,6 +89,7 @@
*/
public void tearDown() throws Exception
{
+ // TODO Findbugs
clean();
// super.tearDown();
}
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/statistics/src/java/org/apache/jetspeed/statistics/impl/UserStatsImpl.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/statistics/src/java/org/apache/jetspeed/statistics/impl/UserStatsImpl.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/statistics/src/java/org/apache/jetspeed/statistics/impl/UserStatsImpl.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -72,7 +72,8 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.statistics.UserStats#setUsername(java.lang.String)
+ * @see
+ * org.apache.jetspeed.statistics.UserStats#setUsername(java.lang.String)
*/
public void setUsername(String username)
{
@@ -93,7 +94,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.statistics.UserStats#setInetAddress(java.net.InetAddress)
+ * @see
+ * org.apache.jetspeed.statistics.UserStats#setInetAddress(java.net.InetAddress
+ * )
*/
public void setInetAddress(InetAddress inetAddress)
{
@@ -103,7 +106,9 @@
/*
* (non-Javadoc)
*
- * @see org.apache.jetspeed.statistics.UserStats#setInetAddressFromIp(java.lang.String)
+ * @see
+ * org.apache.jetspeed.statistics.UserStats#setInetAddressFromIp(java.lang
+ * .String)
*/
public void setInetAddressFromIp(String ip) throws UnknownHostException
{
@@ -119,7 +124,7 @@
*/
public boolean equals(Object obj)
{
-
+ // TODO Findbugs
if (!(obj instanceof UserStats)) return false;
UserStats userstat = (UserStats) obj;
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/statistics/src/test/org/apache/jetspeed/audit/TestAuditActivity.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/statistics/src/test/org/apache/jetspeed/audit/TestAuditActivity.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/statistics/src/test/org/apache/jetspeed/audit/TestAuditActivity.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -77,6 +77,7 @@
{
Connection con = audit.getDataSource().getConnection();
+ // TODO Findbugs
PreparedStatement psmt = con
.prepareStatement("DELETE FROM ADMIN_ACTIVITY");
psmt.execute();
@@ -99,6 +100,7 @@
{
Connection con = audit.getDataSource().getConnection();
+ // TODO Findbugs
PreparedStatement psmt = con.prepareStatement(query);
ResultSet rs = psmt.executeQuery();
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/statistics/src/test/org/apache/jetspeed/statistics/TestStatistics.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/statistics/src/test/org/apache/jetspeed/statistics/TestStatistics.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/statistics/src/test/org/apache/jetspeed/statistics/TestStatistics.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -90,6 +90,7 @@
try
{
+ // TODO Findbugs
DatabaseMetaData dmd = statistics.getDataSource().getConnection()
.getMetaData();
System.out
@@ -100,6 +101,7 @@
Connection con = statistics.getDataSource().getConnection();
+ // TODO Findbugs
PreparedStatement psmt = con
.prepareStatement("DELETE FROM USER_STATISTICS");
psmt.execute();
@@ -125,6 +127,7 @@
{
Connection con = statistics.getDataSource().getConnection();
+ // TODO Findbugs
PreparedStatement psmt = con.prepareStatement(query);
ResultSet rs = psmt.executeQuery();
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/web-content/src/java/org/apache/jetspeed/portlet/WebContentPortlet.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/web-content/src/java/org/apache/jetspeed/portlet/WebContentPortlet.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/web-content/src/java/org/apache/jetspeed/portlet/WebContentPortlet.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -705,10 +705,12 @@
// propagate User-Agent, so target site does not think we are a D.O.S.
// attack
+ // TODO Findbugs
httpMethod.addRequestHeader("User-Agent", useragentProperty);
// BOZO - DON'T do this. default policy seems to be more flexible!!!
- // httpMethod.getParams().setCookiePolicy(CookiePolicy.BROWSER_COMPATIBILITY);
+ // httpMethod.getParams().setCookiePolicy(CookiePolicy.
+ // BROWSER_COMPATIBILITY);
// ...ready to use!
return httpMethod;
@@ -759,6 +761,7 @@
try
{
is.mark(BLOCK_SIZE);
+ // TODO Findbugs
is.read(buf, 0, BLOCK_SIZE);
String content = new String(buf, "ISO-8859-1");
String lowerCaseContent = content.toLowerCase();
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/web-content/src/java/org/apache/jetspeed/portlet/webcontent/WebContentHistoryPage.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/web-content/src/java/org/apache/jetspeed/portlet/webcontent/WebContentHistoryPage.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/web-content/src/java/org/apache/jetspeed/portlet/webcontent/WebContentHistoryPage.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -65,6 +65,7 @@
public boolean equals(Object o)
{
+ // TODO Findbugs
if (o == null || !(o instanceof WebContentHistoryPage)) return false;
WebContentHistoryPage page = (WebContentHistoryPage) o;
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/web-content/src/java/org/apache/jetspeed/portlet/webcontent/WebContentResource.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/web-content/src/java/org/apache/jetspeed/portlet/webcontent/WebContentResource.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/web-content/src/java/org/apache/jetspeed/portlet/webcontent/WebContentResource.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -30,6 +30,7 @@
public class WebContentResource implements Serializable
{
+ // TODO Findbugs
private transient byte[] content = null;
private String url = null;
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/webapp-logging/src/java/org/apache/jetspeed/webapp/logging/IsolatedLog4JLogger.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/webapp-logging/src/java/org/apache/jetspeed/webapp/logging/IsolatedLog4JLogger.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/webapp-logging/src/java/org/apache/jetspeed/webapp/logging/IsolatedLog4JLogger.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -26,8 +26,7 @@
/**
* IsolatedLog4JLogger routes all commons-logging logging using Log4J to an
- * ContextClassLoader specific Hierarchy.
- * </p>
+ * ContextClassLoader specific Hierarchy. </p>
* <p>
* For web or application servers providing (and enforcing) commons-logging and
* Log4J from a shared context (like JBoss), configuring Log4J loggers and
@@ -37,8 +36,8 @@
* <p>
* Capturing root logging for logging events from within the web application for
* example isn't possible using a Log4J propery or xml configuration without
- * routing <em>ALL</em> root logging through the new (web application
- * specific) configuration.
+ * routing <em>ALL</em> root logging through the new (web application specific)
+ * configuration.
* </p>
* <p>
* <em>It is possible using the Log4J API directly instead of configuration files,
@@ -95,11 +94,10 @@
* </p>
* <p>
* TODO: It might be useful to have this utility class available for usage by
- * Portlet Applications too. Because this class <em>must</em> be included
- * within a web application classpath, a separate jetspeed-tools or
- * jetspeed-utils library will have to be created for it (and possibly other
- * utility classes as well) which then can be put in the web application lib
- * folder.
+ * Portlet Applications too. Because this class <em>must</em> be included within
+ * a web application classpath, a separate jetspeed-tools or jetspeed-utils
+ * library will have to be created for it (and possibly other utility classes as
+ * well) which then can be put in the web application lib folder.
* </p>
*
* @author <a href="mailto:ate****@douma*****">Ate Douma</a>
@@ -155,6 +153,7 @@
// Temporarily save this instance so it can be
// rerouted one the Hierarchy is set.
logger = new Log4JLogger(name);
+ // TODO Findbugs
notIsolatedLoggers.put(this, name);
}
else
@@ -194,6 +193,7 @@
public boolean equals(Object obj)
{
+ // TODO Findbugs
Log4JLogger logger = getLogger();
return logger != null ? logger.equals(obj) : false;
}
@@ -291,6 +291,7 @@
public String toString()
{
Log4JLogger logger = getLogger();
+ // TODO Findbugs
return logger != null ? logger.toString() : null;
}
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/webapp-logging/src/java/org/apache/jetspeed/webapp/logging/Log4JConfigurator.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/webapp-logging/src/java/org/apache/jetspeed/webapp/logging/Log4JConfigurator.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/components/webapp-logging/src/java/org/apache/jetspeed/webapp/logging/Log4JConfigurator.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -83,6 +83,7 @@
isolatedHierarchy = new Hierarchy(new RootCategory(Level.INFO));
new PropertyConfigurator().doConfigure(p, isolatedHierarchy);
IsolatedLog4JLogger.setHierarchy(isolatedHierarchy);
+ // TODO Findbugs
log = LogFactory.getLog(this.getClass());
log.info("IsolatedLog4JLogger configured");
}
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/jetspeed-api/src/java/org/apache/jetspeed/PortalContext.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/jetspeed-api/src/java/org/apache/jetspeed/PortalContext.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/jetspeed-api/src/java/org/apache/jetspeed/PortalContext.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -28,6 +28,7 @@
* @author <a href="mailto:david****@blues*****">David Sean Taylor</a>
* @version $Id: PortalContext.java 185962 2004-03-08 01:03:33Z jford $
*/
+// TODO Findbugs
public interface PortalContext extends javax.portlet.PortalContext
{
@@ -56,8 +57,8 @@
/**
* Sets the application root path for this Jetspeed engine context.
*
- * @param applicationRoot -
- * the applicationRoot path on the file system.
+ * @param applicationRoot
+ * - the applicationRoot path on the file system.
*/
public void setApplicationRoot(String applicationRoot);
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/jetspeed-api/src/java/org/apache/jetspeed/i18n/KeyedMessage.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/jetspeed-api/src/java/org/apache/jetspeed/i18n/KeyedMessage.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/jetspeed-api/src/java/org/apache/jetspeed/i18n/KeyedMessage.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -29,8 +29,8 @@
/**
* KeyedMessage provides an automatically derived i18n message key based on its
- * static instance definition and can be used as comparable constant too.
- * <h3>Purpose</h3>
+ * static instance definition and can be used as comparable constant too. <h3>
+ * Purpose</h3>
* <p>
* With a KeyedMessage a named constant message (format) can be statically
* defined which automatically translate themselves for a specific locale using
@@ -44,34 +44,33 @@
* </p>
* <p>
* A KeyedMessage automatically derives the ResourceBundle lookup key from its
- * (statically defined) instance field name using the following format: <br/><br/><code>
+ * (statically defined) instance field name using the following format:
+ * <br/><br/><code>
* <containingClass.name>.<staticInstanceField.name>
- * </code>
- * <br/>
+ * </code> <br/>
* </p>
* <p>
* The containingClass is derived at construction time by analyzing the
- * StackTraceElements of a thrown exception. This <em><b>requires</b></em>
- * the instance to be defined as a public static field!
+ * StackTraceElements of a thrown exception. This <em><b>requires</b></em> the
+ * instance to be defined as a public static field!
* </p>
* <p>
* At first access, the key is resolved by inspecting the derived
* containingClass for the <em>declared</em> field defining this instance.
* </p>
* <p>
- * If the KeyedMessage instance <em><b>wasn't</b></em> defined as public
- * static field, the key can't be resolved and message translation using a
- * ResourceBundle won't be possible. Translation using the default message will
- * still work though. Furthermore, this instance can't be used as comparable
- * named constant as the {@link #equals(Object)}method will always return false
- * in this case.
+ * If the KeyedMessage instance <em><b>wasn't</b></em> defined as public static field, the
+ * key can't be resolved and message translation using a ResourceBundle won't be
+ * possible. Translation using the default message will still work though.
+ * Furthermore, this instance can't be used as comparable named constant as the
+ * {@link #equals(Object)}method will always return false in this case.
* </p>
* <h3>Default ResourceBundle name derivation</h3>
* <p>
* When the key of a KeyedMessage is resolved, the default ResourceBundle name
* for message translation is retrieved from the defined public static String
- * field named {@link #KEYED_MESSAGE_BUNDLE_FIELD_NAME "KEYED_MESSAGE_BUNDLE"}defined
- * in its containingClass or one of its superClasses or interfaces.
+ * field named {@link #KEYED_MESSAGE_BUNDLE_FIELD_NAME "KEYED_MESSAGE_BUNDLE"}
+ * defined in its containingClass or one of its superClasses or interfaces.
* </p>
* <p>
* If this field cannot be found, the fully qualified name of the
@@ -94,7 +93,8 @@
* In Jetspeed, the <code>LocalizationValve</code> initializes the
* {@link CurrentLocale} on each request. KeyedMessages accessed within the
* context of an Jetspeed request therefore will always be translated using the
- * current user Locale with the {@link #getMessage()}or {@link #toString()}methods.
+ * current user Locale with the {@link #getMessage()}or {@link #toString()}
+ * methods.
* </p>
* <h3>Default ResourceBundle lookup</h3>
* <p>
@@ -107,8 +107,8 @@
* <h3>MessageFormat parameters</h3>
* <p>
* MessageFormat patterns can also be used for a KeyedMessage.<br/> With the
- * {@link #create(Object[])}method a specialized copy of a KeyedMessage
- * instance can be created containing the arguments to be used during message
+ * {@link #create(Object[])}method a specialized copy of a KeyedMessage instance
+ * can be created containing the arguments to be used during message
* translation.
* </p>
* <p>
@@ -116,10 +116,10 @@
* used for named constant comparison.
* </p>
* <p>
- * For simplified usage, three {@link #create(Object)},{@link #create(Object, Object)}and
- * {@link #create(Object, Object, Object)}methods are provided which delegate
- * to {@link #create(Object[])}with their argument(s) transformed into an
- * Object array.
+ * For simplified usage, three {@link #create(Object)},
+ * {@link #create(Object, Object)}and {@link #create(Object, Object, Object)}
+ * methods are provided which delegate to {@link #create(Object[])}with their
+ * argument(s) transformed into an Object array.
* </p>
* <h3>Extending KeyedMessage</h3>
* <p>
@@ -183,7 +183,7 @@
* if ( SecurityException.USER_DOES_NOT_EXISTS.equals(sex.getKeyedMessage()) {
* // handle USER_DOES_NOT_EXISTS error
* }
- * }
+ * }
* </pre>
*
* @author <a href="mailto:ate****@douma*****">Ate Douma</a>
@@ -195,7 +195,8 @@
/**
* Static String Field name searched for in the class defining a
* KeyedMessage containing the default resource bundle to use for
- * translation. <br/><em>Note: this Field is looked up using definingClass.getField thus it may also be
+ * translation. <br/>
+ * <em>Note: this Field is looked up using definingClass.getField thus it may also be
* defined in a superclass or interface of the definingClass.</em>
*/
public static final String KEYED_MESSAGE_BUNDLE_FIELD_NAME = "KEYED_MESSAGE_BUNDLE";
@@ -350,6 +351,7 @@
resourceName = (String) field.get(null);
}
}
+ // TODO Findbugs
catch (Exception e)
{
}
@@ -579,7 +581,8 @@
}
/**
- * @return the arguments defined for this {@link #create(Object[]) derived}instance
+ * @return the arguments defined for this {@link #create(Object[]) derived}
+ * instance
* @see #create(Object[])
*/
public Object[] getArguments()
@@ -590,7 +593,8 @@
/**
* @param index
* argument number
- * @return an argument defined for this {@link #create(Object[]) derived}instance
+ * @return an argument defined for this {@link #create(Object[]) derived}
+ * instance
*/
public Object getArgument(int index)
{
@@ -610,14 +614,15 @@
/**
* @param otherObject
* KeyedMessage instance to compare with
- * @return true only if otherObject is a KeyedMessage
- * {@link create(Object[]) derived}from this instance (or visa
- * versa) and (thus both are) {@link #resolve() resolved}.
+ * @return true only if otherObject is a KeyedMessage {@link
+ * create(Object[]) derived}from this instance (or visa versa) and
+ * (thus both are) {@link #resolve() resolved}.
* @see #create(Object[])
* @see #resolve()
*/
public boolean equals(Object otherObject)
{
+ // TODO Findbugs
if (otherObject != null && otherObject instanceof KeyedMessage)
{
resolve();
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/jetspeed-api/src/java/org/apache/jetspeed/om/BaseSecurityReference.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/jetspeed-api/src/java/org/apache/jetspeed/om/BaseSecurityReference.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/jetspeed-api/src/java/org/apache/jetspeed/om/BaseSecurityReference.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -61,6 +61,7 @@
*/
public Object clone() throws java.lang.CloneNotSupportedException
{
+ // TODO Findbugs
BaseSecurityReference cloned = new BaseSecurityReference();
cloned.parent = this.parent;
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/layout-portlets/src/java/org/apache/jetspeed/portlets/layout/LayoutPortlet.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/layout-portlets/src/java/org/apache/jetspeed/portlets/layout/LayoutPortlet.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/layout-portlets/src/java/org/apache/jetspeed/portlets/layout/LayoutPortlet.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -402,6 +402,7 @@
log.error("failed to remove portlet " + fragmentId + " from page: "
+ pageId, e);
}
+ // TODO Findbugs
removeFragment(page, page.getRootFragment(), fragmentId);
}
@@ -437,6 +438,7 @@
log.error("failed to add portlet " + portletId + " to page: "
+ pageId, e);
}
+ // TODO Findbugs
addPortletToPage(page, page.getRootFragment(), portletId);
}
@@ -718,8 +720,8 @@
*
* @param name
* Name of the Decoration.
- * @return <code>java.util.Properties</code> representing the
- * configuration object.
+ * @return <code>java.util.Properties</code> representing the configuration
+ * object.
*/
protected Configuration getConfiguration(RenderRequest request, String name)
{
@@ -864,6 +866,7 @@
private Configuration config;
+ // TODO Findbugs
public CachedTemplate(String key, TemplateDescriptor template,
Configuration config)
{
Modified: pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/taglibs/treecontrol/src/java/org/apache/webapp/admin/TreeControl.java
===================================================================
--- pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/taglibs/treecontrol/src/java/org/apache/webapp/admin/TreeControl.java 2008-07-09 10:14:13 UTC (rev 1020)
+++ pal-portal/branches/pal-portal-1.x/portal/jetspeed-2/taglibs/treecontrol/src/java/org/apache/webapp/admin/TreeControl.java 2008-07-09 10:15:05 UTC (rev 1021)
@@ -23,13 +23,14 @@
/**
* <p>
* The overall data structure representing a <em>tree control</em> that can be
- * rendered by the <code>TreeControlTag</code> custom tag. Each node of the
- * tree is represented by an instance of <code>TreeControlNode</code>.
+ * rendered by the <code>TreeControlTag</code> custom tag. Each node of the tree
+ * is represented by an instance of <code>TreeControlNode</code>.
* </p>
*
* @author Jazmin Jonson
* @author Craig R. McClanahan
- * @version $Revision: 516448 $ $Date: 2007-03-10 01:25:47 +0900 (土, 10 3月 2007) $
+ * @version $Revision: 516448 $ $Date: 2007-03-10 01:25:47 +0900 (土, 10 3月 2007)
+ * $
*/
public class TreeControl implements Serializable
@@ -46,6 +47,7 @@
{
super();
+ // TODO Findbugs
setRoot(null);
}
@@ -60,6 +62,7 @@
{
super();
+ // TODO Findbugs
setRoot(root);
}
@@ -92,6 +95,7 @@
{
if (this.root != null) removeNode(this.root);
if (root != null) addNode(root);
+ // TODO Findbugs
root.setLast(true);
this.root = root;
}
@@ -134,8 +138,8 @@
* deselecting any previous node that was so marked.
*
* @param node
- * Name of the node to mark as selected, or <code>null</code>
- * if there should be no currently selected node
+ * Name of the node to mark as selected, or <code>null</code> if
+ * there should be no currently selected node
*/
public void selectNode(String name)
{