[Groonga-commit] groonga/grnci at 52bf39d [master] Comment out a check for column names to support functions

Back to archive index

Susumu Yata null+****@clear*****
Tue Feb 16 03:45:20 JST 2016


Susumu Yata	2016-02-16 03:45:20 +0900 (Tue, 16 Feb 2016)

  New Revision: 52bf39dfb5a6269f3fe671cf6284d5338b9a9548
  https://github.com/groonga/grnci/commit/52bf39dfb5a6269f3fe671cf6284d5338b9a9548

  Message:
    Comment out a check for column names to support functions
    
    GitHub: #25

  Modified files:
    grnci.go

  Modified: grnci.go (+11 -10)
===================================================================
--- grnci.go    2016-02-16 03:43:19 +0900 (61a05b5)
+++ grnci.go    2016-02-16 03:45:20 +0900 (396d0fa)
@@ -1972,16 +1972,17 @@ func (db *DB) selectParse(data []byte, vals interface{}, fields []*FieldInfo) (i
 		return 0, fmt.Errorf("%d columns expected but %d columns actual",
 			len(fields), nCols)
 	}
-	for i, rawCol := range rawCols {
-		var nameType []string
-		if err := json.Unmarshal(rawCol, &nameType); err != nil {
-			return 0, err
-		}
-		if nameType[0] != fields[i].ColumnName() {
-			return 0, fmt.Errorf("column %#v expected but column %#v actual",
-				fields[i].ColumnName(), nameType[0])
-		}
-	}
+	// FIXME: the following check disallows functions.
+//	for i, rawCol := range rawCols {
+//		var nameType []string
+//		if err := json.Unmarshal(rawCol, &nameType); err != nil {
+//			return 0, err
+//		}
+//		if nameType[0] != fields[i].ColumnName() {
+//			return 0, fmt.Errorf("column %#v expected but column %#v actual",
+//				fields[i].ColumnName(), nameType[0])
+//		}
+//	}
 
 	rawRecs := raw[0][2:]
 	nRecs := len(rawRecs)
-------------- next part --------------
HTML����������������������������...
下載 



More information about the Groonga-commit mailing list
Back to archive index