[Groonga-commit] groonga/grnxx at ce3611a [new_data_types] Add a missing test.

Back to archive index

susumu.yata null+****@clear*****
Mon Nov 17 19:42:30 JST 2014


susumu.yata	2014-11-17 19:42:30 +0900 (Mon, 17 Nov 2014)

  New Revision: ce3611a434904af3fc9f4fc1a9b0d284ccb17ba9
  https://github.com/groonga/grnxx/commit/ce3611a434904af3fc9f4fc1a9b0d284ccb17ba9

  Message:
    Add a missing test.

  Modified files:
    test/test_expression.cpp

  Modified: test/test_expression.cpp (+12 -12)
===================================================================
--- test/test_expression.cpp    2014-11-17 18:49:27 +0900 (2d5a2ee)
+++ test/test_expression.cpp    2014-11-17 19:42:30 +0900 (e01b2a3)
@@ -805,20 +805,20 @@ void test_column() {
     assert(ref_results[i].value() == test.ref_values[row_id].value());
   }
 
-//  // Test an expression (RefVector).
-//  assert(builder->push_column(&error, "RefVector"));
-//  expression = builder->release(&error);
-//  assert(expression);
+  // Test an expression (RefVector).
+  builder->push_column("RefVector");
+  expression = builder->release();
 
-//  records = create_input_records();
+  records = create_input_records();
 
-//  grnxx::Array<grnxx::IntVector> ref_vector_results;
-//  assert(expression->evaluate(&error, records, &ref_vector_results));
-//  assert(ref_vector_results.size() == test.table->num_rows());
-//  for (grnxx::Int i = 0; i < ref_vector_results.size(); ++i) {
-//    grnxx::Int row_id = records.get_row_id(i);
-//    assert(ref_vector_results[i] == test.ref_vector_values[row_id]);
-//  }
+  grnxx::Array<grnxx::IntVector> ref_vector_results;
+  expression->evaluate(records, &ref_vector_results);
+  assert(ref_vector_results.size() == test.table->num_rows());
+  for (size_t i = 0; i < ref_vector_results.size(); ++i) {
+    size_t row_id = records[i].row_id.value();
+    assert((ref_vector_results[i] ==
+            test.ref_vector_values[row_id]).is_true());
+  }
 }
 
 void test_logical_not() {
-------------- next part --------------
HTML����������������������������...
下載 



More information about the Groonga-commit mailing list
Back to archive index