[Groonga-commit] groonga/grnxx at 2cc367b [new_data_types] Remove an unused function.

Back to archive index

susumu.yata null+****@clear*****
Mon Nov 10 15:36:00 JST 2014


susumu.yata	2014-11-10 15:36:00 +0900 (Mon, 10 Nov 2014)

  New Revision: 2cc367bb20bc2be32e1412a0624a026d3546be97
  https://github.com/groonga/grnxx/commit/2cc367bb20bc2be32e1412a0624a026d3546be97

  Message:
    Remove an unused function.

  Modified files:
    lib/grnxx/impl/column/base.cpp
    lib/grnxx/impl/column/base.hpp

  Modified: lib/grnxx/impl/column/base.cpp (+0 -22)
===================================================================
--- lib/grnxx/impl/column/base.cpp    2014-11-10 11:38:24 +0900 (3e7ff2f)
+++ lib/grnxx/impl/column/base.cpp    2014-11-10 15:36:00 +0900 (b5b1634)
@@ -253,28 +253,6 @@ void ColumnBase::set_key(Int, const Datum &) {
 //  throw "Not supported";  // TODO
 //}
 
-//bool ColumnBase::initialize_base(Error *error,
-//                                 Table *table,
-//                                 const StringCRef &name,
-//                                 DataType data_type,
-//                                 const ColumnOptions &options) {
-//  table_ = table;
-//  if (!name_.assign(error, name)) {
-//    return false;
-//  }
-//  data_type_ = data_type;
-//  if ((data_type == INT_DATA) || (data_type == INT_VECTOR_DATA)) {
-//    if (options.ref_table_name.size() != 0) {
-//      auto ref_table = table_->_db()->find_table(error, options.ref_table_name);
-//      if (!ref_table) {
-//        return false;
-//      }
-//      ref_table_ = ref_table;
-//    }
-//  }
-//  return true;
-//}
-
 //Index *ColumnBase::find_index_with_id(Error *error,
 //                                      const StringCRef &name,
 //                                      Int *index_id) const {

  Modified: lib/grnxx/impl/column/base.hpp (+0 -11)
===================================================================
--- lib/grnxx/impl/column/base.hpp    2014-11-10 11:38:24 +0900 (1f9a90e)
+++ lib/grnxx/impl/column/base.hpp    2014-11-10 15:36:00 +0900 (9071dfd)
@@ -114,17 +114,6 @@ class ColumnBase : public ColumnInterface {
   bool is_key_;
   Array<std::unique_ptr<Index>> indexes_;
 
-//  // Initialize the base members.
-//  //
-//  // On success, returns true.
-//  // On failure, returns false and stores error information into "*error" if
-//  // "error" != nullptr.
-//  bool initialize_base(Error *error,
-//                       Table *table,
-//                       const String &name,
-//                       DataType data_type,
-//                       const ColumnOptions &options);
-
 // private:
 //  // Find an index with its ID.
 //  //
-------------- next part --------------
HTML����������������������������...
下載 



More information about the Groonga-commit mailing list
Back to archive index