[Groonga-commit] droonga/droonga-http-server at eebd506 [master] Fix default value of "daemon" option to "false".

Back to archive index

YUKI Hiroshi null+****@clear*****
Wed Nov 5 15:07:22 JST 2014


YUKI Hiroshi	2014-11-05 15:07:22 +0900 (Wed, 05 Nov 2014)

  New Revision: eebd506a835195c43e2b40318337a7dbd490349b
  https://github.com/droonga/droonga-http-server/commit/eebd506a835195c43e2b40318337a7dbd490349b

  Message:
    Fix default value of "daemon" option to "false".

  Modified files:
    lib/default-configs.js

  Modified: lib/default-configs.js (+7 -9)
===================================================================
--- lib/default-configs.js    2014-11-05 14:21:07 +0900 (0e545ce)
+++ lib/default-configs.js    2014-11-05 15:07:22 +0900 (7633dad)
@@ -64,15 +64,13 @@ function defineDefaultConfigs(configs) {
   ]);
   define(configs, 'environment', process.env.NODE_ENV || 'development');
 
-  if (configs.daemon) {
-    define(configs, 'pid_file',        'droonga-http-server.pid');
-    define(configs, 'access_log_file', 'droonga-http-server.access.log');
-    define(configs, 'system_log_file', 'droonga-http-server.system.log');
-  } else {
-    define(configs, 'daemon',          false);
-    define(configs, 'access_log_file', '-');
-    define(configs, 'system_log_file', '-');
-  }
+  // Ignore value of "daemon" option defined in the configuration file,
+  // because "commander" is not designed for a boolean option with
+  // unfixed default value.
+  configs.daemon = false;
+  // define(configs, 'daemon',          false);
+  define(configs, 'access_log_file', '-');
+  define(configs, 'system_log_file', '-');
   define(configs, 'system_log_level', 'warn');
 
   define(configs, 'engine.host',            engineConfigs.host);
-------------- next part --------------
HTML����������������������������...
下載 



More information about the Groonga-commit mailing list
Back to archive index