[Groonga-commit] droonga/express-droonga at 4993e07 [master] Setup codes to share session information only when it is sharable

Back to archive index

YUKI Hiroshi null+****@clear*****
Fri Jan 10 19:01:40 JST 2014


YUKI Hiroshi	2014-01-10 19:01:40 +0900 (Fri, 10 Jan 2014)

  New Revision: 4993e0725cfe0c5d69361cbac336f9fb4b652915
  https://github.com/droonga/express-droonga/commit/4993e0725cfe0c5d69361cbac336f9fb4b652915

  Message:
    Setup codes to share session information only when it is sharable

  Modified files:
    lib/adapter/socket.io.js

  Modified: lib/adapter/socket.io.js (+11 -13)
===================================================================
--- lib/adapter/socket.io.js    2014-01-10 18:58:49 +0900 (4f140a7)
+++ lib/adapter/socket.io.js    2014-01-10 19:01:40 +0900 (eaecf59)
@@ -162,15 +162,15 @@ exports.register = function(application, server, params) {
   var io = socketIo.listen(server);
 
   // share session information with HTTP connections
-  var parseCookie = connect.utils.parseCookie;
   var sessionStore = params.sessionStore;
-  io.configure(function() {
-    io.set('authorization', function(handshakeData, callback) {
-      if (handshakeData.headers.cookie) {
-        var cookie = handshakeData.headers.cookie;
-        var sessionID = parseCookie(cookie)['connect.sid'];
-        handshakeData.sessionID = sessionID;
-        if (sessionStore) {
+  if (sessionStore) {
+    var parseCookie = connect.utils.parseCookie;
+    io.configure(function() {
+      io.set('authorization', function(handshakeData, callback) {
+        if (handshakeData.headers.cookie) {
+          var cookie = handshakeData.headers.cookie;
+          var sessionID = parseCookie(cookie)['connect.sid'];
+          handshakeData.sessionID = sessionID;
           sessionStore.get(sessionID, function(error, session) {
             if (error) {
               callback(error, false);
@@ -180,13 +180,11 @@ exports.register = function(application, server, params) {
             }
           });
         } else {
-          callback(null, true);
+          return callback(new Error('no cookie'), false);
         }
-      } else {
-        return callback(new Error('no cookie'), false);
-      }
+      });
     });
-  });
+  }
 
   io.sockets.on('connection', function(socket) {
     application.emit('connection', socket);
-------------- next part --------------
HTML����������������������������...
下載 



More information about the Groonga-commit mailing list
Back to archive index