待辦事項 #48969

Tuvalu nationset

啟用日期: 2024-01-29 10:00 最後更新: 2024-03-11 09:16

回報者:
負責人:
類型:
狀態:
關閉
元件:
里程碑:
優先權:
5 - 中
嚴重程度:
5 - 中
處理結果:
修正
檔案:
3

細節

Hi. I created a couple nationsets a few years back to spice up my games. I think this one for the island nation of Tuvalu would be a good fit for the FreeCiv proper.

The flag images are based on https://en.wikipedia.org/wiki/Flag_of_Tuvalu#/media/File:Flag_of_Tuvalu.svg and is used under a CC0 license.

Thanks.

Ticket History (3/16 Histories)

2024-01-29 10:00 Updated by: joeraz5
  • New Ticket "Tuvalu nationset" created
2024-01-29 10:26 Updated by: cazfi
2024-02-24 11:37 Updated by: cazfi
評語

Following updates to the patch are needed (see doc/README.nations):

- The new files need to be listed in relevant Makefile.am's for the nation to get included in the release tarball, and getting installed along freeciv on autotools based builds
- The nation ruleset and flag needs to be listed in the meson.build for meson based builds.
- The nation ruleset need to be listed in translations/nations/POTFILES.in
- Make the nation ruleset file to follow style of the existing rulesets (in S3_2 and main). Mainly this means having spaces around "="'

Also, at least one female leader would be good to have.

Can you make these changes?

2024-02-24 12:42 Updated by: joeraz5
評語

Sure, I can make those changes and will send a new patch when I'm done.

Regarding a female leader, the only one I was able to find is Teniku Talesi (https://en.wikipedia.org/wiki/Teniku_Talesi), but she was only acting Governor-General (though she was in the role for over a year). Should I include her, or would you prefer to stick to more permanent leaders?

2024-02-24 12:45 Updated by: cazfi
評語

Reply To joeraz5

Regarding a female leader, the only one I was able to find is Teniku Talesi (https://en.wikipedia.org/wiki/Teniku_Talesi), but she was only acting Governor-General (though she was in the role for over a year). Should I include her, or would you prefer to stick to more permanent leaders?

Let's include her.

2024-02-24 12:53 Updated by: joeraz5
評語

Okay, will do.

2024-02-26 13:02 Updated by: joeraz5
  • File tuvalunationset1.patch (File ID: 13706) is attached
2024-02-26 13:02 Updated by: joeraz5
  • File tuvalunationset1.patch (File ID: 13706) is deleted
2024-02-26 13:03 Updated by: joeraz5
評語

Here you go. This new patch should address all of your requests. I also added a few other civil war nations and improved the flag images.

Let me know if you need anything else. Thanks.

2024-03-02 11:32 Updated by: cazfi
  • 處理結果 Update from to Accepted
  • 負責人 Update from (無) to cazfi
2024-03-03 00:12 Updated by: cazfi
  • 處理結果 Update from Accepted to
評語

I got an error like this while switching rulesets:

End-of-file not in line of its own
  file "/fast/freeciv/main/src/data/nation/tuvaluan.ruleset", line 61, pos 0
  looking at: ' '
  included from file "/fast/freeciv/main/src/data/default/nationlist.ruleset", line 642
  included from file "/fast/freeciv/main/src/data/granularity/nations.ruleset", line 72

2024-03-07 20:50 Updated by: cazfi
  • 處理結果 Update from to Accepted
評語

- Removed space from the last line of the nation ruleset file

2024-03-11 09:16 Updated by: cazfi
  • 處理結果 Update from Accepted to 修正
  • 狀態 Update from 開啟 to 關閉

編輯

Please login to add comment to this ticket » 登入