dai_select_tech() clang analyzer warning about garbage goal_values[i]

• 回報者: cazfi
• 負責人: cazfi
• 類型: 問題回報
• 狀態: 關閉
• 元件: AI
• 里程碑: 3.0.9 (closed)
• 優先權: 5 - 中
• 嚴重程度: 5 - 中
• 處理結果: 修正
• 檔案: 2

細節

S3_1, clang analyzer:

../../../../src/ai/default/aitech.c:174:26: warning: The left operand of '>' is a garbage value [core.UndefinedBinaryOperatorResult]
      if (goal_values[i] > goal_values[newgoal]

This was partly fixed by #47959, but not completely

Ticket History (3/5 Histories)

2023-09-17 00:49 Updated by: cazfi

• New Ticket "dai_select_tech() clang analyzer warning about garbage goal_valuesi" created

2023-09-17 00:57 Updated by: cazfi

• File 0020-dai_select_tech-Get-advance_count-just-once.patch (File ID: 13205) is attached

2023-09-17 00:59 Updated by: cazfi

• File 0012-dai_select_tech-Get-advance_count-just-once.patch (File ID: 13206) is attached

2023-09-17 01:12 Updated by: cazfi

• 負責人 Update from (無) to cazfi
• 處理結果 Update from 無 to Accepted
• Summary Updated

評語

Bugfix for S3_0 & S3_1 attached. Later branches are not affected, but small part of the patch ported for optimization reasons.

2023-09-18 13:22 Updated by: cazfi

• 狀態 Update from 開啟 to 關閉
• 處理結果 Update from Accepted to 修正