update_city_activity() mishandling gold surplus

• 回報者: cazfi
• 負責人: cazfi
• 類型: 問題回報
• 狀態: 關閉
• 元件: Server
• 里程碑: 3.0.9 (closed)
• 優先權: 5 - 中
• 嚴重程度: 5 - 中
• 處理結果: 修正
• 檔案: 1

細節

update_city_activity() does not use gold surplus, but tries to recalculate it itself:

    /* Update the treasury. */
    pplayer->economic.gold += pcity->prod[O_GOLD];
    pplayer->economic.gold -= city_total_impr_gold_upkeep(pcity);
    pplayer->economic.gold -= city_total_unit_gold_upkeep(pcity);

This breaks Surplus_Waste -effects, and was also mentioned in https://www.hostedredmine.com/issues/892050

Ticket History (3/5 Histories)

2023-07-11 10:13 Updated by: cazfi

• New Ticket "update_city_activity() mishandling gold surplus" created

2023-07-22 04:14 Updated by: cazfi

• Details Updated

2023-07-22 06:14 Updated by: cazfi

• File 0017-Increase-treasury-by-precalculated-city-gold-surplus.patch (File ID: 12931) is attached

2023-07-22 06:30 Updated by: cazfi

• 負責人 Update from (無) to cazfi
• 處理結果 Update from 無 to Accepted
• 里程碑 Update from (無) to 3.0.9 (closed)

評語

Reply To cazfi

This breaks Surplus_Waste -effects

For that reason only main/S3_2 affected. Still, I'd want the fix to S3_1 and even to S3_0 too, to act as a baseline for other fixes.

2023-07-31 05:33 Updated by: cazfi

• 狀態 Update from 開啟 to 關閉
• 處理結果 Update from Accepted to 修正

評語

Reply To cazfi

This breaks Surplus_Waste -effects

For that reason only main/S3_2 affected. Still, I'd want the fix to S3_1 and even to S3_0 too, to act as a baseline for other fixes.