待辦事項 #48234

Meson: Lua detection regression compared to autotools

啟用日期: 2023-06-13 15:29 最後更新: 2023-06-26 04:13

回報者:
負責人:
類型:
狀態:
關閉
元件:
優先權:
5 - 中
嚴重程度:
5 - 中
處理結果:
修正
檔案:
3

細節

Kangie has opened PR https://github.com/freeciv/freeciv/pull/48 , thus reporting an autotools -> meson regression that lua is not searched from alternative locations.

The patch they have provided bumps mimum meson requirement. This is going to need some actions. At best case just a documentation updated (doc/INSTALL.meson on all branches where the minimum version changes, README.packaging in the oldest branch where the minimum version changes). At worst case we need to implement that boilerplate, that minimum meson version bump tried to avoid, instead. As for S3_1, there's also an option to just not to implement the fix, as meson based build is experimental feature on that branch anyway.

Ticket History (3/8 Histories)

2023-06-13 15:29 Updated by: cazfi
  • New Ticket "Meson: Lua detection regression compared to autotools" created
2023-06-14 13:39 Updated by: cazfi
2023-06-24 04:08 Updated by: cazfi
評語

Reply To cazfi

The patch they have provided bumps mimum meson requirement.

We already require 0.57, which is higher than 0.56 of Debian Bullseye. At the same time new 0.60 dependency would still be lower than 0.61 of Ubuntu Jammy. Further, checking meson 0.60 Release Notes, there are many features that we would want when making meson the primary build system for all kind of tasks.

So, I'd say we bump the dependency in main & S3_2. Even thought all of meson build is flagged experimental in S3_1, I'd rather follow the rule that we don't increase such minimum requirements on a series that has already released at least betas.

2023-06-24 04:35 Updated by: cazfi
  • 負責人 Update from (無) to cazfi
  • 處理結果 Update from to Accepted
評語

Attached main & S3_2 patches are the original patch with relevant documentation changes added (Both touching doc/INSTALL.meson, S3_2 one touching also README.packaging 3.1 -> 3.2 changes list). The patch retains its original author information, with just mention of my additions in the commit message.

S3_1 one I wrote from scratch, so I'm the author, commit message just mentioning bug reporting information.

2023-06-26 04:13 Updated by: cazfi
  • 狀態 Update from 開啟 to 關閉
  • 處理結果 Update from Accepted to 修正

編輯

Please login to add comment to this ticket » 登入