待辦事項 #48185

Font is too small in the city detail window (gtk 3.22 / windows)

啟用日期: 2023-06-08 10:16 最後更新: 2023-06-21 13:02

回報者:
負責人:
類型:
狀態:
關閉
元件:
里程碑:
優先權:
5 - 中
嚴重程度:
5 - 中
處理結果:
修正
檔案:
3

細節

Version: Freeciv-3.0.7-msys2-win64-gtk3.22 OS: Windows 10

Text is too small to read in the city detail window (information panel),

see the picture:

https://skywind3000.github.io/images/p/misc/2023/small-font.png

And can't find a suitable option for this in the font setting panel.

Ticket History (3/16 Histories)

2023-06-08 10:16 Updated by: skywind3000
  • New Ticket "Font is too small in the city detail window (gtk 3.22 / windows)" created
2023-06-08 10:24 Updated by: skywind3000
評語

Confirmed in 3.1.0 beta2 as well

2023-06-08 10:58 Updated by: cazfi
評語

That should be the City Label font (Game -> Options -> Local Client -> Font (tab) -> City Label)

2023-06-08 11:00 Updated by: cazfi
  • 嚴重程度 Update from 7 to 5 - 中
  • 優先權 Update from 7 to 5 - 中
2023-06-08 13:18 Updated by: skywind3000
評語

@cazfi the "City Label" font option doesn't affect the text I said before, it will only change the city name's text in the map view:

https://skywind3000.github.io/images/p/misc/2023/city-label.png

I've tried everything in the "Font (tab)", nothing works.

2023-06-08 17:50 Updated by: skywind3000
評語

I've made a comparison for freeciv2 and freeciv3, this is definitely a regression:

https://skywind3000.github.io/images/p/misc/2023/city-compare.png

btw, I'm a big fan of Civ2 but it hasn't been updated in ages. I've been on the

hunt for something similar but with a modern twist and someone told me about

this project. I thought I'd give it a try but ran into a small problem with the font

size that's really affecting my gameplay. I couldn't continue playing Freeciv3

because of it, so I switched back to the old Freeciv2-gtk2 version for now.

It's not ideal, but it'll do for the time being.

2023-06-08 18:17 Updated by: cazfi
評語

Reply To skywind3000

@cazfi the "City Label" font option doesn't affect the text I said before, it will only change the city name's text in the map view: https://skywind3000.github.io/images/p/misc/2023/city-label.png

So there's some bug in that the setting does not go on effect. There's more to it, though, as I have not been able to reproduce the problem, neither on linux, nor on a fresh build I made on Windows. That particular setting works fine for me. However, "Small Font" one does not; #48186 (issues might be related, but not necessarily)

Can you attach your freeciv-client-rc-3.1 (or freeciv-client-rc-3.0)? ( from <HOME>/.freeciv/, see https://freeciv.fandom.com/wiki/FAQ#HOME_directory_not_set? ) Maybe something there is the key difference between your setup and mine.

2023-06-09 00:51 Updated by: skywind3000
評語

Finally, I have figured it out:

it is a translation mistake.

Initially, you advised me to change the "City Label" option, but I actually changed the "City Names" font option.

Since I was using the Freeciv client in my native language, some language contributors translated "City Names" as "城市名称," while they translated "City Label" as "城市名."

Both "名称" and "名" mean "name" (formal and casual tone for the same thing).

Therefore, when you said "City Label," I saw "城市名称" and "城市名," and I chose the first one.

see the detail:

https://skywind3000.github.io/images/p/misc/2023/ch-font-en.png

It is much better now:

https://skywind3000.github.io/images/p/misc/2023/much-better.png

Thanks for your patience.

I suggest leave this ticket open, at least there are two things can be improved:

1) correct the translation error: "City Label" should be "城市标签", not "城市名"

2) can we have some better font defaults, especially for the high resolution displays on windows ?

One final point, I noticed that the font size in the setting previews is noticeably larger than what is actually displayed in the game. I'm not sure if it's a DPI issue or something with Windows. The text is much more comfortable to read in the font setting preview, but much smaller in the city detail or help windows. This may be the underlying cause.

edit: text in the chat history window and help window are much smaller than the previews too.

(Edited, 2023-06-09 00:58 Updated by: skywind3000)
2023-06-09 02:09 Updated by: cazfi
評語

Reply To skywind3000

I noticed that the font size in the setting previews is noticeably larger than what is actually displayed in the game.

I see the same on Linux (especially with a fix to #48186). I suspect that to be an issue with units, e.g., that the settings return size in points, but we use that as a size in pixels.

2023-06-09 04:38 Updated by: skywind3000
評語

So we have narrowed the problem down to how to render text in the exact same size as the preview text.

But why do city names in the map view have the correct size/unit ? It seems to be equal to the preview size.

Do we use SDL to draw the map view ? Why does SDL got the right text size/unit while other gtk widgets can't ?

(Edited, 2023-06-09 04:44 Updated by: skywind3000)
2023-06-09 07:09 Updated by: cazfi
  • 里程碑 Update from (無) to 3.0.8 (closed)
  • 元件 Update from (無) to Gtk3.22-client
2023-06-13 13:22 Updated by: cazfi
  • 負責人 Update from (無) to cazfi
  • 處理結果 Update from to Accepted
評語

Reply To skywind3000

Do we use SDL to draw the map view ? Why does SDL got the right text size/unit while other gtk widgets can't ?

No. But we do draw mapview ourselves, while we just give the style information for Gtk Widgets. Attached patches for all branches (including S2_6) updates the unit in those style sheets.

2023-06-21 13:02 Updated by: cazfi
  • 狀態 Update from 開啟 to 關閉
  • 處理結果 Update from Accepted to 修正

編輯

Please login to add comment to this ticket » 登入