../../../../src/ai/default/aitech.c:173:26: warning: The left operand of '>' is a garbage value [core.UndefinedBinaryOperatorResult]
if (goal_values[i] > goal_values[newgoal]
This is likely to be false positive. Analyzer just doesn't know that on each iteration valid_advance_by_number() will filter exactly same techs out, i.e., the same indices are initialized and used.
This ticket is about fixing the clang analyzer warning. There's space for refactoring, but will open separate ticket about that.
../../../../src/ai/default/aitech.c:173:26: warning: The left operand of '>' is a garbage value [core.UndefinedBinaryOperatorResult] if (goal_values[i] > goal_values[newgoal]This is likely to be false positive. Analyzer just doesn't know that on each iteration valid_advance_by_number() will filter exactly same techs out, i.e., the same indices are initialized and used.
This ticket is about fixing the clang analyzer warning. There's space for refactoring, but will open separate ticket about that.