待辦事項 #47957

dai_process_defender_want() desire 'int' to fabs()

啟用日期: 2023-04-28 02:32 最後更新: 2023-05-01 21:09

回報者:
負責人:
類型:
狀態:
關閉
元件:
里程碑:
優先權:
6
嚴重程度:
5 - 中
處理結果:
修正
檔案:
1

細節

S3_0 build fails on Suse Leap. It doesn't like the fact that fabs() gets an non-float parameter on dai_process_defender_want().

I guess it's referring to 'desire' being an int, and that looks like real bug to me (definitely should support non-integer values)

Ticket History (3/5 Histories)

2023-04-28 02:32 Updated by: cazfi
  • New Ticket "dai_process_defender_want() desire 'int' to fabs()" created
2023-04-28 14:07 Updated by: cazfi
  • 優先權 Update from 5 - 中 to 6
2023-04-29 04:30 Updated by: cazfi
  • 負責人 Update from (無) to cazfi
  • 處理結果 Update from to Accepted
評語

- More a "clang issue" than "Suse Leap issue" - seen on other environments since original report
- Only S3_0 affeced. Later branches (from where this was backported) have those variables as floats
- I've concluded that right thing to do (in S3_0 - if other branches affected would have been affected, they could have had different fix) is to do partial revert of osdn #47901

Patch attached.

2023-05-01 21:09 Updated by: cazfi
  • 狀態 Update from 開啟 to 關閉
  • 處理結果 Update from Accepted to 修正

Attachment File List

編輯

You are not logged in. I you are not logged in, your comment will be treated as an anonymous post. » 登入