activity_to_extra_rmcause() does not consider ACTIVITY_CLEAN

• 回報者: cazfi
• 負責人: cazfi
• 類型: 問題回報
• 狀態: 關閉
• 元件: General
• 里程碑: 3.2.0
• 優先權: 5 - 中
• 嚴重程度: 5 - 中
• 處理結果: 修正
• 檔案: 1

細節

activity_to_extra_rmcause() treats ACTIVITY_CLEAN like it would not remove any extras, whereas it actually would remove *both* ERM_CLEANPOLLUTION and ERM_CLEANFALLOUT

Ticket History (3/4 Histories)

2023-04-11 03:45 Updated by: cazfi

• New Ticket "activity_to_extra_rmcause() does not consider ACTIVITY_CLEAN" created

2023-04-14 03:27 Updated by: cazfi

• File 0050-Add-ERM_CLEAN.patch (File ID: 12180) is attached

2023-04-14 03:31 Updated by: cazfi

評語

Attached patch adds the new ERM_CLEAN extra removal cause at this point of "Clean Pollution/Clean Fallout" -> "Clean" migration already, and makes activity_to_extra_rmcause() to return that for ACTIVITY_CLEAN.

Supplied rulesets temporarily have both ERM_CLEAN and ERM_CLEANPOLLUTION/ERM_CLEANFALLOUT for all cleanable extras, and I guess any custom ruleset wanting to be compatible with this specific point of freeciv development need to do the same.

2023-04-22 06:39 Updated by: cazfi

• 狀態 Update from 開啟 to 關閉
• 負責人 Update from (無) to cazfi
• 處理結果 Update from 無 to 修正