sdl2-client units_orders_city_dlg_callback() enters block that is supposed to open orders menu only for PRESSED_EVENTs. Early in the block is another check for PRESSED_EVENT that cause city dialog to close with the unit in focus on main map. As event can't be simultaneously both PRESSED_EVENT and not-PRESSED_EVENT, the orders menu part of the code block is dead code.
sdl2-client units_orders_city_dlg_callback() enters block that is supposed to open orders menu only for PRESSED_EVENTs. Early in the block is another check for PRESSED_EVENT that cause city dialog to close with the unit in focus on main map. As event can't be simultaneously both PRESSED_EVENT and not-PRESSED_EVENT, the orders menu part of the code block is dead code.