homebrew-appbundle.sh: Set correct version number

• 回報者: cazfi
• 負責人: cazfi
• 類型: 修補檔案
• 狀態: 關閉
• 元件: Bootstrap
• 里程碑: 3.1.0-beta1 (closed)
• 優先權: 5 - 中
• 嚴重程度: 5 - 中
• 處理結果: 修正
• 檔案: 1

細節 回覆

Noticed that homebrew-appbundle.sh sets hardcoded "3.1.0-alpha" version string to info file, regardless of the freeciv version.

Ticket History (3/6 Histories)

2023-02-18 10:55 Updated by: cazfi

• New Ticket "homebrew-appbundle.sh: Set correct version number" created

2023-02-19 02:23 Updated by: cazfi

• 負責人 Update from (無) to ddeanbrown

評語 回覆

- Should be relatively easy to implement - just run fc_version from the source root to get the version
- Failing actual code update before 3.1.0-beta1, we need to adjust our release process (for that release) so that the hardcoded version numbers are set correctly

2023-02-28 12:23 Updated by: ddeanbrown

• File homebrew-appbundle.sh.patch (File ID: 11737) is attached

2023-02-28 12:23 Updated by: ddeanbrown

評語 回覆

This patch should do it.

2023-02-28 19:49 Updated by: cazfi

• 負責人 Update from ddeanbrown to cazfi
• 處理結果 Update from 無 to Accepted

評語 回覆

Thanks. But please try not to include unrelated changes to a patch in the future (here especially the gtk3.22-client -> gtk4-client switch - I'm inclined to just add mention of that to the commit message this time when I push this in, instead of rejecting the entire patch because of it)

2023-03-03 06:17 Updated by: cazfi

• 狀態 Update from 開啟 to 關閉
• 處理結果 Update from Accepted to 修正