Qt: mr_menu::menus_sensitive() dead code loop

• 回報者: cazfi
• 負責人: cazfi
• 類型: 問題回報
• 狀態: 關閉
• 元件: Qt-client
• 里程碑: 3.0.7 (closed)
• 優先權: 5 - 中
• 嚴重程度: 5 - 中
• 處理結果: 修正
• 檔案: 1

細節

mr_menu::menus_sensitive() does not set ptile nor ptype before it iterates over focus units. Inside that iteration it does nothing when ptile not ptype is not set (they would get set the first time execution enters that block)

Ticket History (3/4 Histories)

2022-10-08 21:22 Updated by: cazfi

• New Ticket "Qt: mr_menu::menus_sensitive() dead code loop" created

2023-01-30 06:58 Updated by: cazfi

• File 0043-Qt-Correct-irrigate-mine-menu-entry-rename.patch (File ID: 11502) is attached

2023-01-30 07:00 Updated by: cazfi

• 負責人 Update from (無) to cazfi
• 處理結果 Update from 無 to Accepted
• 里程碑 Update from (無) to 3.0.7 (closed)

評語

The consequence is that the code renaming menu entries always considers all the focus units to be on the same tile.

2023-02-05 01:38 Updated by: cazfi

• 狀態 Update from 開啟 to 關閉
• 處理結果 Update from Accepted to 修正