待辦事項 #45716

generate_packets.py: Replace unfill with bit-copy/move

啟用日期: 2022-09-25 22:57 最後更新: 2022-09-28 22:25

回報者:
負責人:
類型:
狀態:
關閉
元件:
里程碑:
優先權:
5 - 中
嚴重程度:
5 - 中
處理結果:
修正
檔案:
1

細節

Part of #43927. The unfill concept introduced in #45222 as a mirror to fill is ultimately misguided; the actual use case is backing up the received key fields while zeroing a packet struct (to initialize the cache), which amounts to temporarily moving those values out of the struct – this is better achieved by bitcopying the data, i.e. a straight assignment (for non-arrays at least). In contrast, fill clones the data, which is not what we want here (and which could cause problems if and when we start to support types that need to be destroyed explicitly).

Ticket History (3/4 Histories)

2022-09-25 22:57 Updated by: alienvalkyrie
  • New Ticket "generate_packets.py: Replace unfill with bit-copy/move" created
2022-09-26 22:04 Updated by: alienvalkyrie
  • 處理結果 Update from to Accepted
2022-09-28 22:25 Updated by: alienvalkyrie
  • 狀態 Update from 開啟 to 關閉
  • 處理結果 Update from Accepted to 修正

編輯

Please login to add comment to this ticket » 登入