S3_0 legacysave.c: base_order handling issue

• 回報者: cazfi
• 負責人: cazfi
• 類型: 問題回報
• 狀態: 關閉
• 元件: Server
• 里程碑: 3.0.4 (closed)
• 優先權: 5 - 中
• 嚴重程度: 5 - 中
• 處理結果: 修正
• 檔案: 2

細節 回覆

Clang analyzer warns about dead assignment "order_base = base_order[base];" on S3_0 legacysave.c:1619.

Haven't looked closely, but seems to me that there's a real bug in there that it's not used, but the original 'base' gets used (so the base_order gets ignored)

Ticket History (3/6 Histories)

2022-09-23 18:34 Updated by: cazfi

• New Ticket "S3_0 legacysave.c: base_order handling issue" created

2022-09-24 08:13 Updated by: cazfi

• Details Updated

2022-09-24 08:24 Updated by: cazfi

• File 0022-Fix-loading-base-building-orders-from-2.3-savegames.patch (File ID: 10373) is attached

2022-09-24 08:24 Updated by: cazfi

• File 0011-Fix-loading-base-building-orders-from-2.3-savegames.patch (File ID: 10374) is attached

2022-09-24 08:25 Updated by: cazfi

• 負責人 Update from (無) to cazfi
• 處理結果 Update from 無 to Accepted
• 里程碑 Update from (無) to 3.0.4 (closed)

評語 回覆

S3_0 and S2_6 affected (the only branches that support legacy saves (< 2.3))

2022-09-26 10:35 Updated by: cazfi

• 狀態 Update from 開啟 to 關閉
• 處理結果 Update from Accepted to 修正