待辦事項 #45687

gtk: Dead 'bg' assignment in create_tech_tree()

啟用日期: 2022-09-23 12:22 最後更新: 2023-01-03 05:13

回報者:
負責人:
類型:
狀態:
關閉
元件:
里程碑:
優先權:
5 - 中
嚴重程度:
5 - 中
處理結果:
修正
檔案:
3

細節

Clang analyzer warns that create_tech_tree() assignment of 'bg = COLOR_REQTREE_BACKGROUND;' is never used. That's true as following switch sets 'bg' for each possible value of the enum.

It doesn't seem like a terrible idea to have that assignment in place, in case there's ever an illegal enum value (one that the switch won't catch), but maybe we change this regardless, to avoid clang analyzer spam about it?

Ticket History (3/7 Histories)

2022-09-23 12:22 Updated by: cazfi
  • New Ticket "gtk: Dead 'bg' assignment in create_tech_tree()" created
2022-10-11 22:28 Updated by: cazfi
評語

I think #45831 should be resolved first.

2022-12-28 06:55 Updated by: cazfi
  • 負責人 Update from (無) to cazfi
  • 處理結果 Update from to Accepted
  • 里程碑 Update from (無) to 3.0.6 (closed)
2023-01-03 05:13 Updated by: cazfi
  • 狀態 Update from 開啟 to 關閉
  • 處理結果 Update from Accepted to 修正

編輯

Please login to add comment to this ticket » 登入