generate_packets.py: Generated code call 'are_cm_parameters_equal()'

• 回報者: cazfi
• 負責人: cazfi
• 類型: 問題回報
• 狀態: 關閉
• 元件: General
• 里程碑: 3.2.0
• 優先權: 5 - 中
• 嚴重程度: 5 - 中
• 處理結果: 修正
• 檔案: 1

細節

When a packet definition containing cm_parameter is added to packets.def (there isn't any at the moment), compile fails for are_cm_parameters_equal() calls in packets_gen.c. I guess it should be cm_are_parameters_equal()

Ticket History (3/7 Histories)

2022-07-29 23:45 Updated by: cazfi

• New Ticket "generate_packets.py: Generated code call 'are_cm_parameters_equal()'" created

2022-07-30 00:02 Updated by: cazfi

評語

Reply To cazfi

When a packet definition containing cm_parameter is added to packets.def

Example is in WIP patch attached to #45268

2022-07-30 18:05 Updated by: alienvalkyrie

• File 0002-generate_packets.py-Correctly-identify-cm_parameter-.patch (File ID: 9987) is attached

2022-07-30 18:08 Updated by: alienvalkyrie

評語

Typo in the generate_packets type parsing code. I'm a bit busy, so I haven't tested the patch in action, but it should work. If not, I'll have to take a closer look.

(Edited, 2022-07-30 18:08 Updated by: alienvalkyrie)

2022-08-17 17:52 Updated by: cazfi

• 里程碑 Update from (無) to 3.2.0

評語

It works.

2022-08-22 10:22 Updated by: cazfi

• 負責人 Update from (無) to cazfi
• 處理結果 Update from 無 to Accepted

2022-08-23 23:59 Updated by: cazfi

• 狀態 Update from 開啟 to 關閉
• 處理結果 Update from Accepted to 修正