待辦事項 #45240

Garbage defender in send_combat()

啟用日期: 2022-07-26 19:27 最後更新: 2022-08-10 15:26

回報者:
負責人:
類型:
狀態:
關閉
元件:
里程碑:
優先權:
5 - 中
嚴重程度:
5 - 中
處理結果:
修正
檔案:
1

細節

I'm looking at map_get_seen() segfault with the new fantasy ruleset. So far it seems that pdefender in send_combat() is garbage pointer (or at least it points to garbage content), which then leads to garbage playermap pointer to access seen counters.

Ticket History (3/6 Histories)

2022-07-26 19:27 Updated by: cazfi
  • New Ticket "Garbage defender in send_combat()" created
2022-07-26 19:52 Updated by: cazfi
評語

It seems that unit_attack_civilian_casualties() call causes the city to get destroyed, taking supported units with it, and the failed defender was one of those.

2022-07-26 19:55 Updated by: cazfi
  • 里程碑 Update from (無) to 3.2.0
  • 元件 Update from (無) to Server
評語

Only master affected, as older branches do not reduce city size in case it's already 1, i.e., city never gets destroyed in that call.

2022-08-01 12:36 Updated by: cazfi
  • 負責人 Update from (無) to cazfi
  • 處理結果 Update from to Accepted
2022-08-10 15:26 Updated by: cazfi
  • 狀態 Update from 開啟 to 關閉
  • 處理結果 Update from Accepted to 修正

編輯

You are not logged in. I you are not logged in, your comment will be treated as an anonymous post. » 登入