Failing "punit->homecity == pcity->id" asserts for NoHome units

• 回報者: cazfi
• 負責人: cazfi
• 類型: 問題回報
• 狀態: 關閉
• 元件: Server
• 里程碑: 3.1.0 (closed)
• 優先權: 5 - 中
• 嚴重程度: 5 - 中
• 處理結果: 修正
• 檔案: 3

細節

Overzealous asserts in place_unit() and check_city_good() fail for NoHome units.

Ticket History (3/8 Histories)

2022-07-23 15:06 Updated by: cazfi

• New Ticket "Failing "punit->homecity == pcity->id" asserts for NoHome units" created

2022-07-23 15:14 Updated by: cazfi

• File 0056-Fix-overzealous-asserts-against-NoHome-units.patch (File ID: 9900) is attached

2022-07-23 15:15 Updated by: cazfi

• File 0021-Fix-overzealous-asserts-against-NoHome-units.patch (File ID: 9901) is attached

2022-07-23 15:15 Updated by: cazfi

• 負責人 Update from (無) to cazfi
• 處理結果 Update from 無 to Accepted
• 里程碑 Update from (無) to 3.0.3 (closed)

評語

S3_0 version to be applied to S2_6 too

2022-07-24 11:52 Updated by: cazfi

• 處理結果 Update from Accepted to 無
• 里程碑 Update from 3.0.3 (closed) to (無)

評語

Maybe those asserts are not overzealous, but they have been detecting an actual bug. They are in the context of units in city.units_supported, so there should NOT be any NoHome units there.

2022-07-25 02:22 Updated by: cazfi

• File 0044-place_unit-Do-not-add-NoHome-units-to-city-s-units_s.patch (File ID: 9912) is attached

2022-07-25 02:22 Updated by: cazfi

• 處理結果 Update from 無 to Accepted
• 里程碑 Update from (無) to 3.1.0 (closed)

評語

Actual bugfix attached. master & S3_1 affected.

2022-07-29 17:58 Updated by: cazfi

• 狀態 Update from 開啟 to 關閉
• 處理結果 Update from Accepted to 修正