Disallow changing ruleset when fixed one given from commandline

• 回報者: cazfi
• 負責人: cazfi
• 類型: 修補檔案
• 狀態: 關閉
• 元件: Server
• 里程碑: 3.2.0
• 優先權: 5 - 中
• 嚴重程度: 5 - 中
• 處理結果: 修正
• 檔案: 2

細節

If freeciv-server has been launched with specific ruleset given at commandline, it makes sense not to allow (regular) users within the server to change that.

As current behavior is not strictly a bug, and some users may rely on it, targeting this to master only, as a behavior change.

Ticket History (3/7 Histories)

2022-07-07 06:00 Updated by: cazfi

• New Ticket "Disallow changing ruleset when fixed one given from commandline" created

2022-07-07 06:52 Updated by: cazfi

• File 0049-Prohibit-changing-ruleset-given-from-commandline.patch (File ID: 9754) is attached

2022-07-07 06:53 Updated by: cazfi

• 負責人 Update from (無) to cazfi
• 處理結果 Update from 無 to Accepted

2022-07-16 08:02 Updated by: cazfi

• 處理結果 Update from Accepted to 無

評語

Current patch causes trouble in case the client inadvertently has such a tileset active that it triggers initial server setup with wrong ruleset.

2022-07-17 17:04 Updated by: cazfi

• File 0008-Prohibit-changing-ruleset-given-from-commandline.patch (File ID: 9829) is attached

2022-07-17 17:05 Updated by: cazfi

• 處理結果 Update from 無 to Accepted

評語

The new version brings the restriction only to is_restricted() connections - so the client that forked the server can still change the ruleset.

2022-07-21 20:17 Updated by: cazfi

• 狀態 Update from 開啟 to 關閉
• 處理結果 Update from Accepted to 修正