generate_packets.py: remove no-packet flag

• 回報者: alienvalkyrie
• 負責人: alienvalkyrie
• 類型: 修補檔案
• 狀態: 關閉
• 元件: Bootstrap
• 里程碑: 3.2.0
• 優先權: 5 - 中
• 嚴重程度: 5 - 中
• 處理結果: 修正
• 檔案: 2

細節

Part of #43927. The packet flag no-packet produces send methods that do not take a packet struct as argument. Such code is only valid for packets with no fields (e.g. PACKET_SERVER_SHUTDOWN), in which case the flag is automatically added anyway. It has also never been explicitly added to a packet since the delta protocol was first committed.

~> remove it as a settable flag (while keeping the "empty packet send methods take no packet struct" behavior).

Ticket History (3/7 Histories)

2022-07-02 06:03 Updated by: alienvalkyrie

• New Ticket "generate_packets.py: remove no-packet flag" created

2022-07-02 06:29 Updated by: alienvalkyrie

• File 0002-generate_packets.py-Remove-no-packet-flag.patch (File ID: 9661) is attached

2022-07-02 06:29 Updated by: alienvalkyrie

• 處理結果 Update from 無 to Accepted

2022-07-02 07:19 Updated by: alienvalkyrie

• 處理結果 Update from Accepted to 無

評語

Still need to remove mentions in packets.def comments

2022-07-02 07:22 Updated by: alienvalkyrie

• File 0002-generate_packets.py-Remove-no-packet-flag.patch (File ID: 9662) is attached

2022-07-02 07:23 Updated by: alienvalkyrie

• 處理結果 Update from 無 to Accepted

2022-07-03 21:34 Updated by: alienvalkyrie

• 狀態 Update from 開啟 to 關閉
• 處理結果 Update from Accepted to 修正