待辦事項 #44801

Json protocol dio_put_*() to return int

啟用日期: 2022-06-12 03:34 最後更新: 2022-06-24 21:24

回報者:
負責人:
類型:
狀態:
關閉
元件:
里程碑:
優先權:
5 - 中
嚴重程度:
5 - 中
處理結果:
修正
檔案:
2

細節

Split from https://www.hostedredmine.com/issues/745593 and continuation to #44458

Turn dio_put_*() return value to int, though all the functions can return just 0 at this point. Port parts of generate_packets.py changes from https://www.hostedredmine.com/issues/745593 that the API change allows.

Ticket History (3/8 Histories)

2022-06-12 03:34 Updated by: cazfi
  • New Ticket "Json protocol dio_put_*() to return int" created
2022-06-12 05:14 Updated by: cazfi
  • 負責人 Update from (無) to cazfi
  • 處理結果 Update from to Accepted
2022-06-12 21:13 Updated by: cazfi
  • 處理結果 Update from Accepted to
評語

clang gives a bunch of "variable 'e' set but not used" -warnings.

2022-06-13 00:36 Updated by: cazfi
評語

Reply To cazfi

clang gives a bunch of "variable 'e' set but not used" -warnings.

These indicate real bug - the "use" would be checking the error value, and certainly it should be made when ever error might have been set.

2022-06-13 01:20 Updated by: cazfi
  • 處理結果 Update from to Accepted
評語

Reply To cazfi

the "use" would be checking the error value, and certainly it should be made when ever error might have been set.

Fixed.

2022-06-24 21:24 Updated by: cazfi
  • 狀態 Update from 開啟 to 關閉
  • 處理結果 Update from Accepted to 修正

編輯

Please login to add comment to this ticket » 登入