generate_packets.py: remove Variant members only needed on Packets

• 回報者: alienvalkyrie
• 負責人: alienvalkyrie
• 類型: 修補檔案
• 狀態: 關閉
• 元件: Bootstrap
• 里程碑: 3.2.0
• 優先權: 5 - 中
• 嚴重程度: 5 - 中
• 處理結果: 修正
• 檔案: 1

細節

Part of #43927. Some code is unnecessarily duplicated between Packets and Variants. Remove the fields and members of the Variant class that are only used on Packets, or that can be taken unmodified from the packet this is a variant of.

Ticket History (3/4 Histories)

2022-06-07 02:57 Updated by: alienvalkyrie

• New Ticket "generate_packets.py: remove Variant members only needed on Packets" created

2022-06-07 05:15 Updated by: alienvalkyrie

• File 0009-generate_packets.py-remove-superfluous-Variant-membe.patch (File ID: 9421) is attached

2022-06-07 05:16 Updated by: alienvalkyrie

• 處理結果 Update from 無 to Accepted

評語

Reply To alienvalkyrie

or that can be taken unmodified from the packet this is a variant of.

This patch leaves some of those fields in if they are used in a lot of places – those should be turned into properties in #44768.

2022-06-08 20:21 Updated by: alienvalkyrie

• 狀態 Update from 開啟 to 關閉
• 處理結果 Update from Accepted to 修正