待辦事項 #44611

Optimize some heavy MAX() and MIN() uses

啟用日期: 2022-05-15 15:02 最後更新: 2022-07-05 04:55

回報者:
負責人:
類型:
狀態:
關閉
元件:
里程碑:
優先權:
5 - 中
嚴重程度:
5 - 中
處理結果:
修正
檔案:
3

細節

We have some MAX() and MIN() uses where one of the parameters is relatively heavy to evaluate AND such that the compiler cannot optimize away the need to do the full evaluation twice (a function call of which compiler does not know that it will return the same value both times, and has no side-effects)

Move such heavy evaluations outside the macros, to do them only once.

Ticket History (3/7 Histories)

2022-05-15 15:02 Updated by: cazfi
  • New Ticket "Optimize some heavy MAX() and MIN() uses" created
2022-05-29 06:46 Updated by: cazfi
2022-06-26 20:22 Updated by: cazfi
  • 負責人 Update from (無) to cazfi
  • 處理結果 Update from to Accepted
評語

For master I went through all MAX() and MIN() uses for candidates to change. For older branches I just ported those same changes, not checking if there would be additional candidates in them - except for porting gtk3.22-client changes to older gtk-clients supported only in older branches.

2022-07-05 04:55 Updated by: cazfi
  • 狀態 Update from 開啟 to 關閉
  • 處理結果 Update from Accepted to 修正

編輯

Please login to add comment to this ticket » 登入