stub.serv not in the tarball

• 回報者: cazfi
• 負責人: cazfi
• 類型: 問題回報
• 狀態: 關閉
• 元件: Bootstrap
• 里程碑: 3.1.0 (closed)
• 優先權: 5 - 中
• 嚴重程度: 5 - 中
• 處理結果: 修正
• 檔案: 6

細節

Mason build from a S3_1 tarball fails with: "ERROR: File data/stub.serv does not exist."

master no longer needs stub.serv, but data/Makefile.am there seems to do the same omission with stub.modpack.

Ticket History (3/13 Histories)

2022-05-10 10:13 Updated by: cazfi

• New Ticket "stub.serv not in the tarball" created

2022-05-10 10:20 Updated by: cazfi

• File 0045-Add-stub.serv-and-stub.modpack-to-the-tarball.patch (File ID: 9194) is attached

2022-05-10 10:21 Updated by: cazfi

• File 0031-Add-stub.serv-to-the-tarball.patch (File ID: 9195) is attached

2022-05-10 10:21 Updated by: cazfi

• 負責人 Update from (無) to cazfi
• 處理結果 Update from 無 to Accepted

評語

Reply To cazfi

master no longer needs stub.serv, but data/Makefile.am there seems to do the same omission with stub.modpack.

Actually it needs both (.serv & .modpack) in case of stub ruleset.

2022-05-10 10:33 Updated by: cazfi

• File 0031-Add-stub.serv-to-the-tarball.patch (File ID: 9196) is attached

2022-05-10 10:35 Updated by: cazfi

評語

- New version for S3_1, where the file added to SRV_RE_FILES was not automatically added also to EXTRA_DIST. Changed EXTRA_DIST to contain all of SRV_RE_FILES instead of each and every member separately.

2022-05-10 10:48 Updated by: cazfi

• 處理結果 Update from Accepted to 無

評語

Actually I've been approaching this wrong way altogether. We've intentionally left stub.serv (and .modpack) out from the release, so that it would not appear in the ruleset list of a release build client. The bug is that meson build tries to make it available.

2022-05-10 11:00 Updated by: cazfi

• File 0046-Meson-Do-not-try-to-install-stub.serv.patch (File ID: 9197) is attached

2022-05-10 11:01 Updated by: cazfi

• File 0032-Meson-Do-not-try-to-install-stub.serv.patch (File ID: 9198) is attached

2022-05-10 11:01 Updated by: cazfi

• 處理結果 Update from 無 to Accepted

評語

Reply To cazfi

The bug is that meson build tries to make it available.

Largely untested patches attached.

2022-05-11 02:13 Updated by: cazfi

• File 0036-Meson-Do-not-try-to-install-stub.serv-or-stub.modpac.patch (File ID: 9201) is attached

2022-05-11 02:14 Updated by: cazfi

評語

- New master version where also the stub.modpack change in meson.build

2022-05-12 22:05 Updated by: cazfi

• 狀態 Update from 開啟 to 關閉
• 處理結果 Update from Accepted to 修正