create_command_newcomer() may break if there's no dead players

• 回報者: cazfi
• 負責人: cazfi
• 類型: 問題回報
• 狀態: 關閉
• 元件: Server
• 里程碑: 3.0.2 (closed)
• 優先權: 5 - 中
• 嚴重程度: 5 - 中
• 處理結果: 修正
• 檔案: 1

細節

create_command_newcomer() may try to free player slot for the new player by removing dead player(s). This works correctly only when there's exactly one dead player. If there's none -> it still continues as if it now would have a free slot. If there's more than one -> the message about "replacing dead player" has a wrong name (last of the freed dead players, while it will replace the first one).

Ticket History (3/6 Histories)

2022-05-02 08:13 Updated by: cazfi

• New Ticket "create_command_newcomer() may break if there's no dead players" created

2022-05-02 08:28 Updated by: cazfi

• 里程碑 Update from (無) to 3.0.2 (closed)

2022-05-03 04:11 Updated by: cazfi

• File 0049-create_command_newcomer-Do-not-assume-one-dead-playe.patch (File ID: 9142) is attached

2022-05-03 04:11 Updated by: cazfi

• 負責人 Update from (無) to cazfi
• 處理結果 Update from 無 to Accepted

評語

Will push even to S2_6

2022-05-12 09:43 Updated by: cazfi

評語

Reply To cazfi

Will push even to S2_6

No, I won't. This introduces a new string, and we don't assume translators to touch S2_6 any more.

2022-05-12 10:00 Updated by: cazfi

• 狀態 Update from 開啟 to 關閉
• 處理結果 Update from Accepted to 修正