待辦事項 #44386

sanity_check_ruleset_data() needs clearing old compat code?

啟用日期: 2022-04-16 00:22 最後更新: 2022-05-02 13:54

回報者:
負責人:
類型:
狀態:
關閉
元件:
里程碑:
優先權:
5 - 中
嚴重程度:
5 - 中
處理結果:
修正
檔案:
2

細節

sanity_check_ruleset_data() comment about ignore_retired is suspicious: "were retired in Freeciv 3.0."

So is the compat code in question supposed to be in later branches? Sounds like it would allow things that were not legal even in the versions that the compatibility is expected with (3.0 compat in S3_1, 3.1 compat in master)

Ticket History (3/6 Histories)

2022-04-16 00:22 Updated by: cazfi
  • New Ticket "sanity_check_ruleset_data() needs clearing old compat code?" created
2022-04-21 04:26 Updated by: cazfi
評語

It doesn't really doable to differentiate between what's supposed to be acceptable conflict in a compat mode, and which are not. The current condition at least makes all conflicts illegal outside compat mode.

What should be changed here, is to do full check also in compat mode, if we are in fact loading ruleset of the current freeciv version's format.

2022-04-22 06:32 Updated by: cazfi
  • 負責人 Update from (無) to cazfi
  • 處理結果 Update from to Accepted
2022-05-02 13:54 Updated by: cazfi
  • 狀態 Update from 開啟 to 關閉
  • 處理結果 Update from Accepted to 修正

編輯

Please login to add comment to this ticket » 登入