rssanity.c does the same on number of places outside effect_list_sanity_cb()
As the ruleset_error() currently stands, there's not much difference between ruleset_error(LOG_ERROR ...) and log_error() -> this is probably not worth fixing in S3_0.
The main difference between those functions is that ruleset_error() has a buffer of just 1024 bytes, and do_log() that log_error() uses buffer size is MAX_LEN_LOG_LINE (5120), so changing those calls to ruleset_error() would actually risk truncating them. Will open a new ticket about increasing ruleset_error() buffer size.
Reply To cazfi
As the ruleset_error() currently stands, there's not much difference between ruleset_error(LOG_ERROR ...) and log_error() -> this is probably not worth fixing in S3_0.
This might change with #45395, in a way that makes this ticket its dependency (should properly call ruleset_error() before assuming change in ruleset_error() behavior to take effect)
effect_list_sanity_cb() reports some errors with log_error() instead of ruleset_error(). That's likely a bug.