S3_0 legacysave.c nplayers check only when asserts enabled

• 回報者: cazfi
• 負責人: cazfi
• 類型: 問題回報
• 狀態: 關閉
• 元件: Server
• 里程碑: 3.0.1 (closed)
• 優先權: 5 - 中
• 嚴重程度: 5 - 中
• 處理結果: 修正
• 檔案: 2

細節

S3_0 legacysave.c checks consistency on player count from the savegame in an assert(). That's wrong as savegame is external data, that can be wrong even if the freeciv program is correct. The consistency should be checked also when asserts (for programs internal logic) are not enabled.

Ticket History (3/5 Histories)

2022-03-17 10:23 Updated by: cazfi

• New Ticket "S3_0 legacysave.c nplayers check only when asserts enabled" created

2022-03-17 10:29 Updated by: cazfi

• File 0021-Legacy-save-Handle-player-count-inconsistency-also-i.patch (File ID: 8776) is attached

2022-03-17 10:29 Updated by: cazfi

• File 0006-Legacy-save-Handle-player-count-inconsistency-also-i.patch (File ID: 8777) is attached

2022-03-17 10:29 Updated by: cazfi

• 負責人 Update from (無) to cazfi
• 處理結果 Update from 無 to Accepted

評語

Also S2_6 version attached, without introducing new translatable string.

2022-03-18 23:42 Updated by: cazfi

• 狀態 Update from 開啟 to 關閉
• 處理結果 Update from Accepted to 修正