Client returns with EXIT_SUCCESS after failing to load tileset
Going to push also to S2_6 (S3_0 patch applies) as this helps debugging efforts when porting to new environments (and that's what S2_6 is all about now - only used for platforms for which S3_0 is not easy to reach)
Reply To cazfi
Going to push also to S2_6 (S3_0 patch applies)
S2_6 will need patch of its own - xaw-client has calls to client_exit() (which is probably the reason the function is not static in client_main.c - something I wondered when making the patch for later branches)
Client is supposed to return EXIT_FAILURE when it aborts due to failed tileset load:
--
log_error(_("Can't load requested tileset %s!"), forced_tileset_name);
client_exit();
return EXIT_FAILURE;
--
But client_exit() there never returns (should be marked noreturn, but that's another issue) to do that 'return EXIT_FAILURE'. Instead it does 'exit(EXIT_SUCCESS);'