待辦事項 #43759

Metamessage resetted on ruleset load

啟用日期: 2022-02-01 21:44 最後更新: 2022-03-25 00:45

回報者:
負責人:
類型:
狀態:
關閉
元件:
里程碑:
優先權:
5 - 中
嚴重程度:
5 - 中
處理結果:
修正
檔案:
4

細節

As metamessage was turned to a server setting in freeciv-3.0, it now gets resetted to default (empty value) when a new ruleset is loaded. That's even when it has been set with the (supposedly backward compatible) dedicated 'metamessage' command, and not via 'set' command interface.

Ticket History (3/13 Histories)

2022-02-01 21:44 Updated by: cazfi
  • New Ticket "Metamessage reseted on ruleset load" created
2022-02-01 21:48 Updated by: cazfi
評語

Arguably resetting *any* server operation related settings just when the rules should change is a bug.

2022-02-01 21:48 Updated by: cazfi
  • Summary Updated
2022-02-01 22:51 Updated by: cazfi
評語

Attached is a S3_0 patch that I've applied to cazfi.net server as a quick fix. It might be a sensible starting point.

2022-02-03 23:51 Updated by: cazfi
2022-03-13 06:03 Updated by: cazfi
  • 負責人 Update from (無) to cazfi
  • 處理結果 Update from to Accepted
評語

Attached is the earlier patch with minimal adjustments. I have a feeling that the change is a bit big for resolving a simple problem, but no better solution has been suggested and I consider this one of the most important issues to fix in 3.0.1.

2022-03-13 23:09 Updated by: cazfi
  • 處理結果 Update from Accepted to
評語

Patch going to master should follow new CodingStyle compound literals recommendation.

2022-03-14 08:23 Updated by: cazfi
  • 處理結果 Update from to Accepted
評語

- New master version with compound literals used

2022-03-25 00:45 Updated by: cazfi
  • 狀態 Update from 開啟 to 關閉
  • 處理結果 Update from Accepted to 修正

編輯

Please login to add comment to this ticket » 登入