待辦事項 #43708

Ruleset files version consistency

啟用日期: 2022-01-27 11:13 最後更新: 2022-03-27 05:58

回報者:
負責人:
類型:
狀態:
關閉
元件:
里程碑:
優先權:
5 - 中
嚴重程度:
5 - 中
處理結果:
修正
檔案:
1

細節

Alina L. wrote about ruleset format versions in https://www.hostedredmine.com/issues/695469

"which file's version should be checked? All possibly relevant ones (and hope they don't disagree)?"

--

We probably shouldn't try to support rulesets where the individual files disagree on version. I'd suggest replacing separate version numbers in rscompat_info with just one version, checking that all files agree (where we currently fill compat->ver_...), and considering it a hard ruleset loading failure when they don't.

Ticket History (3/6 Histories)

2022-01-27 11:13 Updated by: cazfi
  • New Ticket "Ruleset files version consistency" created
2022-02-15 01:12 Updated by: alienvalkyrie
  • 負責人 Update from (無) to alienvalkyrie
評語

Should we already do this for 3.1? I think it's unlikely anyone is using mixed format versions during their ruleset update process, but if they are, sticking to 3.2 would leave them more time to adapt.

2022-02-16 05:20 Updated by: alienvalkyrie
  • 處理結果 Update from to Accepted
  • 里程碑 Update from (無) to S3_2 d3f (closed)
評語

Reply To alienvalkyrie

Should we already do this for 3.1? I think it's unlikely anyone is using mixed format versions during their ruleset update process, but if they are, sticking to 3.2 would leave them more time to adapt.

I'll go ahead and stick with that, then.

2022-02-17 09:05 Updated by: alienvalkyrie
  • 狀態 Update from 開啟 to 關閉
  • 處理結果 Update from Accepted to 修正
2022-03-27 05:58 Updated by: alienvalkyrie
評語

Backported to S3_1: #44203

編輯

Please login to add comment to this ticket » 登入