待辦事項 #43204

Drop unused last_turns_shield_surplus from edit_city packet

啟用日期: 2021-11-13 17:16 最後更新: 2021-11-30 14:15

回報者:
負責人:
類型:
狀態:
關閉
元件:
里程碑:
優先權:
5 - 中
嚴重程度:
5 - 中
處理結果:
修正
檔案:
1

細節

Ihnatus in #42685:
"There is a field last_turns_shield_surplus in editing protocol but it is currently not used."

Drop the unused field from the branches where network protocol change is trivially allowed (S3_1 & master)

Ticket History (3/6 Histories)

2021-11-13 17:16 Updated by: cazfi
  • New Ticket "Drop unused last_turns_shield_surplus from edit_city packet" created
2021-11-13 17:30 Updated by: cazfi
  • 處理結果 Update from to Accepted
2021-11-14 07:42 Updated by: ihnatus
評語

Hm, maybe make use of it in newer versions rather than dropping it? Well, it's not a minute task to understand what shields do what and what we want them to do...

2021-11-14 08:26 Updated by: cazfi
評語

Reply To ihnatus

Hm, maybe make use of it in newer versions rather than dropping it? Well, it's not a minute task to understand what shields do what and what we want them to do...

I find it unlikely that it will ever get used. For starters, there isn't often such a thing as "last turn" for a city in editor, as the city has likely been added in the same turn.

If that field is ever needed in the network protocol, it's trivial to add back at that time - no need to keep on sending (uninitialized - delta protocol poison) value meanwhile.

2021-11-30 14:15 Updated by: cazfi
  • 狀態 Update from 開啟 to 關閉
  • 負責人 Update from (無) to cazfi
  • 處理結果 Update from Accepted to 修正

編輯

Please login to add comment to this ticket » 登入