Sanity check Wonder upkeep

• 回報者: cazfi
• 負責人: cazfi
• 類型: 修補檔案
• 狀態: 關閉
• 元件: Server
• 里程碑: 2.6.6 (closed)
• 優先權: 5 - 中
• 嚴重程度: 5 - 中
• 處理結果: 修正
• 檔案: 4

細節

Related to #42993 reported by Lexxie. There should be ruleset loading time sanity check that upkeep value given for a wonder is zero. Wonder upkeep is already always considered zero, but the ruleset author is being left under impression that the nonzero value from the ruleset is being accepted.

Ticket History (3/10 Histories)

2021-10-08 01:33 Updated by: cazfi

• New Ticket "Sanity check Wonder upkeep" created

2021-10-09 14:32 Updated by: cazfi

• File 0044-Sanity-check-that-wonder-upkeep-is-zero.patch (File ID: 7604) is attached

2021-10-09 14:32 Updated by: cazfi

• File 0011-Sanity-check-that-wonder-upkeep-is-zero.patch (File ID: 7605) is attached

2021-10-09 14:32 Updated by: cazfi

• 處理結果 Update from 無 to Accepted
• 里程碑 Update from (無) to 2.6.6 (closed)

2021-10-09 15:51 Updated by: cazfi

評語

Alien ruleset fails this sanity check: #43002

That needs to be addressed before applying this. Moreover, we probably should not completely fail loading rulesets that previously loaded fine in d3f branches.

2021-10-10 03:27 Updated by: cazfi

• File 0015-Sanity-check-that-wonder-upkeep-is-zero.patch (File ID: 7616) is attached

2021-10-10 03:27 Updated by: cazfi

• File 0011-Sanity-check-that-wonder-upkeep-is-zero.patch (File ID: 7617) is attached

2021-10-10 03:29 Updated by: cazfi

評語

Reply To cazfi

Moreover, we probably should not completely fail loading rulesets that previously loaded fine in d3f branches.

Attached new versions of the patch for S2_6 and S3_0 that give just deprecation warning when there's wonder with nonzero upkeep.

2021-10-12 17:23 Updated by: cazfi

評語

Before this can be pushed, master needs #43033 and S3_1 #43006

2021-10-19 13:39 Updated by: cazfi

• 狀態 Update from 開啟 to 關閉
• 負責人 Update from (無) to cazfi
• 處理結果 Update from Accepted to 修正